Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #4064 Add application/x-x509-ca-cert as allowable MIME type for aws_s3_bucket_object #4298

Closed
wants to merge 2 commits into from

Conversation

saravanan30erd
Copy link
Contributor

No description provided.

@ghost ghost added the size/XS Managed by automation to categorize the size of a PR. label Apr 21, 2018
@ghost ghost added size/M Managed by automation to categorize the size of a PR. and removed size/XS Managed by automation to categorize the size of a PR. labels Apr 21, 2018
@saravanan30erd
Copy link
Contributor Author

saravanan30erd commented Apr 21, 2018

$ make testacc TEST=./aws TESTARGS='-run=TestAccDataSourceAWSS3BucketObject_readableBodyXX509CACert'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccDataSourceAWSS3BucketObject_readableBodyXX509CACert -timeout 120m
=== RUN TestAccDataSourceAWSS3BucketObject_readableBodyXX509CACert
--- PASS: TestAccDataSourceAWSS3BucketObject_readableBodyXX509CACert (158.97s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 159.008s

@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. service/s3 Issues and PRs that pertain to the s3 service. labels Apr 23, 2018
@saravanan30erd
Copy link
Contributor Author

@bflad is there anything I can do to push this?

@bflad
Copy link
Contributor

bflad commented May 12, 2018

@saravanan30erd you might want to take a look at the link in the comment for the isContentTypeAllowed() function there: hashicorp/terraform#3858 (comment)

We cannot guarantee that this MIME type is UTF-8 safe and it could corrupt the Terraform state given the right binary content. This would need to be Base64 encoded in another attribute for safety.

@bflad bflad added the waiting-response Maintainers are waiting on response from community or contributor. label May 30, 2018
@bflad
Copy link
Contributor

bflad commented Sep 6, 2018

Closing due to lack of response and because the change as implemented could introduce Terraform state corruption due to the content type. We might accept a different solution that instead works with Base64 encoding content of binary content before it enters the Terraform state.

@bflad bflad closed this Sep 6, 2018
@ghost
Copy link

ghost commented Apr 3, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 3, 2020
@breathingdust breathingdust removed the waiting-response Maintainers are waiting on response from community or contributor. label Sep 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/s3 Issues and PRs that pertain to the s3 service. size/M Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants