Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Resource: aws_neptune_cluster_parameter_group #4860

Merged
merged 6 commits into from
Jun 18, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions aws/provider.go
Original file line number Diff line number Diff line change
Expand Up @@ -625,6 +625,7 @@ func Provider() terraform.ResourceProvider {
"aws_batch_job_definition": resourceAwsBatchJobDefinition(),
"aws_batch_job_queue": resourceAwsBatchJobQueue(),
"aws_neptune_subnet_group": resourceAwsNeptuneSubnetGroup(),
"aws_neptune_cluster_parameter_group": resourceAwsNeptuneClusterParameterGroup(),

// ALBs are actually LBs because they can be type `network` or `application`
// To avoid regressions, we will add a new resource for each and they both point
Expand Down
259 changes: 259 additions & 0 deletions aws/resource_aws_neptune_cluster_parameter_group.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,259 @@
package aws

import (
"fmt"
"log"

"github.com/aws/aws-sdk-go/aws"
"github.com/aws/aws-sdk-go/service/neptune"

"github.com/hashicorp/terraform/helper/resource"
"github.com/hashicorp/terraform/helper/schema"
"github.com/hashicorp/terraform/helper/validation"
)

const neptuneClusterParameterGroupMaxParamsBulkEdit = 20

func resourceAwsNeptuneClusterParameterGroup() *schema.Resource {
return &schema.Resource{
Create: resourceAwsNeptuneClusterParameterGroupCreate,
Read: resourceAwsNeptuneClusterParameterGroupRead,
Update: resourceAwsNeptuneClusterParameterGroupUpdate,
Delete: resourceAwsNeptuneClusterParameterGroupDelete,
Importer: &schema.ResourceImporter{
State: schema.ImportStatePassthrough,
},

Schema: map[string]*schema.Schema{
"arn": {
Type: schema.TypeString,
Computed: true,
},
"name": {
Type: schema.TypeString,
Optional: true,
Computed: true,
ForceNew: true,
ConflictsWith: []string{"name_prefix"},
ValidateFunc: validateNeptuneParamGroupName,
},
"name_prefix": {
Type: schema.TypeString,
Optional: true,
Computed: true,
ForceNew: true,
ValidateFunc: validateNeptuneParamGroupNamePrefix,
},
"family": {
Type: schema.TypeString,
Required: true,
ForceNew: true,
},
"description": {
Type: schema.TypeString,
Optional: true,
ForceNew: true,
Default: "Managed by Terraform",
},
"parameter": {
Type: schema.TypeSet,
Optional: true,
Elem: &schema.Resource{
Schema: map[string]*schema.Schema{
"name": {
Type: schema.TypeString,
Required: true,
},
"value": {
Type: schema.TypeString,
Required: true,
},
"apply_method": {
Type: schema.TypeString,
Optional: true,
Default: neptune.ApplyMethodPendingReboot,
ValidateFunc: validation.StringInSlice([]string{
neptune.ApplyMethodImmediate,
neptune.ApplyMethodPendingReboot,
}, false),
},
},
},
},

"tags": tagsSchema(),
},
}
}

func resourceAwsNeptuneClusterParameterGroupCreate(d *schema.ResourceData, meta interface{}) error {
conn := meta.(*AWSClient).neptuneconn
tags := tagsFromMapNeptune(d.Get("tags").(map[string]interface{}))

var groupName string
if v, ok := d.GetOk("name"); ok {
groupName = v.(string)
} else if v, ok := d.GetOk("name_prefix"); ok {
groupName = resource.PrefixedUniqueId(v.(string))
} else {
groupName = resource.UniqueId()
}

createOpts := neptune.CreateDBClusterParameterGroupInput{
DBClusterParameterGroupName: aws.String(groupName),
DBParameterGroupFamily: aws.String(d.Get("family").(string)),
Description: aws.String(d.Get("description").(string)),
Tags: tags,
}

log.Printf("[DEBUG] Create Neptune Cluster Parameter Group: %#v", createOpts)
resp, err := conn.CreateDBClusterParameterGroup(&createOpts)
if err != nil {
return fmt.Errorf("Error creating Neptune Cluster Parameter Group: %s", err)
}

d.SetId(aws.StringValue(createOpts.DBClusterParameterGroupName))
log.Printf("[INFO] Neptune Cluster Parameter Group ID: %s", d.Id())

d.Set("arn", resp.DBClusterParameterGroup.DBClusterParameterGroupArn)

return resourceAwsNeptuneClusterParameterGroupUpdate(d, meta)
}

func resourceAwsNeptuneClusterParameterGroupRead(d *schema.ResourceData, meta interface{}) error {
conn := meta.(*AWSClient).neptuneconn

describeOpts := neptune.DescribeDBClusterParameterGroupsInput{
DBClusterParameterGroupName: aws.String(d.Id()),
}

describeResp, err := conn.DescribeDBClusterParameterGroups(&describeOpts)
if err != nil {
if isAWSErr(err, neptune.ErrCodeDBParameterGroupNotFoundFault, "") {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The SDK provides a separate constant for cluster parameter groups: ErrCodeDBClusterParameterGroupNotFoundFault

log.Printf("[WARN] Neptune Cluster Parameter Group (%s) not found, removing from state", d.Id())
d.SetId("")
return nil
}

return err
}

if len(describeResp.DBClusterParameterGroups) == 0 {
log.Printf("[WARN] Neptune Cluster Parameter Group (%s) not found, removing from state", d.Id())
d.SetId("")
return nil
}

d.Set("name", describeResp.DBClusterParameterGroups[0].DBClusterParameterGroupName)
d.Set("family", describeResp.DBClusterParameterGroups[0].DBParameterGroupFamily)
d.Set("description", describeResp.DBClusterParameterGroups[0].Description)
arn := aws.StringValue(describeResp.DBClusterParameterGroups[0].DBClusterParameterGroupArn)
d.Set("arn", arn)

// Only include user customized parameters as there's hundreds of system/default ones
describeParametersOpts := neptune.DescribeDBClusterParametersInput{
DBClusterParameterGroupName: aws.String(d.Id()),
Source: aws.String("user"),
}

describeParametersResp, err := conn.DescribeDBClusterParameters(&describeParametersOpts)
if err != nil {
return err
}

if err := d.Set("parameter", flattenNeptuneParameters(describeParametersResp.Parameters)); err != nil {
return fmt.Errorf("error setting neptune parameter: %s", err)
}

resp, err := conn.ListTagsForResource(&neptune.ListTagsForResourceInput{
ResourceName: aws.String(arn),
})
if err != nil {
log.Printf("[DEBUG] Error retrieving tags for ARN: %s", arn)
}

if err := d.Set("tags", tagsToMapNeptune(resp.TagList)); err != nil {
return fmt.Errorf("error setting neptune tags: %s", err)
}

return nil
}

func resourceAwsNeptuneClusterParameterGroupUpdate(d *schema.ResourceData, meta interface{}) error {
conn := meta.(*AWSClient).neptuneconn

d.Partial(true)

if d.HasChange("parameter") {
o, n := d.GetChange("parameter")
if o == nil {
o = new(schema.Set)
}
if n == nil {
n = new(schema.Set)
}

os := o.(*schema.Set)
ns := n.(*schema.Set)

parameters, err := expandNeptuneParameters(ns.Difference(os).List())
if err != nil {
return err
}

if len(parameters) > 0 {
// We can only modify 20 parameters at a time, so walk them until
// we've got them all.
for parameters != nil {
paramsToModify := make([]*neptune.Parameter, 0)
if len(parameters) <= neptuneClusterParameterGroupMaxParamsBulkEdit {
paramsToModify, parameters = parameters[:], nil
} else {
paramsToModify, parameters = parameters[:neptuneClusterParameterGroupMaxParamsBulkEdit], parameters[neptuneClusterParameterGroupMaxParamsBulkEdit:]
}
parameterGroupName := d.Get("name").(string)
modifyOpts := neptune.ModifyDBClusterParameterGroupInput{
DBClusterParameterGroupName: aws.String(parameterGroupName),
Parameters: paramsToModify,
}

log.Printf("[DEBUG] Modify Neptune Cluster Parameter Group: %s", modifyOpts)
_, err = conn.ModifyDBClusterParameterGroup(&modifyOpts)
if err != nil {
return fmt.Errorf("Error modifying Neptune Cluster Parameter Group: %s", err)
}
}
d.SetPartial("parameter")
}
}

arn := d.Get("arn").(string)
if err := setTagsNeptune(conn, d, arn); err != nil {
return err
} else {
d.SetPartial("tags")
}

d.Partial(false)

return resourceAwsNeptuneClusterParameterGroupRead(d, meta)
}

func resourceAwsNeptuneClusterParameterGroupDelete(d *schema.ResourceData, meta interface{}) error {
conn := meta.(*AWSClient).neptuneconn

input := neptune.DeleteDBClusterParameterGroupInput{
DBClusterParameterGroupName: aws.String(d.Id()),
}

log.Printf("[DEBUG] Deleting Neptune Cluster Parameter Group: %s", d.Id())
_, err := conn.DeleteDBClusterParameterGroup(&input)
if err != nil {
if isAWSErr(err, neptune.ErrCodeDBParameterGroupNotFoundFault, "") {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The SDK provides a separate constant for cluster parameter groups: ErrCodeDBClusterParameterGroupNotFoundFault

return nil
}
return fmt.Errorf("error deleting Neptune Cluster Parameter Group (%s): %s", d.Id(), err)
}

return nil
}
Loading