Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/aws_glue_catalog_database: Properly return error when missing colon during import #5123

Merged
merged 1 commit into from
Jul 9, 2018
Merged

resource/aws_glue_catalog_database: Properly return error when missing colon during import #5123

merged 1 commit into from
Jul 9, 2018

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Jul 9, 2018 •
edited
Loading

Fixes #5122

Changes proposed in this pull request:

  • Check length of splitting on : in ID reading function before accessing second element to prevent panic

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSGlueCatalogDatabase'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSGlueCatalogDatabase -timeout 120m
=== RUN   TestAccAWSGlueCatalogDatabase_importBasic
--- PASS: TestAccAWSGlueCatalogDatabase_importBasic (14.27s)
=== RUN   TestAccAWSGlueCatalogDatabase_full
--- PASS: TestAccAWSGlueCatalogDatabase_full (28.08s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	42.388s

@bflad bflad added bug Addresses a defect in current functionality. crash Results from or addresses a Terraform crash or kernel panic. service/glue Issues and PRs that pertain to the glue service. labels Jul 9, 2018
@bflad bflad added this to the v1.27.0 milestone Jul 9, 2018
@ghost ghost added the size/M Managed by automation to categorize the size of a PR. label Jul 9, 2018
@bflad bflad requested a review from a team July 9, 2018 11:48
@bflad bflad mentioned this pull request Jul 9, 2018
Closed
tombuildsstuff
tombuildsstuff approved these changes Jul 9, 2018
View reviewed changes
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@bflad bflad merged commit 8afca02 into master Jul 9, 2018
@bflad bflad deleted the b-aws_glue_catalog_database-id-panic branch July 9, 2018 12:09
bflad added a commit that referenced this pull request Jul 9, 2018
@bflad
Update CHANGELOG for #5123
b99c2f2
@bflad
Copy link
Contributor Author

bflad commented Jul 11, 2018

This has been released in version 1.27.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 4, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tombuildsstuff tombuildsstuff tombuildsstuff approved these changes

Assignees
No one assigned
Labels
bug Addresses a defect in current functionality. crash Results from or addresses a Terraform crash or kernel panic. service/glue Issues and PRs that pertain to the glue service. size/M Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v1.27.0
Development

Successfully merging this pull request may close these issues.

Issue in importing and refreshing aws glue databases
2 participants
@bflad @tombuildsstuff