Data source eip filters

[kl4w]

Fixes #4551

Changes proposed in this pull request:

• add filter attribute
• add association_id attribute
• add private_ip attribute

Output from acceptance testing:

make testacc TEST=./aws TESTARGS='-run=TestAccDataSourceAwsEip'
gofmt -w $(find . -name '*.go' |grep -v vendor)
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccDataSourceAwsEip -timeout 120m
=== RUN   TestAccDataSourceAwsEip_basic
--- PASS: TestAccDataSourceAwsEip_basic (14.31s)
=== RUN   TestAccDataSourceAwsEip_filter
--- PASS: TestAccDataSourceAwsEip_filter (72.64s)
=== RUN   TestAccDataSourceAwsEip_association
--- PASS: TestAccDataSourceAwsEip_association (84.53s)
=== RUN   TestAccDataSourceAwsEip_private
--- PASS: TestAccDataSourceAwsEip_private (73.64s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	245.162s

[alexrudd]

Hey, I think this would solve my use case in #4551

Thanks @kl4w :)

[saravanan30erd]

#3525

[kl4w]

@saravanan30erd @bflad I'm happy to close this in favor of the others. Just let me know. Cheers.

[bflad]

Hi @kl4w 👋 Sorry for the very delayed response. I spent some time merging together #3505, #3522, and #3525 for the aws_eip data source, which required some refactoring to get everything working together and testing correctly on master. Would you be able to rebase this PR or submit a new one? Apologies for the hassle. 😅

[kl4w]

@bflad i'm going to close this PR and submit a new one for setting some extra attributes

[kl4w]

@bflad created a new PR: #6463

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!