Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/aws_db_instance: Prevent double apply for snapshot_identifier with multiple other arguments #5621

Merged
merged 1 commit into from
Aug 22, 2018

Commits on Aug 21, 2018

  1. resource/aws_db_instance: Prevent double apply for snapshot_identifie…

    …r with multiple other arguments
    
    * backup_retention_period
    * backup_window
    * iam_database_authentication_enabled
    * maintenance_window
    * monitoring_interval
    * monitoring_role_arn
    * parameter_group_name
    
    Previously:
    
    ```
    --- FAIL: TestAccAWSDBInstance_SnapshotIdentifier_BackupRetentionPeriod (1154.50s)
    	testing.go:527: Step 0 error: Check failed: Check 4/4 error: aws_db_instance.test: Attribute 'backup_retention_period' expected "1", got "0"
    --- FAIL: TestAccAWSDBInstance_SnapshotIdentifier_BackupWindow (1195.82s)
    	testing.go:527: Step 0 error: Check failed: Check 4/4 error: aws_db_instance.test: Attribute 'backup_window' expected "00:00-08:00", got "06:13-06:43"
    --- FAIL: TestAccAWSDBInstance_SnapshotIdentifier_IamDatabaseAuthenticationEnabled (1113.22s)
    	testing.go:527: Step 0 error: Check failed: Check 4/4 error: aws_db_instance.test: Attribute 'iam_database_authentication_enabled' expected "true", got "false"
    --- FAIL: TestAccAWSDBInstance_SnapshotIdentifier_MaintenanceWindow (1259.26s)
    	testing.go:527: Step 0 error: Check failed: Check 4/4 error: aws_db_instance.test: Attribute 'maintenance_window' expected "Sun:01:00-Sun:01:30", got "wed:10:33-wed:11:03"
    --- FAIL: TestAccAWSDBInstance_SnapshotIdentifier_Monitoring (1214.60s)
    	testing.go:527: Step 0 error: Check failed: Check 4/4 error: aws_db_instance.test: Attribute 'monitoring_interval' expected "5", got "0"
    --- FAIL: TestAccAWSDBInstance_SnapshotIdentifier_ParameterGroupName (1134.54s)
    	testing.go:527: Step 0 error: Check failed: Check 4/4 error: aws_db_instance.test: Attribute 'parameter_group_name' expected "tf-acc-test-4546585708384390733", got "default.mariadb10.2"
    ```
    bflad committed Aug 21, 2018
    Configuration menu
    Copy the full SHA
    09be94f View commit details
    Browse the repository at this point in the history