Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

data-source/aws_ami: Add note that owners argument will be required in next major version #5626

Merged
merged 2 commits into from
Aug 21, 2018
Merged

data-source/aws_ami: Add note that owners argument will be required in next major version #5626

merged 2 commits into from
Aug 21, 2018

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Aug 21, 2018

Reference: #5576

Changes proposed in this pull request:

  • data-source/aws_ami: Add note that owners argument will be required in next major version
  • data-source/aws_ami_ids: Add note that owners argument will be required in next major version

Output from acceptance testing: N/A

@bflad bflad added documentation Introduces or discusses updates to documentation. service/ec2 Issues and PRs that pertain to the ec2 service. labels Aug 21, 2018
@bflad bflad added this to the v1.33.0 milestone Aug 21, 2018
@bflad bflad requested a review from a team August 21, 2018 13:45
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. labels Aug 21, 2018
@ghost ghost added size/S Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. and removed size/XS Managed by automation to categorize the size of a PR. labels Aug 21, 2018
tombuildsstuff
tombuildsstuff approved these changes Aug 21, 2018
View reviewed changes
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@bflad bflad merged commit b313d17 into master Aug 21, 2018
@bflad bflad deleted the d-aws_ami-owners-required-soon branch August 21, 2018 17:36
@bflad bflad mentioned this pull request Aug 22, 2018
Merged
@ghost
Copy link

ghost commented Apr 3, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tombuildsstuff tombuildsstuff tombuildsstuff approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. service/ec2 Issues and PRs that pertain to the ec2 service. size/S Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v1.33.0
Development

Successfully merging this pull request may close these issues.
2 participants
@bflad @tombuildsstuff