[wip] resource/aws_ses_receipt_rule: support import functionality

[acburdine]

Changes proposed in this pull request:

• Add import functionality for aws_ses_receipt_rule

Output from acceptance testing:

Haven't run it yet, waiting on response to the below comment.

[acburdine]

After doing some more looking at other resources with imports, it appears this isn't quite the right approach since it won't import the whole state (with all of the more complicated rules and whatnot).

Ideally, we could use schema.ImportStatePassthrough to lookup the rule, but as far as I can tell the resource currently uses just the rule name as an ID, rather than a composite id in the form <ruleset name>:<rule name>. Based on the fact that rules are specific to a ruleset, I think it would be better to have the ID be a composite of the ruleset and rule (similar to the iam_role_policy resource).

I'm not sure what the policy is for changing the ID format, so I'd appreciate some feedback on what the best approach to implement this is 😄

[bflad]

Hi @acburdine! 👋 Thanks for submitting this. We currently denote changing resource IDs as a major version breaking change since some folks might be relying on the attribute in other references. See also: https://www.terraform.io/docs/extend/best-practices/versioning.html#example-major-number-increments

During import, we only need to d.Set() enough information to make the Read function succeed, which is immediately called. This looks like its in pretty good shape to implement the import functionality without changing the ID minus the CI errors. Once that's fixed up we can verify the acceptance testing. 👍

[bflad]

Hi again, @acburdine. 👋 Since we haven't heard back from you for awhile and the fix was trivial, I added a commit after yours so we could get this feature in.

--- PASS: TestAccAWSSESReceiptRule_actions (12.99s)
--- PASS: TestAccAWSSESReceiptRule_basic (12.99s)
--- PASS: TestAccAWSSESReceiptRule_order (16.54s)
--- PASS: TestAccAWSSESReceiptRule_s3Action (28.28s)

[bflad]

This has been released in version 1.44.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!