Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/iam_role: support for tags #6499

Merged
merged 7 commits into from
Nov 19, 2018
Merged

r/iam_role: support for tags #6499

merged 7 commits into from
Nov 19, 2018

Conversation

kl4w
Copy link
Contributor

@kl4w kl4w commented Nov 16, 2018

References #6492
Requires: #6497

Changes proposed in this pull request:

  • support for tags

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSIAMRole_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 20 -run=TestAccAWSIAMRole_ -timeout 120m
=== RUN   TestAccAWSIAMRole_importBasic
=== PAUSE TestAccAWSIAMRole_importBasic
=== RUN   TestAccAWSIAMRole_basic
=== PAUSE TestAccAWSIAMRole_basic
=== RUN   TestAccAWSIAMRole_basicWithDescription
=== PAUSE TestAccAWSIAMRole_basicWithDescription
=== RUN   TestAccAWSIAMRole_namePrefix
=== PAUSE TestAccAWSIAMRole_namePrefix
=== RUN   TestAccAWSIAMRole_testNameChange
=== PAUSE TestAccAWSIAMRole_testNameChange
=== RUN   TestAccAWSIAMRole_badJSON
=== PAUSE TestAccAWSIAMRole_badJSON
=== RUN   TestAccAWSIAMRole_disappears
=== PAUSE TestAccAWSIAMRole_disappears
=== RUN   TestAccAWSIAMRole_force_detach_policies
=== PAUSE TestAccAWSIAMRole_force_detach_policies
=== RUN   TestAccAWSIAMRole_MaxSessionDuration
=== PAUSE TestAccAWSIAMRole_MaxSessionDuration
=== RUN   TestAccAWSIAMRole_PermissionsBoundary
=== PAUSE TestAccAWSIAMRole_PermissionsBoundary
=== RUN   TestAccAWSIAMRole_tags
=== PAUSE TestAccAWSIAMRole_tags
=== CONT  TestAccAWSIAMRole_importBasic
=== CONT  TestAccAWSIAMRole_disappears
=== CONT  TestAccAWSIAMRole_force_detach_policies
=== CONT  TestAccAWSIAMRole_PermissionsBoundary
=== CONT  TestAccAWSIAMRole_tags
=== CONT  TestAccAWSIAMRole_basicWithDescription
=== CONT  TestAccAWSIAMRole_MaxSessionDuration
=== CONT  TestAccAWSIAMRole_namePrefix
=== CONT  TestAccAWSIAMRole_badJSON
=== CONT  TestAccAWSIAMRole_testNameChange
=== CONT  TestAccAWSIAMRole_basic
--- PASS: TestAccAWSIAMRole_badJSON (1.52s)
--- PASS: TestAccAWSIAMRole_disappears (6.62s)
--- PASS: TestAccAWSIAMRole_basic (8.32s)
--- PASS: TestAccAWSIAMRole_namePrefix (8.33s)
--- PASS: TestAccAWSIAMRole_importBasic (9.08s)
--- PASS: TestAccAWSIAMRole_force_detach_policies (9.51s)
--- PASS: TestAccAWSIAMRole_tags (13.31s)
--- PASS: TestAccAWSIAMRole_MaxSessionDuration (14.03s)
--- PASS: TestAccAWSIAMRole_testNameChange (15.94s)
--- PASS: TestAccAWSIAMRole_basicWithDescription (18.29s)
--- PASS: TestAccAWSIAMRole_PermissionsBoundary (30.97s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	31.015s

@ghost ghost added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/iam Issues and PRs that pertain to the iam service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Nov 16, 2018
@bflad bflad added the enhancement Requests to existing resources that expand the functionality or scope. label Nov 19, 2018
@bflad
Copy link
Contributor

bflad commented Nov 19, 2018

Once the changes from #6497 have been ported over to this pull request, will take a look. Thanks!

@bflad bflad added the waiting-response Maintainers are waiting on response from community or contributor. label Nov 19, 2018
@kl4w
Copy link
Contributor Author

kl4w commented Nov 19, 2018

@bflad rebased on top of extra changes in #6497 and extra commit for same reasons as per other review

make testacc TEST=./aws TESTARGS='-run=TestAccAWSIAMRole_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 20 -run=TestAccAWSIAMRole_ -timeout 120m
=== RUN   TestAccAWSIAMRole_importBasic
=== PAUSE TestAccAWSIAMRole_importBasic
=== RUN   TestAccAWSIAMRole_basic
=== PAUSE TestAccAWSIAMRole_basic
=== RUN   TestAccAWSIAMRole_basicWithDescription
=== PAUSE TestAccAWSIAMRole_basicWithDescription
=== RUN   TestAccAWSIAMRole_namePrefix
=== PAUSE TestAccAWSIAMRole_namePrefix
=== RUN   TestAccAWSIAMRole_testNameChange
=== PAUSE TestAccAWSIAMRole_testNameChange
=== RUN   TestAccAWSIAMRole_badJSON
=== PAUSE TestAccAWSIAMRole_badJSON
=== RUN   TestAccAWSIAMRole_disappears
=== PAUSE TestAccAWSIAMRole_disappears
=== RUN   TestAccAWSIAMRole_force_detach_policies
=== PAUSE TestAccAWSIAMRole_force_detach_policies
=== RUN   TestAccAWSIAMRole_MaxSessionDuration
=== PAUSE TestAccAWSIAMRole_MaxSessionDuration
=== RUN   TestAccAWSIAMRole_PermissionsBoundary
=== PAUSE TestAccAWSIAMRole_PermissionsBoundary
=== RUN   TestAccAWSIAMRole_tags
=== PAUSE TestAccAWSIAMRole_tags
=== CONT  TestAccAWSIAMRole_importBasic
=== CONT  TestAccAWSIAMRole_disappears
=== CONT  TestAccAWSIAMRole_badJSON
=== CONT  TestAccAWSIAMRole_PermissionsBoundary
=== CONT  TestAccAWSIAMRole_tags
=== CONT  TestAccAWSIAMRole_namePrefix
=== CONT  TestAccAWSIAMRole_testNameChange
=== CONT  TestAccAWSIAMRole_MaxSessionDuration
=== CONT  TestAccAWSIAMRole_force_detach_policies
=== CONT  TestAccAWSIAMRole_basic
=== CONT  TestAccAWSIAMRole_basicWithDescription
--- PASS: TestAccAWSIAMRole_badJSON (1.54s)
--- PASS: TestAccAWSIAMRole_disappears (6.76s)
--- PASS: TestAccAWSIAMRole_namePrefix (8.56s)
--- PASS: TestAccAWSIAMRole_basic (8.58s)
--- PASS: TestAccAWSIAMRole_importBasic (9.25s)
--- PASS: TestAccAWSIAMRole_force_detach_policies (9.71s)
--- PASS: TestAccAWSIAMRole_tags (13.51s)
--- PASS: TestAccAWSIAMRole_MaxSessionDuration (14.17s)
--- PASS: TestAccAWSIAMRole_testNameChange (16.32s)
--- PASS: TestAccAWSIAMRole_basicWithDescription (18.19s)
--- PASS: TestAccAWSIAMRole_PermissionsBoundary (30.59s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	30.636s

@ghost ghost removed the waiting-response Maintainers are waiting on response from community or contributor. label Nov 19, 2018
@bflad bflad added this to the v1.46.0 milestone Nov 19, 2018
bflad
bflad approved these changes Nov 19, 2018
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @kl4w 🚀

--- PASS: TestAccAWSIAMRole_badJSON (1.51s)
--- PASS: TestAccAWSIAMRole_disappears (5.63s)
--- PASS: TestAccAWSIAMRole_basic (7.21s)
--- PASS: TestAccAWSIAMRole_namePrefix (7.62s)
--- PASS: TestAccAWSIAMRole_importBasic (7.97s)
--- PASS: TestAccAWSIAMRole_tags (11.84s)
--- PASS: TestAccAWSIAMRole_MaxSessionDuration (12.66s)
--- PASS: TestAccAWSIAMRole_force_detach_policies (12.85s)
--- PASS: TestAccAWSIAMRole_basicWithDescription (15.98s)
--- PASS: TestAccAWSIAMRole_testNameChange (17.84s)
--- PASS: TestAccAWSIAMRole_PermissionsBoundary (24.90s)

website/docs/r/iam_role.html.markdown
@@ -31,6 +31,10 @@ resource "aws_iam_role" "test_role" {
]
}
EOF

tags {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Missing equals sign, I'll fix on merge. 👍

@bflad bflad merged commit 7f0c9b7 into hashicorp:master Nov 19, 2018
bflad added a commit that referenced this pull request Nov 19, 2018
@bflad
Update CHANGELOG for #6499
e1537e7
@kl4w kl4w deleted the iam-role-tags branch November 19, 2018 18:28
@bflad
Copy link
Contributor

bflad commented Nov 20, 2018

This has been released in version 1.46.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@mdlavin mdlavin mentioned this pull request Nov 21, 2018
Closed
@ghost
Copy link

ghost commented Apr 2, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/iam Issues and PRs that pertain to the iam service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v1.46.0
Development

Successfully merging this pull request may close these issues.
2 participants
@kl4w @bflad