Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: aws/aws-sdk-go@v1.15.78 #6513

Merged
merged 1 commit into from
Nov 19, 2018
Merged

deps: aws/aws-sdk-go@v1.15.78 #6513

merged 1 commit into from
Nov 19, 2018

Conversation

sunilkumarmohanty
Copy link
Contributor

Changes proposed in this pull request:

  • Updage aws-sdk-go to 1.15.78

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSAvailabilityZones'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSAvailabilityZones -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSAvailabilityZones_basic
=== PAUSE TestAccAWSAvailabilityZones_basic
=== RUN   TestAccAWSAvailabilityZones_stateFilter
=== PAUSE TestAccAWSAvailabilityZones_stateFilter
=== CONT  TestAccAWSAvailabilityZones_basic
=== CONT  TestAccAWSAvailabilityZones_stateFilter
--- PASS: TestAccAWSAvailabilityZones_basic (20.15s)
--- PASS: TestAccAWSAvailabilityZones_stateFilter (20.40s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       20.434s

@ghost ghost added size/XXL Managed by automation to categorize the size of a PR. dependencies Used to indicate dependency changes. labels Nov 18, 2018
@gazoakley gazoakley mentioned this pull request Nov 19, 2018
Closed
@bflad bflad added this to the v1.46.0 milestone Nov 19, 2018
@bflad bflad added the provider Pertains to the provider itself, rather than any interaction with AWS. label Nov 19, 2018
bflad
bflad approved these changes Nov 19, 2018
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @sunilkumarmohanty! 🚀

@bflad bflad merged commit d7ff7c7 into hashicorp:master Nov 19, 2018
@sunilkumarmohanty sunilkumarmohanty deleted the v-aws-sdk-go-v1.15.78 branch November 19, 2018 09:00
@mdlavin mdlavin mentioned this pull request Nov 21, 2018
Closed
@ghost
Copy link

ghost commented Apr 2, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees
No one assigned
Labels
dependencies Used to indicate dependency changes. provider Pertains to the provider itself, rather than any interaction with AWS. size/XXL Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v1.46.0
Development

Successfully merging this pull request may close these issues.
2 participants
@sunilkumarmohanty @bflad