Data source for aws_service_discovery_dns_namespace

[saravanan30erd]

Fixes #6384

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSServiceDiscoveryDnsNamespace_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 20 -run=TestAccAWSServiceDiscoveryDnsNamespace_basic -timeout 120m
=== RUN   TestAccAWSServiceDiscoveryDnsNamespace_basic
=== PAUSE TestAccAWSServiceDiscoveryDnsNamespace_basic
=== CONT  TestAccAWSServiceDiscoveryDnsNamespace_basic
--- PASS: TestAccAWSServiceDiscoveryDnsNamespace_basic (175.88s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws
...

[mbfrahry]

Hey @saravanan30erd! This looks great, I'd just swap to using constants for validation on the dns_type attribute

[saravanan30erd]

$ make testacc TEST=./aws TESTARGS='-run=TestAccDataSourceAWSServiceDiscoveryDnsNamespace_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 20 -run=TestAccDataSourceAWSServiceDiscoveryDnsNamespace_basic -timeout 120m
=== RUN TestAccDataSourceAWSServiceDiscoveryDnsNamespace_basic
=== PAUSE TestAccDataSourceAWSServiceDiscoveryDnsNamespace_basic
=== CONT TestAccDataSourceAWSServiceDiscoveryDnsNamespace_basic
--- PASS: TestAccDataSourceAWSServiceDiscoveryDnsNamespace_basic (168.80s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 168.848s

[borgstrom]

@mbfrahry -- Looks like this one is ready to go. Could you give it another review please? This data source will make my life so much easier! :)

[saravanan30erd]

@bflad Can we push this? anything I need to do from my end?

[deedoz]

Hello,
Good job !
I miss this datasource also, looking forward for the merge.

[charlyx]

Great work @saravanan30erd 👏(I believe there is now a button to request a new review).

Hi @mbfrahry 👋
Thanks for your review. It looks like the changes you've requested have been done.
Is there anything else blocking the merge of this PR? I'm really looking forward to using it 🙏

[imranjavaid]

When can we expect a merge of this?

[loivis]

@mbfrahry @bflad merge if conflicts can be resolved?

[completenovice]

Hello, what is the status of this, please? Is this still being developed on?

[teamterraform]

Notification of Recent and Upcoming Changes to Contributions

Thank you for this contribution! There have been a few recent development changes that affect this pull request. We apologize for the inconvenience, especially if there have been long review delays up until now. Please note that this is automated message from an unmonitored account. See the FAQ for additional information on the maintainer team and review prioritization.

If you are unable to complete these updates, please leave a comment for the community and maintainers so someone can potentially continue the work. The maintainers will encourage other contributors to use the existing contribution as the base for additional changes as appropriate. Otherwise, contributions that do not receive updated code or comments from the original contributor may be closed in the future so the maintainers can focus on active items.

For the most up to date information about Terraform AWS Provider development, see the Contributing Guide. Additional technical debt changes can be tracked with the technical-debt label on issues.

As part of updating a pull request with these changes, the most current unit testing and linting will run. These may report issues that were not previously reported.

Action Required: Terraform 0.12 Syntax

Reference: #8950
Reference: #14417

Version 3 and later of the Terraform AWS Provider, which all existing contributions would potentially be added, only supports Terraform 0.12 and later. Certain syntax elements of Terraform 0.11 and earlier show deprecation warnings during runs with Terraform 0.12. Documentation and test configurations, such as those including deprecated string interpolations (some_attribute = "${aws_service_thing.example.id}") should be updated to the newer syntax (some_attribute = aws_service_thing.example.id). Contribution testing will automatically fail on older syntax in the near future. Please see the referenced issues for additional information.

Action Required: Terraform Plugin SDK Version 2

Reference: #14551

The Terraform AWS Provider has been upgraded to the latest version of the Terraform Plugin SDK. Generally, most changes to contributions should only involve updating Go import paths in source code files. Please see the referenced issue for additional information.

Action Required: Removal of website/aws.erb File

Reference: #14712

Any changes to the website/aws.erb file are no longer necessary and should be removed from this contribution to prevent merge issues in the near future when the file is removed from the repository. Please see the referenced issue for additional information.

Upcoming Change of Git Branch Naming

Reference: #14292

Development environments will need their upstream Git branch updated from master to main in the near future. Please see the referenced issue for additional information and scheduling.

Upcoming Change of GitHub Organization

Reference: #14715

This repository will be migrating from https://github.com/terraform-providers/terraform-provider-aws to https://github.com/hashicorp/terraform-provider-aws. No practitioner or developer action is anticipated and most GitHub functionality will automatically redirect to the new location. Go import paths including terraform-providers can remain for now. Please see the referenced issue for additional information and scheduling.

[ewbankkit]

@saravanan30erd Thanks for the contribution and apologies for the delay in responding.
Are you able to address the changes mentioned in the comment above?

[saravanan30erd]

@ewbankkit sure, I will rename the attribute and update you.

[ewbankkit]

Related:

• Create a Data Source Provider for the "Service Discovery" Resources #14881

[saravanan30erd]

@ewbankkit I renamed the attr dns_type to type. Please check.

[dayglojesus]

Original submission on this was December 2018?? holy cow. Talk about contributor purgatory. I cannot believe the author stuck with it as long as they did. ping @ewbankkit

Is there no way for this to see daylight?

[saravanan30erd]

@anGie44 please check this PR

[anGie44]

Output of acceptance tests (Commercial):

--- PASS: TestAccAWSServiceDiscoveryDnsNamespaceDataSource_public (106.18s)
--- PASS: TestAccAWSServiceDiscoveryDnsNamespaceDataSource_private (114.47s)

Output of acceptance tests (Gov Cloud):

--- SKIP: TestAccAWSServiceDiscoveryDnsNamespaceDataSource_public (22.31s)
--- SKIP: TestAccAWSServiceDiscoveryDnsNamespaceDataSource_private (25.67s)

[anGie44]

Hi again @saravanan30erd , thank you for this PR! Overall looked great 👍 Major thing was getting the PR aligned with new conventions used in the provider as we've migrated over to the V2 of the terraform plugin SDK. Plan to get this into the upcoming release later this week.

[anGie44]

Output of acceptance tests:

--- PASS: TestAccAWSServiceDiscoveryPublicDnsNamespace_disappears (359.05s)
--- PASS: TestAccAWSServiceDiscoveryPublicDnsNamespace_basic (369.10s)
--- PASS: TestAccAWSServiceDiscoveryDnsNamespaceDataSource_public (400.97s)
--- PASS: TestAccAWSServiceDiscoveryHttpNamespace_disappears (401.87s)
--- PASS: TestAccAWSServiceDiscoveryPrivateDnsNamespace_error_Overlap (433.00s)
--- PASS: TestAccAWSServiceDiscoveryPublicDnsNamespace_Description (455.22s)
--- PASS: TestAccAWSServiceDiscoveryService_disappears (508.90s)
--- PASS: TestAccAWSServiceDiscoveryHttpNamespace_Description (509.43s)
--- PASS: TestAccAWSServiceDiscoveryDnsNamespaceDataSource_private (510.19s)
--- PASS: TestAccAWSServiceDiscoveryHttpNamespace_basic (510.77s)
--- PASS: TestAccAWSServiceDiscoveryPrivateDnsNamespace_disappears (511.99s)
--- PASS: TestAccAWSServiceDiscoveryService_http (557.40s)
--- PASS: TestAccAWSServiceDiscoveryPrivateDnsNamespace_Description (558.17s)
--- PASS: TestAccAWSServiceDiscoveryPublicDnsNamespace_Tags (601.90s)
--- PASS: TestAccAWSServiceDiscoveryPrivateDnsNamespace_basic (602.43s)
--- PASS: TestAccAWSServiceDiscoveryService_Tags (674.79s)
--- PASS: TestAccAWSServiceDiscoveryHttpNamespace_Tags (675.31s)
--- PASS: TestAccAWSServiceDiscoveryService_public (675.98s)
--- PASS: TestAccAWSServiceDiscoveryService_private (704.14s)
--- PASS: TestAccAWSServiceDiscoveryPrivateDnsNamespace_Tags (712.03s)

[dayglojesus]

huzzah!

[ghost]

This has been released in version 3.42.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[oscargarciajr]

Do we have documentation on how to use this?

data "aws_service_discovery_service" "controller" {
namespace = "namespace"
}

error: The provider hashicorp/aws does not support data source "aws_service_discovery_service"
aws 3.42..0

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.