Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

data-source/aws_cloudtrail_service_account: Support us-gov-east-1 and us-gov-west-1 regions #6893

Merged
merged 1 commit into from
Dec 18, 2018
Merged

data-source/aws_cloudtrail_service_account: Support us-gov-east-1 and us-gov-west-1 regions #6893

merged 1 commit into from
Dec 18, 2018

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Dec 18, 2018

Previously (AWS GovCloud (US)):

--- FAIL: TestAccAWSCloudTrailServiceAccount_basic (0.32s)
    testing.go:538: Step 0 error: Error refreshing: 1 error occurred:
        	* data.aws_cloudtrail_service_account.main: 1 error occurred:
        	* data.aws_cloudtrail_service_account.main: data.aws_cloudtrail_service_account.main: Unknown region ("us-gov-west-1")

Output from acceptance testing (AWS GovCloud (US)):

--- PASS: TestAccAWSCloudTrailServiceAccount_basic (11.42s)
--- PASS: TestAccAWSCloudTrailServiceAccount_Region (12.11s)

Output from acceptance testing (AWS Commercial):

--- PASS: TestAccAWSCloudTrailServiceAccount_basic (9.07s)
--- PASS: TestAccAWSCloudTrailServiceAccount_Region (9.07s)

@bflad
data-source/aws_cloudtrail_service_account: Support us-gov-east-1 and…
084c2f5 
… us-gov-west-1 regions

Output from acceptance testing (AWS Commercial):

```
--- PASS: TestAccAWSCloudTrailServiceAccount_basic (9.07s)
--- PASS: TestAccAWSCloudTrailServiceAccount_Region (9.07s)
```

Output from acceptance testing (AWS GovCloud (US)):

```
--- PASS: TestAccAWSCloudTrailServiceAccount_basic (11.42s)
--- PASS: TestAccAWSCloudTrailServiceAccount_Region (12.11s)
```
@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. service/cloudtrail Issues and PRs that pertain to the cloudtrail service. labels Dec 18, 2018
@ghost ghost added size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Dec 18, 2018
@bflad bflad requested a review from a team December 18, 2018 15:57
@bflad bflad added the partition/aws-us-gov Pertains to the aws-us-gov partition. label Dec 18, 2018
tracypholmes
tracypholmes approved these changes Dec 18, 2018
View reviewed changes
Copy link
Contributor

@tracypholmes tracypholmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍🏾

@bflad bflad added this to the v1.53.0 milestone Dec 18, 2018
@bflad bflad merged commit 7887937 into master Dec 18, 2018
@bflad bflad deleted the f-aws_cloudtrail_service_account-us-gov-regions branch December 18, 2018 17:40
bflad added a commit that referenced this pull request Dec 18, 2018
@bflad
Update CHANGELOG for #6893
920ac5b
@bflad
Copy link
Contributor Author

bflad commented Dec 20, 2018

This has been released in version 1.53.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 1, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tracypholmes tracypholmes tracypholmes approved these changes

Assignees
No one assigned
Labels
enhancement Requests to existing resources that expand the functionality or scope. partition/aws-us-gov Pertains to the aws-us-gov partition. service/cloudtrail Issues and PRs that pertain to the cloudtrail service. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v1.53.0
Development

Successfully merging this pull request may close these issues.
2 participants
@bflad @tracypholmes