Commits on Jan 11, 2019

1. service/servicediscovery: Return operation ErrorCode and ErrorMessage… …

   … when Status is FAIL
   
   Previously, the full error messaging from the API response was not present when an operation failed:
   
   ```
   aws_service_discovery_private_dns_namespace.subdomain: unexpected state 'FAIL', wanted target 'SUCCESS'. last error: %!s(<nil>)
   ```
   
   This change returns the ErrorCode and ErrorMessage fields from the API response:
   
   ```
   aws_service_discovery_private_dns_namespace.subdomain: CANNOT_CREATE_HOSTED_ZONE: The VPC that you chose, vpc-0c04acdb2f40a49d6 in region us-west-2, is already associated with another private hosted zone that has an overlapping name space, wavsx.example.com.. (Service: AmazonRoute53; Status Code: 400; Error Code: ConflictingDomainExists; Request ID: 600b3096-15c4-11e9-97af-ade1478492a8)
   ```
   
   Output from acceptance testing:
   
   ```
   --- PASS: TestAccAWSServiceDiscoveryHttpNamespace_basic (96.16s)
   --- PASS: TestAccAWSServiceDiscoveryPrivateDnsNamespace_longname (105.49s)
   --- PASS: TestAccAWSServiceDiscoveryPublicDnsNamespace_basic (105.77s)
   --- PASS: TestAccAWSServiceDiscoveryHttpNamespace_Description (105.87s)
   --- PASS: TestAccAWSServiceDiscoveryPublicDnsNamespace_longname (105.92s)
   --- PASS: TestAccAWSServiceDiscoveryService_import (108.32s)
   --- PASS: TestAccAWSServiceDiscoveryPrivateDnsNamespace_basic (116.13s)
   --- PASS: TestAccAWSServiceDiscoveryService_private (122.87s)
   --- PASS: TestAccAWSServiceDiscoveryService_public (133.85s)
   --- PASS: TestAccAWSServiceDiscoveryPrivateDnsNamespace_error_Overlap (188.37s)
   ```

   

   bflad committed Jan 11, 2019
   Configuration menu

   • View commit details
   • Copy full SHA for 2a938f0
   • Browse repository at this point

   Copy the full SHA

   2a938f0 View commit details

   Browse the repository at this point in the history