r/aws_ssm_maintenance_window_task: Fix name/desc validation

[YakDriver]

Fixes #6715

Changes proposed in this pull request:

• r/aws_ssm_maintenance_window_task: Allow name and description arguments to be optional and not fail validation. Test with and without name and description arguments.

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSSSMMaintenanceWindowTask_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSSSMMaintenanceWindowTask_ -timeout 120m
?   	github.com/terraform-providers/terraform-provider-aws	[no test files]
=== RUN   TestAccAWSSSMMaintenanceWindowTask_basic
=== PAUSE TestAccAWSSSMMaintenanceWindowTask_basic
=== RUN   TestAccAWSSSMMaintenanceWindowTask_updateForcesNewResource
=== PAUSE TestAccAWSSSMMaintenanceWindowTask_updateForcesNewResource
=== CONT  TestAccAWSSSMMaintenanceWindowTask_basic
=== CONT  TestAccAWSSSMMaintenanceWindowTask_updateForcesNewResource
--- PASS: TestAccAWSSSMMaintenanceWindowTask_basic (137.73s)
--- PASS: TestAccAWSSSMMaintenanceWindowTask_updateForcesNewResource (167.05s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	167.123s

[Dkochkerian]

Hi Guys, which provider version is this bug fixed in

[YakDriver]

None, yet.

[YakDriver]

According to the AWS docs:

• name can be 3, 128 chars and appears properly validated with regex
• description should be 1, 128 (not 3, 128, as fixed in this PR)

[bflad]

LGTM, thanks so much for this fix @YakDriver 🚀

Previous output from updated acceptance testing:

--- FAIL: TestAccAWSSSMMaintenanceWindowTask_basic (158.62s)
    testing.go:538: Step 0 error: Error applying: 1 error occurred:
        	* aws_ssm_maintenance_window_task.target: 1 error occurred:
        	* aws_ssm_maintenance_window_task.target: InvalidParameter: 2 validation error(s) found.
        - minimum field size of 1, RegisterTaskWithMaintenanceWindowInput.Description.
        - minimum field size of 3, RegisterTaskWithMaintenanceWindowInput.Name.





--- FAIL: TestAccAWSSSMMaintenanceWindowTask_updateForcesNewResource (231.62s)
    testing.go:538: Step 0 error: Error applying: 1 error occurred:
        	* aws_ssm_maintenance_window_task.target: 1 error occurred:
        	* aws_ssm_maintenance_window_task.target: InvalidParameter: 2 validation error(s) found.
        - minimum field size of 1, RegisterTaskWithMaintenanceWindowInput.Description.
        - minimum field size of 3, RegisterTaskWithMaintenanceWindowInput.Name.

Output from acceptance testing with updated code:

--- PASS: TestAccAWSSSMMaintenanceWindowTask_updateForcesNewResource (155.51s)
--- PASS: TestAccAWSSSMMaintenanceWindowTask_basic (228.65s)

[bflad]

This has been released in version 1.59.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

[Dkochkerian]

Looks like this issue is back.

Just checked on my end, works with aws provider 2.11.0, but breaks starting 2.12.0.
Please verify and fix.

[AndrewCi]

Any fix upcoming for issue #4408 ?

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!