Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for AutoScaling Scaling Policy Import #7195

Conversation

teraken0509
Copy link
Contributor

Fixes #6578

Changes proposed in this pull request:

  • Add import support for aws_autoscaling_policy

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSAutoscalingPolicy_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 20 -run=TestAccAWSAutoscalingPolicy_basic -timeout 120m
=== RUN   TestAccAWSAutoscalingPolicy_basic
=== PAUSE TestAccAWSAutoscalingPolicy_basic
=== CONT  TestAccAWSAutoscalingPolicy_basic
--- PASS: TestAccAWSAutoscalingPolicy_basic (95.48s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	95.539s

@ghost ghost added size/S Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/autoscaling Issues and PRs that pertain to the autoscaling service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jan 18, 2019
@bflad bflad added the enhancement Requests to existing resources that expand the functionality or scope. label Jan 25, 2019
@bflad
Copy link
Contributor

bflad commented Jan 25, 2019

FYI this was good but when expanding the acceptance testing to run ImportState steps for the rest of the test resources, I found that step_adjustment was failing to properly be read into the Terraform state and submitted this followup: #7336

@bflad bflad merged commit 46f4549 into hashicorp:master Jan 25, 2019
@bflad bflad added this to the v1.57.0 milestone Jan 25, 2019
bflad added a commit that referenced this pull request Jan 25, 2019
@bflad
Copy link
Contributor

bflad commented Jan 26, 2019

This has been released in version 1.57.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@teraken0509 teraken0509 deleted the feature/add-support-autoscaling-policy-import branch March 5, 2020 14:02
@ghost
Copy link

ghost commented Mar 5, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/autoscaling Issues and PRs that pertain to the autoscaling service. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for importing aws_autoscaling_policy
2 participants