Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/aws_ses_domain_mail_from: Prevent crash with deleted SES Domain Identity #7883

Merged
merged 1 commit into from
Mar 14, 2019

Commits on Mar 10, 2019

  1. resource/aws_ses_domain_mail_from: Prevent crash with deleted SES Dom…

    …ain Identity
    
    Reference: #7862
    
    Output from acceptance testing before code update:
    
    ```
    === CONT  TestAccAWSSESDomainMailFrom_disappears_Identity
    panic: runtime error: invalid memory address or nil pointer dereference
    [signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x3e051ac]
    
    goroutine 415 [running]:
    github.com/terraform-providers/terraform-provider-aws/aws.resourceAwsSesDomainMailFromRead(0xc0009825b0, 0x4a444a0, 0xc0004cec00, 0xc0009825b0, 0x0)
    	/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_ses_domain_mail_from.go:87 +0x37c
    ```
    
    Output from acceptance testing:
    
    ```
    --- PASS: TestAccAWSSESDomainIdentity_disappears (9.03s)
    --- PASS: TestAccAWSSESDomainMailFrom_disappears_Identity (10.38s)
    --- PASS: TestAccAWSSESDomainMailFrom_disappears (13.55s)
    --- PASS: TestAccAWSSESDomainMailFrom_behaviorOnMxFailure (21.04s)
    --- PASS: TestAccAWSSESDomainMailFrom_basic (21.11s)
    ```
    bflad committed Mar 10, 2019
    Configuration menu
    Copy the full SHA
    fb35537 View commit details
    Browse the repository at this point in the history