-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests/resource/aws_ec2_client_vpn_endpoint: Add sweeper #8155
Conversation
Previous output from acceptance testing: ``` --- FAIL: TestAccAwsEc2ClientVpnEndpoint_basic (5.71s) testing.go:538: Step 0 error: Error applying: 1 error occurred: * aws_ec2_client_vpn_endpoint.test: 1 error occurred: * aws_ec2_client_vpn_endpoint.test: Error creating Client VPN endpoint: ClientVpnEndpointLimitExceeded: Limit exceeded ``` Previously output from AWS CLI: ```console $ aws ec2 describe-client-vpn-endpoints | jq '.ClientVpnEndpoints | length' 5 ``` Output from sweeper: ```console $ go test ./aws -v -sweep=us-west-2 -sweep-run=aws_ec2_client_vpn_endpoint -timeout 10h ... 2019/04/02 12:46:28 [INFO] Deleting Client VPN Endpoint: cvpn-endpoint-073bf6cb2791e2d37 2019/04/02 12:46:28 [INFO] Deleting Client VPN Endpoint: cvpn-endpoint-056499587fe3f59c6 2019/04/02 12:46:29 [INFO] Deleting Client VPN Endpoint: cvpn-endpoint-0e92f7d99d531d5ae 2019/04/02 12:46:31 [INFO] Deleting Client VPN Endpoint: cvpn-endpoint-0b4741c9520d69d36 2019/04/02 12:46:31 [INFO] Deleting Client VPN Endpoint: cvpn-endpoint-0c5fadd250f9ca007 2019/04/02 12:46:32 Sweeper Tests ran: - aws_ec2_client_vpn_endpoint - aws_directory_service_directory ok github.com/terraform-providers/terraform-provider-aws/aws 9.578s ``` Output from AWS CLI: ```console $ aws ec2 describe-client-vpn-endpoints | jq '.ClientVpnEndpoints | length' 0 ```
@@ -94,7 +155,7 @@ func TestAccAwsEc2ClientVpnEndpoint_withLogGroup(t *testing.T) { | |||
}) | |||
} | |||
|
|||
func TestAccAwsEc2ClientVpnEndpoint_withDNSServers(t *testing.T) { | |||
func TestAccAwsEc2ClientVpnEndpoint_withDNervers(t *testing.T) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this rename intentional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😅 Great catch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left one question on what looks to be an accidental rename, otherwise this looks good!
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
Community Note
Previous output from acceptance testing:
Previously output from AWS CLI:
Output from sweeper:
Output from AWS CLI: