service/ec2: Automatically retry EC2 CreateVpnConnection and CreateVpnGateway requests for concurrency errors #8161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nGateway requests for concurrency errors
Previous output from acceptance testing:
```
--- FAIL: TestAccAWSVpnGateway_basic (5.90s)
testing.go:538: Step 0 error: Error applying: 1 error occurred:
* aws_vpn_gateway.foo: 1 error occurred:
* aws_vpn_gateway.foo: Error creating VPN gateway: VpnGatewayLimitExceeded: The maximum number of mutating objects has been reached.
--- FAIL: TestAccAWSVpnGateway_importBasic (6.14s)
testing.go:538: Step 0 error: Error applying: 1 error occurred:
* aws_vpn_gateway.foo: 1 error occurred:
* aws_vpn_gateway.foo: Error creating VPN gateway: VpnGatewayLimitExceeded: The maximum number of mutating objects has been reached.
--- FAIL: TestAccAWSVpnGateway_tags (5.29s)
testing.go:538: Step 0 error: Error applying: 1 error occurred:
* aws_vpn_gateway.foo: 1 error occurred:
* aws_vpn_gateway.foo: Error creating VPN gateway: VpnGatewayLimitExceeded: The maximum number of mutating objects has been reached.
--- FAIL: TestAccAWSVpnGatewayAttachment_deleted (6.00s)
testing.go:538: Step 0 error: Error applying: 1 error occurred:
* aws_vpn_gateway.test: 1 error occurred:
* aws_vpn_gateway.test: Error creating VPN gateway: VpnGatewayLimitExceeded: The maximum number of mutating objects has been reached.
--- FAIL: TestAccAWSVPNGatewayRoutePropagation_basic (6.64s)
testing.go:538: Step 0 error: Error applying: 1 error occurred:
* aws_vpn_gateway.foo: 1 error occurred:
* aws_vpn_gateway.foo: Error creating VPN gateway: VpnGatewayLimitExceeded: The maximum number of mutating objects has been reached.
--- FAIL: TestAccAWSVpnConnection_basic (14.67s)
testing.go:538: Step 0 error: Error applying: 1 error occurred:
* aws_vpn_connection.foo: 1 error occurred:
* aws_vpn_connection.foo: Error creating vpn connection: VpnConnectionLimitExceeded: The maximum number of mutating objects has been reached.
--- FAIL: TestAccAWSVpnConnection_disappears (14.49s)
testing.go:538: Step 0 error: Error applying: 1 error occurred:
* aws_vpn_gateway.vpn_gateway: 1 error occurred:
* aws_vpn_gateway.vpn_gateway: Error creating VPN gateway: VpnGatewayLimitExceeded: The maximum number of mutating objects has been reached.
--- FAIL: TestAccAWSVpnConnection_tunnelOptions (15.47s)
testing.go:538: Step 14 error: Error applying: 1 error occurred:
* aws_vpn_connection.foo: 1 error occurred:
* aws_vpn_connection.foo: Error creating vpn connection: VpnConnectionLimitExceeded: The maximum number of mutating objects has been reached.
--- FAIL: TestAccAWSVpnConnection_withoutStaticRoutes (14.51s)
testing.go:538: Step 0 error: Error applying: 1 error occurred:
* aws_vpn_connection.foo: 1 error occurred:
* aws_vpn_connection.foo: Error creating vpn connection: VpnConnectionLimitExceeded: The maximum number of mutating objects has been reached.
```
With this new handling added, we can see successful retrying of the requests after this error in the debug logging, e.g.
```
2019/04/02 16:53:39 [DEBUG] [aws-sdk-go] DEBUG: Retrying Request ec2/CreateVpnGateway, attempt 1
```
Output from acceptance testing:
```
# Concurrently
--- PASS: TestAccAWSVpnGateway_disappears (70.16s)
--- PASS: TestAccAWSVpnGatewayAttachment_basic (71.99s)
--- PASS: TestAccAWSVpnGatewayAttachment_deleted (82.35s)
--- PASS: TestAccAWSVpnGateway_delete (88.05s)
--- PASS: TestAccAWSVpnGateway_importBasic (88.90s)
--- PASS: TestAccAWSVPNGatewayRoutePropagation_basic (90.45s)
--- PASS: TestAccAWSVpnGateway_tags (94.23s)
--- PASS: TestAccAWSVpnGateway_withAmazonSideAsnSetToState (111.57s)
--- PASS: TestAccAWSVpnGateway_withAvailabilityZoneSetToState (111.61s)
--- PASS: TestAccAWSVpnGateway_basic (149.61s)
--- PASS: TestAccAWSVpnGateway_reattach (177.15s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 178.133s
# Concurrently
--- PASS: TestAccAWSVpnConnection_withoutStaticRoutes (192.33s)
--- PASS: TestAccAWSVpnConnection_importBasic (212.25s)
--- PASS: TestAccAWSVpnConnectionRoute_basic (254.94s)
--- PASS: TestAccAWSVpnConnection_disappears (279.78s)
--- PASS: TestAccAWSVpnConnection_basic (504.96s)
--- PASS: TestAccAWSVpnConnection_TransitGatewayID (575.86s)
--- PASS: TestAccAWSVpnConnection_tunnelOptions (582.15s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 583.190s
```
bflad
added
enhancement
ghost
added
size/XS
|
This has been released in version 2.5.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Previous output from acceptance testing:
With this new handling added, we can see successful retrying of the requests after this error in the debug logging, e.g.
Output from acceptance testing: