Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a mention on how Terraform handles existing EBS attachments #8202

Closed
wants to merge 1 commit into from

Conversation

danielelisi
Copy link

I used to edit my tfstate file manually to import aws_volume_attachment. Then I found hashicorp/terraform#11060 which changed Terraform behaviour when an EBS volume is already attached to an instance.

I thought would be a good idea to mention it in the docs.

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Changes proposed in this pull request:

  • Add mention on how Terraform handles existing EBS attachments

I used to edit my `tfstate` file manually to import `aws_volume_attachment`. Then I found hashicorp/terraform#11060 which changed Terraform behaviour when an EBS volume is already attached to an instance.

I thought would be a good idea to mention it in the docs.
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. labels Apr 4, 2019
@aeschright aeschright requested a review from a team June 26, 2019 16:50
@d2iq-shadowbq
Copy link

This helped me even as a pending PR. wink You might want to add that it's referenced as a vai-#########.

@bflad
Copy link
Contributor

bflad commented Jun 29, 2020

Hi @danielelisi 👋 Thank you for submitting this and apologies for the delayed review. It appears that import support is available on more recent versions of the Terraform AWS Provider: https://www.terraform.io/docs/providers/aws/r/volume_attachment.html#import

Given that aws_volume_attachment resource import is now possible, I'm going to close this since it no longer applies. Thanks again for the contribution though.

@bflad bflad closed this Jun 29, 2020
@ghost
Copy link

ghost commented Jul 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Jul 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants