Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/aws_emr_cluster: Add master_instance_group and core_instance_group configuration blocks, deprecate other instance group configuration methods #8459

Merged
merged 3 commits into from
May 13, 2019
Merged

resource/aws_emr_cluster: Add master_instance_group and core_instance_group configuration blocks, deprecate other instance group configuration methods #8459

merged 3 commits into from
May 13, 2019

Commits on Apr 26, 2019

  1. resource/aws_emr_cluster: Add master_instance_group and core_instance… 

    …_group configuration blocks, deprecate other instance group configuration methods

Reference: #8245

Output from acceptance testing:

```
--- PASS: TestAccAWSEMRCluster_CoreInstanceGroup_AutoscalingPolicy (487.78s)
--- PASS: TestAccAWSEMRCluster_CoreInstanceGroup_BidPrice (1006.42s)
--- PASS: TestAccAWSEMRCluster_CoreInstanceGroup_InstanceCount (1004.90s)
--- PASS: TestAccAWSEMRCluster_CoreInstanceGroup_InstanceType (869.47s)
--- PASS: TestAccAWSEMRCluster_CoreInstanceGroup_Migration_CoreInstanceType (415.45s)
--- PASS: TestAccAWSEMRCluster_CoreInstanceGroup_Migration_InstanceGroup (485.50s)
--- PASS: TestAccAWSEMRCluster_CoreInstanceGroup_Name (769.30s)
--- PASS: TestAccAWSEMRCluster_MasterInstanceGroup_BidPrice (849.98s)
--- PASS: TestAccAWSEMRCluster_MasterInstanceGroup_InstanceType (756.42s)
--- PASS: TestAccAWSEMRCluster_MasterInstanceGroup_Migration_InstanceGroup (414.36s)
--- PASS: TestAccAWSEMRCluster_MasterInstanceGroup_Migration_MasterInstanceType (423.02s)
--- PASS: TestAccAWSEMRCluster_MasterInstanceGroup_Name (735.58s)
```
    @bflad
    bflad committed Apr 26, 2019
    Configuration menu
    Copy the full SHA
    c2ce886 View commit details
    Browse the repository at this point in the history

Commits on May 13, 2019

  1. Apply suggestions from code review 

    Co-Authored-By: Wilken Rivera <dev@wilkenrivera.com>
    @bflad @nywilken
    bflad and nywilken authored May 13, 2019
    Configuration menu
    Copy the full SHA
    4e00927 View commit details
    Browse the repository at this point in the history

  2. tests/resource/aws_emr_cluster: Switch testAccAWSEmrClusterConfig_Sec… 

    …urityConfiguration to index notation

Reference: https://github.com/terraform-providers/terraform-provider-aws/pull/8459/files#r282175062

Output from acceptance testing:

```
--- PASS: TestAccAWSEMRCluster_security_config (404.88s)
```
    @bflad
    bflad committed May 13, 2019
    Configuration menu
    Copy the full SHA
    66faff8 View commit details
    Browse the repository at this point in the history