Add support for tags for sns topic

[sunilkumarmohanty]

Fixes #8460

Changes proposed in this pull request:

• Support for tags added for sns topic

Output from acceptance testing:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSSNSTopic_tags'

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -parallel 20 -run=TestAccAWSSNSTopic_tags -timeout 120m
=== RUN   TestAccAWSSNSTopic_tags
=== PAUSE TestAccAWSSNSTopic_tags
=== CONT  TestAccAWSSNSTopic_tags
--- PASS: TestAccAWSSNSTopic_tags (69.07s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       69.110s

[bflad]

Looks good, thanks, @sunilkumarmohanty! 🚀

Output from acceptance testing (AWS Standard):

--- PASS: TestAccAWSSNSTopic_namePrefix (13.31s)
--- PASS: TestAccAWSSNSTopic_name (13.43s)
--- PASS: TestAccAWSSNSTopic_basic (13.43s)
--- PASS: TestAccAWSSNSTopic_policy (14.15s)
--- PASS: TestAccAWSSNSTopic_withDeliveryPolicy (14.24s)
--- PASS: TestAccAWSSNSTopic_importBasic (14.45s)
--- PASS: TestAccAWSSNSTopic_encryption (21.29s)
--- PASS: TestAccAWSSNSTopic_withIAMRole (23.82s)
--- PASS: TestAccAWSSNSTopic_tags (31.08s)
--- PASS: TestAccAWSSNSTopic_deliveryStatus (34.24s)
--- PASS: TestAccAWSSNSTopic_withFakeIAMRole (130.75s)

Output from acceptance testing (AWS GovCloud (US)) (test failure unrelated):

--- PASS: TestAccAWSSNSTopic_namePrefix (17.66s)
--- PASS: TestAccAWSSNSTopic_basic (17.94s)
--- PASS: TestAccAWSSNSTopic_name (18.01s)
--- PASS: TestAccAWSSNSTopic_policy (18.56s)
--- PASS: TestAccAWSSNSTopic_withDeliveryPolicy (18.67s)
--- PASS: TestAccAWSSNSTopic_importBasic (19.54s)
--- PASS: TestAccAWSSNSTopic_encryption (30.82s)
--- PASS: TestAccAWSSNSTopic_withIAMRole (31.66s)
--- PASS: TestAccAWSSNSTopic_tags (42.24s)
--- PASS: TestAccAWSSNSTopic_withFakeIAMRole (133.78s)
--- FAIL: TestAccAWSSNSTopic_deliveryStatus (136.70s)
    testing.go:568: Step 0 error: errors during apply:

        Error: InvalidParameter: Invalid parameter: AttributeName Reason: HTTPSuccessFeedbackRoleArn is not a supported AttributeName

[bflad]

This has been released in version 2.11.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!