Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

service/appsync: Various minor fixes #8675

Merged
merged 3 commits into from
May 24, 2019
Merged

service/appsync: Various minor fixes #8675

merged 3 commits into from
May 24, 2019

Conversation

bflad
Copy link
Contributor

@bflad bflad commented May 17, 2019

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Release note for CHANGELOG:

NONE

Sorry for the "various" part here, but while adding the PreCheck function noticed these other minor items. There are three commits for easier review!

  • resource/aws_appsync_graphql_api: Adjust error messaging for context and proper formatter typing (006cbfe)

Previously error messages during creation would use an incorrect format verb which was harder to read:

--- FAIL: TestAccAWSAppsyncGraphqlApi_basic (0.50s)
    testing.go:568: Step 0 error: errors during apply:

        Error: error creating AppSync GraphQL API: &{%!d(string=RequestError) %!d(string=send request failed) [824649821952]}

Now error messages are properly formatted and consistently applied across Create/Read/Update/Delete functions.

--- FAIL: TestAccAWSAppsyncGraphqlApi_basic (6.36s)
    testing.go:568: Step 0 error: errors during apply:

        Error: error creating AppSync GraphQL API: RequestError: send request failed
        caused by: Post https://appsync.us-gov-west-1.amazonaws.com/v1/apis: dial tcp: lookup appsync.us-gov-west-1.amazonaws.com: no such host

Output from acceptance testing:

--- PASS: TestAccAWSAppsyncGraphqlApi_disappears (12.98s)
--- PASS: TestAccAWSAppsyncGraphqlApi_AuthenticationType_AWSIAM (13.22s)
--- PASS: TestAccAWSAppsyncGraphqlApi_AuthenticationType_APIKey (13.49s)
--- PASS: TestAccAWSAppsyncGraphqlApi_basic (13.94s)
--- PASS: TestAccAWSAppsyncGraphqlApi_LogConfig (15.25s)
--- PASS: TestAccAWSAppsyncGraphqlApi_AuthenticationType_OpenIDConnect (15.56s)
--- PASS: TestAccAWSAppsyncGraphqlApi_AuthenticationType_AmazonCognitoUserPools (15.93s)
--- PASS: TestAccAWSAppsyncGraphqlApi_OpenIDConnectConfig_Issuer (19.66s)
--- PASS: TestAccAWSAppsyncGraphqlApi_OpenIDConnectConfig_ClientID (19.78s)
--- PASS: TestAccAWSAppsyncGraphqlApi_AuthenticationType (19.99s)
--- PASS: TestAccAWSAppsyncGraphqlApi_OpenIDConnectConfig_AuthTTL (21.15s)
--- PASS: TestAccAWSAppsyncGraphqlApi_UserPoolConfig_DefaultAction (22.64s)
--- PASS: TestAccAWSAppsyncGraphqlApi_UserPoolConfig_AwsRegion (22.64s)
--- PASS: TestAccAWSAppsyncGraphqlApi_LogConfig_FieldLogLevel (27.56s)
--- PASS: TestAccAWSAppsyncGraphqlApi_OpenIDConnectConfig_IatTTL (29.54s)
--- PASS: TestAccAWSAppsyncGraphqlApi_Name (29.79s)
--- PASS: TestAccAWSAppsyncGraphqlApi_Schema (29.99s)
--- PASS: TestAccAWSAppsyncGraphqlApi_Tags (30.21s)
  • tests/service/appsync: Add PreCheck for service availability (b9b193d)

Previously in AWS GovCloud (US) acceptance testing:

--- FAIL: TestAccAWSAppsyncGraphqlApi_basic (6.36s)
    testing.go:568: Step 0 error: errors during apply:

        Error: error creating AppSync GraphQL API: RequestError: send request failed
        caused by: Post https://appsync.us-gov-west-1.amazonaws.com/v1/apis: dial tcp: lookup appsync.us-gov-west-1.amazonaws.com: no such host

Output from AWS Standard acceptance testing:

--- PASS: TestAccAWSAppsyncGraphqlApi_disappears (11.00s)
--- PASS: TestAccAWSAppsyncGraphqlApi_AuthenticationType_APIKey (12.86s)
--- PASS: TestAccAwsAppsyncDatasource_Type_HTTP (14.70s)
--- PASS: TestAccAWSAppsyncApiKey_basic (15.89s)
--- PASS: TestAccAWSAppsyncGraphqlApi_OpenIDConnectConfig_AuthTTL (19.99s)
--- PASS: TestAccAwsAppsyncDatasource_Type (20.55s)
--- PASS: TestAccAWSAppsyncGraphqlApi_basic (23.15s)
--- PASS: TestAccAWSAppsyncGraphqlApi_AuthenticationType (23.45s)
--- PASS: TestAccAWSAppsyncGraphqlApi_AuthenticationType_OpenIDConnect (10.83s)
--- PASS: TestAccAwsAppsyncDatasource_Type_None (24.06s)
--- PASS: TestAccAWSAppsyncGraphqlApi_LogConfig (13.60s)
--- PASS: TestAccAWSAppsyncGraphqlApi_AuthenticationType_AWSIAM (24.69s)
--- FAIL: TestAccAwsAppsyncDatasource_Type_Lambda (25.53s)
    testing.go:568: Step 0 error: errors during apply:

        Error: Error creating Lambda function: InvalidParameterValueException: The runtime parameter of nodejs6.10 is no longer supported for creating or updating AWS Lambda functions. We recommend you use the new runtime (nodejs8.10) while creating or updating functions.
        	status code: 400, request id: 2ad8fdcd-78dd-11e9-82e1-0b28c3b9519b

          on /var/folders/v0/_d108fkx1pbbg4_sh864_7740000gn/T/tf-test220210354/main.tf line 21:
          (source code not available)

--- PASS: TestAccAWSAppsyncGraphqlApi_OpenIDConnectConfig_Issuer (27.02s)
--- PASS: TestAccAWSAppsyncGraphqlApi_OpenIDConnectConfig_IatTTL (28.93s)
--- PASS: TestAccAWSAppsyncGraphqlApi_UserPoolConfig_AwsRegion (29.85s)
--- PASS: TestAccAWSAppsyncGraphqlApi_Schema (30.41s)
--- PASS: TestAccAwsAppsyncDatasource_Type_DynamoDB (30.73s)
--- PASS: TestAccAWSAppsyncGraphqlApi_AuthenticationType_AmazonCognitoUserPools (16.64s)
--- PASS: TestAccAWSAppsyncGraphqlApi_Name (31.69s)
--- PASS: TestAccAWSAppsyncGraphqlApi_OpenIDConnectConfig_ClientID (31.98s)
--- PASS: TestAccAWSAppsyncGraphqlApi_LogConfig_FieldLogLevel (32.35s)
--- PASS: TestAccAwsAppsyncResolver_disappears (17.48s)
--- PASS: TestAccAwsAppsyncResolver_basic (18.71s)
--- PASS: TestAccAwsAppsyncDatasource_basic (14.51s)
--- PASS: TestAccAWSAppsyncGraphqlApi_Tags (19.65s)
--- PASS: TestAccAwsAppsyncDatasource_HTTPConfig_Endpoint (20.76s)
--- PASS: TestAccAWSAppsyncGraphqlApi_UserPoolConfig_DefaultAction (21.72s)
--- PASS: TestAccAWSAppsyncApiKey_Expires (18.96s)
--- PASS: TestAccAwsAppsyncDatasource_Description (20.44s)
--- PASS: TestAccAWSAppsyncApiKey_Description (18.41s)
--- PASS: TestAccAwsAppsyncResolver_ResponseTemplate (23.14s)
--- PASS: TestAccAwsAppsyncResolver_DataSource (22.28s)
--- PASS: TestAccAwsAppsyncResolver_RequestTemplate (26.09s)
--- PASS: TestAccAwsAppsyncResolver_multipleResolvers (47.98s)
--- PASS: TestAccAwsAppsyncDatasource_DynamoDBConfig_UseCallerCredentials (122.51s)
--- PASS: TestAccAwsAppsyncDatasource_DynamoDBConfig_Region (124.23s)
--- PASS: TestAccAwsAppsyncDatasource_ElasticsearchConfig_Region (551.20s)
--- PASS: TestAccAwsAppsyncDatasource_Type_Elasticsearch (648.43s)

Output from AWS GovCloud (US) acceptance testing:

--- SKIP: TestAccAwsAppsyncDatasource_Type_Elasticsearch (2.55s)
    resource_aws_appsync_graphql_api_test.go:790: skipping acceptance testing: RequestError: send request failed
        caused by: Get https://appsync.us-gov-west-1.amazonaws.com/v1/apis: dial tcp: lookup appsync.us-gov-west-1.amazonaws.com: no such host
--- SKIP: TestAccAWSAppsyncGraphqlApi_AuthenticationType (2.55s)
    resource_aws_appsync_graphql_api_test.go:790: skipping acceptance testing: RequestError: send request failed
        caused by: Get https://appsync.us-gov-west-1.amazonaws.com/v1/apis: dial tcp: lookup appsync.us-gov-west-1.amazonaws.com: no such host
--- SKIP: TestAccAwsAppsyncDatasource_Type_HTTP (2.55s)
    resource_aws_appsync_graphql_api_test.go:790: skipping acceptance testing: RequestError: send request failed
        caused by: Get https://appsync.us-gov-west-1.amazonaws.com/v1/apis: dial tcp: lookup appsync.us-gov-west-1.amazonaws.com: no such host
--- SKIP: TestAccAwsAppsyncDatasource_Type_DynamoDB (2.55s)
    resource_aws_appsync_graphql_api_test.go:790: skipping acceptance testing: RequestError: send request failed
        caused by: Get https://appsync.us-gov-west-1.amazonaws.com/v1/apis: dial tcp: lookup appsync.us-gov-west-1.amazonaws.com: no such host
--- SKIP: TestAccAwsAppsyncDatasource_Type_None (2.55s)
    resource_aws_appsync_graphql_api_test.go:790: skipping acceptance testing: RequestError: send request failed
        caused by: Get https://appsync.us-gov-west-1.amazonaws.com/v1/apis: dial tcp: lookup appsync.us-gov-west-1.amazonaws.com: no such host
--- SKIP: TestAccAwsAppsyncDatasource_ElasticsearchConfig_Region (2.55s)
    resource_aws_appsync_graphql_api_test.go:790: skipping acceptance testing: RequestError: send request failed
        caused by: Get https://appsync.us-gov-west-1.amazonaws.com/v1/apis: dial tcp: lookup appsync.us-gov-west-1.amazonaws.com: no such host
--- SKIP: TestAccAWSAppsyncGraphqlApi_basic (2.55s)
    resource_aws_appsync_graphql_api_test.go:790: skipping acceptance testing: RequestError: send request failed
        caused by: Get https://appsync.us-gov-west-1.amazonaws.com/v1/apis: dial tcp: lookup appsync.us-gov-west-1.amazonaws.com: no such host
--- SKIP: TestAccAWSAppsyncApiKey_basic (2.55s)
    resource_aws_appsync_graphql_api_test.go:790: skipping acceptance testing: RequestError: send request failed
        caused by: Get https://appsync.us-gov-west-1.amazonaws.com/v1/apis: dial tcp: lookup appsync.us-gov-west-1.amazonaws.com: no such host
--- SKIP: TestAccAWSAppsyncGraphqlApi_AuthenticationType_AWSIAM (2.55s)
    resource_aws_appsync_graphql_api_test.go:790: skipping acceptance testing: RequestError: send request failed
        caused by: Get https://appsync.us-gov-west-1.amazonaws.com/v1/apis: dial tcp: lookup appsync.us-gov-west-1.amazonaws.com: no such host
--- SKIP: TestAccAWSAppsyncApiKey_Expires (2.55s)
    resource_aws_appsync_graphql_api_test.go:790: skipping acceptance testing: RequestError: send request failed
        caused by: Get https://appsync.us-gov-west-1.amazonaws.com/v1/apis: dial tcp: lookup appsync.us-gov-west-1.amazonaws.com: no such host
--- SKIP: TestAccAwsAppsyncDatasource_Type_Lambda (2.55s)
    resource_aws_appsync_graphql_api_test.go:790: skipping acceptance testing: RequestError: send request failed
        caused by: Get https://appsync.us-gov-west-1.amazonaws.com/v1/apis: dial tcp: lookup appsync.us-gov-west-1.amazonaws.com: no such host
--- SKIP: TestAccAwsAppsyncDatasource_HTTPConfig_Endpoint (2.55s)
    resource_aws_appsync_graphql_api_test.go:790: skipping acceptance testing: RequestError: send request failed
        caused by: Get https://appsync.us-gov-west-1.amazonaws.com/v1/apis: dial tcp: lookup appsync.us-gov-west-1.amazonaws.com: no such host
--- SKIP: TestAccAWSAppsyncGraphqlApi_AuthenticationType_APIKey (2.55s)
    resource_aws_appsync_graphql_api_test.go:790: skipping acceptance testing: RequestError: send request failed
        caused by: Get https://appsync.us-gov-west-1.amazonaws.com/v1/apis: dial tcp: lookup appsync.us-gov-west-1.amazonaws.com: no such host
--- SKIP: TestAccAwsAppsyncDatasource_Type (2.55s)
    resource_aws_appsync_graphql_api_test.go:790: skipping acceptance testing: RequestError: send request failed
        caused by: Get https://appsync.us-gov-west-1.amazonaws.com/v1/apis: dial tcp: lookup appsync.us-gov-west-1.amazonaws.com: no such host
--- SKIP: TestAccAwsAppsyncDatasource_DynamoDBConfig_UseCallerCredentials (2.55s)
    resource_aws_appsync_graphql_api_test.go:790: skipping acceptance testing: RequestError: send request failed
        caused by: Get https://appsync.us-gov-west-1.amazonaws.com/v1/apis: dial tcp: lookup appsync.us-gov-west-1.amazonaws.com: no such host
--- SKIP: TestAccAWSAppsyncGraphqlApi_Schema (2.55s)
    resource_aws_appsync_graphql_api_test.go:790: skipping acceptance testing: RequestError: send request failed
        caused by: Get https://appsync.us-gov-west-1.amazonaws.com/v1/apis: dial tcp: lookup appsync.us-gov-west-1.amazonaws.com: no such host
--- SKIP: TestAccAWSAppsyncGraphqlApi_disappears (2.55s)
    resource_aws_appsync_graphql_api_test.go:790: skipping acceptance testing: RequestError: send request failed
        caused by: Get https://appsync.us-gov-west-1.amazonaws.com/v1/apis: dial tcp: lookup appsync.us-gov-west-1.amazonaws.com: no such host
--- SKIP: TestAccAwsAppsyncDatasource_Description (2.55s)
    resource_aws_appsync_graphql_api_test.go:790: skipping acceptance testing: RequestError: send request failed
        caused by: Get https://appsync.us-gov-west-1.amazonaws.com/v1/apis: dial tcp: lookup appsync.us-gov-west-1.amazonaws.com: no such host
--- SKIP: TestAccAwsAppsyncDatasource_basic (2.55s)
    resource_aws_appsync_graphql_api_test.go:790: skipping acceptance testing: RequestError: send request failed
        caused by: Get https://appsync.us-gov-west-1.amazonaws.com/v1/apis: dial tcp: lookup appsync.us-gov-west-1.amazonaws.com: no such host
--- SKIP: TestAccAwsAppsyncDatasource_DynamoDBConfig_Region (3.32s)
    resource_aws_appsync_graphql_api_test.go:790: skipping acceptance testing: RequestError: send request failed
        caused by: Get https://appsync.us-gov-west-1.amazonaws.com/v1/apis: dial tcp: lookup appsync.us-gov-west-1.amazonaws.com: no such host
--- SKIP: TestAccAWSAppsyncGraphqlApi_Tags (1.86s)
    resource_aws_appsync_graphql_api_test.go:790: skipping acceptance testing: RequestError: send request failed
        caused by: Get https://appsync.us-gov-west-1.amazonaws.com/v1/apis: dial tcp: lookup appsync.us-gov-west-1.amazonaws.com: no such host
--- SKIP: TestAccAwsAppsyncResolver_RequestTemplate (1.90s)
    resource_aws_appsync_graphql_api_test.go:790: skipping acceptance testing: RequestError: send request failed
        caused by: Get https://appsync.us-gov-west-1.amazonaws.com/v1/apis: dial tcp: lookup appsync.us-gov-west-1.amazonaws.com: no such host
--- SKIP: TestAccAWSAppsyncGraphqlApi_OpenIDConnectConfig_AuthTTL (1.90s)
    resource_aws_appsync_graphql_api_test.go:790: skipping acceptance testing: RequestError: send request failed
        caused by: Get https://appsync.us-gov-west-1.amazonaws.com/v1/apis: dial tcp: lookup appsync.us-gov-west-1.amazonaws.com: no such host
--- SKIP: TestAccAwsAppsyncResolver_disappears (1.91s)
    resource_aws_appsync_graphql_api_test.go:790: skipping acceptance testing: RequestError: send request failed
        caused by: Get https://appsync.us-gov-west-1.amazonaws.com/v1/apis: dial tcp: lookup appsync.us-gov-west-1.amazonaws.com: no such host
--- SKIP: TestAccAwsAppsyncResolver_DataSource (1.92s)
    resource_aws_appsync_graphql_api_test.go:790: skipping acceptance testing: RequestError: send request failed
        caused by: Get https://appsync.us-gov-west-1.amazonaws.com/v1/apis: dial tcp: lookup appsync.us-gov-west-1.amazonaws.com: no such host
--- SKIP: TestAccAWSAppsyncGraphqlApi_AuthenticationType_OpenIDConnect (1.92s)
    resource_aws_appsync_graphql_api_test.go:790: skipping acceptance testing: RequestError: send request failed
        caused by: Get https://appsync.us-gov-west-1.amazonaws.com/v1/apis: dial tcp: lookup appsync.us-gov-west-1.amazonaws.com: no such host
--- SKIP: TestAccAwsAppsyncResolver_basic (1.93s)
    resource_aws_appsync_graphql_api_test.go:790: skipping acceptance testing: RequestError: send request failed
        caused by: Get https://appsync.us-gov-west-1.amazonaws.com/v1/apis: dial tcp: lookup appsync.us-gov-west-1.amazonaws.com: no such host
--- SKIP: TestAccAwsAppsyncResolver_ResponseTemplate (1.93s)
    resource_aws_appsync_graphql_api_test.go:790: skipping acceptance testing: RequestError: send request failed
        caused by: Get https://appsync.us-gov-west-1.amazonaws.com/v1/apis: dial tcp: lookup appsync.us-gov-west-1.amazonaws.com: no such host
--- SKIP: TestAccAWSAppsyncGraphqlApi_UserPoolConfig_AwsRegion (1.93s)
    resource_aws_appsync_graphql_api_test.go:790: skipping acceptance testing: RequestError: send request failed
        caused by: Get https://appsync.us-gov-west-1.amazonaws.com/v1/apis: dial tcp: lookup appsync.us-gov-west-1.amazonaws.com: no such host
--- SKIP: TestAccAWSAppsyncGraphqlApi_OpenIDConnectConfig_ClientID (1.93s)
    resource_aws_appsync_graphql_api_test.go:790: skipping acceptance testing: RequestError: send request failed
        caused by: Get https://appsync.us-gov-west-1.amazonaws.com/v1/apis: dial tcp: lookup appsync.us-gov-west-1.amazonaws.com: no such host
--- SKIP: TestAccAWSAppsyncGraphqlApi_LogConfig (1.93s)
    resource_aws_appsync_graphql_api_test.go:790: skipping acceptance testing: RequestError: send request failed
        caused by: Get https://appsync.us-gov-west-1.amazonaws.com/v1/apis: dial tcp: lookup appsync.us-gov-west-1.amazonaws.com: no such host
--- SKIP: TestAccAWSAppsyncApiKey_Description (1.95s)
    resource_aws_appsync_graphql_api_test.go:790: skipping acceptance testing: RequestError: send request failed
        caused by: Get https://appsync.us-gov-west-1.amazonaws.com/v1/apis: dial tcp: lookup appsync.us-gov-west-1.amazonaws.com: no such host
--- SKIP: TestAccAWSAppsyncGraphqlApi_LogConfig_FieldLogLevel (1.95s)
    resource_aws_appsync_graphql_api_test.go:790: skipping acceptance testing: RequestError: send request failed
        caused by: Get https://appsync.us-gov-west-1.amazonaws.com/v1/apis: dial tcp: lookup appsync.us-gov-west-1.amazonaws.com: no such host
--- SKIP: TestAccAwsAppsyncResolver_multipleResolvers (1.96s)
    resource_aws_appsync_graphql_api_test.go:790: skipping acceptance testing: RequestError: send request failed
        caused by: Get https://appsync.us-gov-west-1.amazonaws.com/v1/apis: dial tcp: lookup appsync.us-gov-west-1.amazonaws.com: no such host
--- SKIP: TestAccAWSAppsyncGraphqlApi_OpenIDConnectConfig_Issuer (2.00s)
    resource_aws_appsync_graphql_api_test.go:790: skipping acceptance testing: RequestError: send request failed
        caused by: Get https://appsync.us-gov-west-1.amazonaws.com/v1/apis: dial tcp: lookup appsync.us-gov-west-1.amazonaws.com: no such host
--- SKIP: TestAccAWSAppsyncGraphqlApi_AuthenticationType_AmazonCognitoUserPools (2.00s)
    resource_aws_appsync_graphql_api_test.go:790: skipping acceptance testing: RequestError: send request failed
        caused by: Get https://appsync.us-gov-west-1.amazonaws.com/v1/apis: dial tcp: lookup appsync.us-gov-west-1.amazonaws.com: no such host
--- SKIP: TestAccAWSAppsyncGraphqlApi_UserPoolConfig_DefaultAction (2.01s)
    resource_aws_appsync_graphql_api_test.go:790: skipping acceptance testing: RequestError: send request failed
        caused by: Get https://appsync.us-gov-west-1.amazonaws.com/v1/apis: dial tcp: lookup appsync.us-gov-west-1.amazonaws.com: no such host
--- SKIP: TestAccAWSAppsyncGraphqlApi_Name (2.03s)
    resource_aws_appsync_graphql_api_test.go:790: skipping acceptance testing: RequestError: send request failed
        caused by: Get https://appsync.us-gov-west-1.amazonaws.com/v1/apis: dial tcp: lookup appsync.us-gov-west-1.amazonaws.com: no such host
--- SKIP: TestAccAWSAppsyncGraphqlApi_OpenIDConnectConfig_IatTTL (2.04s)
    resource_aws_appsync_graphql_api_test.go:790: skipping acceptance testing: RequestError: send request failed
        caused by: Get https://appsync.us-gov-west-1.amazonaws.com/v1/apis: dial tcp: lookup appsync.us-gov-west-1.amazonaws.com: no such host
  • tests/resource/aws_appsync_datasource: Fix Lambda runtime (b01bfd6)

Previous output from acceptance testing:

--- FAIL: TestAccAwsAppsyncDatasource_Type_Lambda (25.53s)
    testing.go:568: Step 0 error: errors during apply:

        Error: Error creating Lambda function: InvalidParameterValueException: The runtime parameter of nodejs6.10 is no longer supported for creating or updating AWS Lambda functions. We recommend you use the new runtime (nodejs8.10) while creating or updating functions.
        	status code: 400, request id: 2ad8fdcd-78dd-11e9-82e1-0b28c3b9519b

          on /var/folders/v0/_d108fkx1pbbg4_sh864_7740000gn/T/tf-test220210354/main.tf line 21:
          (source code not available)

Output from acceptance testing:

--- PASS: TestAccAwsAppsyncDatasource_Type_Lambda (26.25s)

bflad added 3 commits May 17, 2019 15:41
@bflad
resource/aws_appsync_graphql_api: Adjust error messaging for context …
006cbfe 
…and proper formatter typing

Previously error messages during creation would use an incorrect format verb which was harder to read:

```
--- FAIL: TestAccAWSAppsyncGraphqlApi_basic (0.50s)
    testing.go:568: Step 0 error: errors during apply:

        Error: error creating AppSync GraphQL API: &{%!d(string=RequestError) %!d(string=send request failed) [824649821952]}
```

Now error messages are properly formatted and consistently applied across Create/Read/Update/Delete functions.

```
--- FAIL: TestAccAWSAppsyncGraphqlApi_basic (6.36s)
    testing.go:568: Step 0 error: errors during apply:

        Error: error creating AppSync GraphQL API: RequestError: send request failed
        caused by: Post https://appsync.us-gov-west-1.amazonaws.com/v1/apis: dial tcp: lookup appsync.us-gov-west-1.amazonaws.com: no such host
```

Output from acceptance testing:

```
--- PASS: TestAccAWSAppsyncGraphqlApi_disappears (12.98s)
--- PASS: TestAccAWSAppsyncGraphqlApi_AuthenticationType_AWSIAM (13.22s)
--- PASS: TestAccAWSAppsyncGraphqlApi_AuthenticationType_APIKey (13.49s)
--- PASS: TestAccAWSAppsyncGraphqlApi_basic (13.94s)
--- PASS: TestAccAWSAppsyncGraphqlApi_LogConfig (15.25s)
--- PASS: TestAccAWSAppsyncGraphqlApi_AuthenticationType_OpenIDConnect (15.56s)
--- PASS: TestAccAWSAppsyncGraphqlApi_AuthenticationType_AmazonCognitoUserPools (15.93s)
--- PASS: TestAccAWSAppsyncGraphqlApi_OpenIDConnectConfig_Issuer (19.66s)
--- PASS: TestAccAWSAppsyncGraphqlApi_OpenIDConnectConfig_ClientID (19.78s)
--- PASS: TestAccAWSAppsyncGraphqlApi_AuthenticationType (19.99s)
--- PASS: TestAccAWSAppsyncGraphqlApi_OpenIDConnectConfig_AuthTTL (21.15s)
--- PASS: TestAccAWSAppsyncGraphqlApi_UserPoolConfig_DefaultAction (22.64s)
--- PASS: TestAccAWSAppsyncGraphqlApi_UserPoolConfig_AwsRegion (22.64s)
--- PASS: TestAccAWSAppsyncGraphqlApi_LogConfig_FieldLogLevel (27.56s)
--- PASS: TestAccAWSAppsyncGraphqlApi_OpenIDConnectConfig_IatTTL (29.54s)
--- PASS: TestAccAWSAppsyncGraphqlApi_Name (29.79s)
--- PASS: TestAccAWSAppsyncGraphqlApi_Schema (29.99s)
--- PASS: TestAccAWSAppsyncGraphqlApi_Tags (30.21s)
```
@bflad
tests/service/appsync: Add PreCheck for service availability
b9b193d 
Previously in AWS GovCloud (US) acceptance testing:

```
--- FAIL: TestAccAWSAppsyncGraphqlApi_basic (6.36s)
    testing.go:568: Step 0 error: errors during apply:

        Error: error creating AppSync GraphQL API: RequestError: send request failed
        caused by: Post https://appsync.us-gov-west-1.amazonaws.com/v1/apis: dial tcp: lookup appsync.us-gov-west-1.amazonaws.com: no such host
```

Output from AWS Standard acceptance testing:

```
--- PASS: TestAccAWSAppsyncGraphqlApi_disappears (11.00s)
--- PASS: TestAccAWSAppsyncGraphqlApi_AuthenticationType_APIKey (12.86s)
--- PASS: TestAccAwsAppsyncDatasource_Type_HTTP (14.70s)
--- PASS: TestAccAWSAppsyncApiKey_basic (15.89s)
--- PASS: TestAccAWSAppsyncGraphqlApi_OpenIDConnectConfig_AuthTTL (19.99s)
--- PASS: TestAccAwsAppsyncDatasource_Type (20.55s)
--- PASS: TestAccAWSAppsyncGraphqlApi_basic (23.15s)
--- PASS: TestAccAWSAppsyncGraphqlApi_AuthenticationType (23.45s)
--- PASS: TestAccAWSAppsyncGraphqlApi_AuthenticationType_OpenIDConnect (10.83s)
--- PASS: TestAccAwsAppsyncDatasource_Type_None (24.06s)
--- PASS: TestAccAWSAppsyncGraphqlApi_LogConfig (13.60s)
--- PASS: TestAccAWSAppsyncGraphqlApi_AuthenticationType_AWSIAM (24.69s)
--- FAIL: TestAccAwsAppsyncDatasource_Type_Lambda (25.53s)
    testing.go:568: Step 0 error: errors during apply:

        Error: Error creating Lambda function: InvalidParameterValueException: The runtime parameter of nodejs6.10 is no longer supported for creating or updating AWS Lambda functions. We recommend you use the new runtime (nodejs8.10) while creating or updating functions.
        	status code: 400, request id: 2ad8fdcd-78dd-11e9-82e1-0b28c3b9519b

          on /var/folders/v0/_d108fkx1pbbg4_sh864_7740000gn/T/tf-test220210354/main.tf line 21:
          (source code not available)

--- PASS: TestAccAWSAppsyncGraphqlApi_OpenIDConnectConfig_Issuer (27.02s)
--- PASS: TestAccAWSAppsyncGraphqlApi_OpenIDConnectConfig_IatTTL (28.93s)
--- PASS: TestAccAWSAppsyncGraphqlApi_UserPoolConfig_AwsRegion (29.85s)
--- PASS: TestAccAWSAppsyncGraphqlApi_Schema (30.41s)
--- PASS: TestAccAwsAppsyncDatasource_Type_DynamoDB (30.73s)
--- PASS: TestAccAWSAppsyncGraphqlApi_AuthenticationType_AmazonCognitoUserPools (16.64s)
--- PASS: TestAccAWSAppsyncGraphqlApi_Name (31.69s)
--- PASS: TestAccAWSAppsyncGraphqlApi_OpenIDConnectConfig_ClientID (31.98s)
--- PASS: TestAccAWSAppsyncGraphqlApi_LogConfig_FieldLogLevel (32.35s)
--- PASS: TestAccAwsAppsyncResolver_disappears (17.48s)
--- PASS: TestAccAwsAppsyncResolver_basic (18.71s)
--- PASS: TestAccAwsAppsyncDatasource_basic (14.51s)
--- PASS: TestAccAWSAppsyncGraphqlApi_Tags (19.65s)
--- PASS: TestAccAwsAppsyncDatasource_HTTPConfig_Endpoint (20.76s)
--- PASS: TestAccAWSAppsyncGraphqlApi_UserPoolConfig_DefaultAction (21.72s)
--- PASS: TestAccAWSAppsyncApiKey_Expires (18.96s)
--- PASS: TestAccAwsAppsyncDatasource_Description (20.44s)
--- PASS: TestAccAWSAppsyncApiKey_Description (18.41s)
--- PASS: TestAccAwsAppsyncResolver_ResponseTemplate (23.14s)
--- PASS: TestAccAwsAppsyncResolver_DataSource (22.28s)
--- PASS: TestAccAwsAppsyncResolver_RequestTemplate (26.09s)
--- PASS: TestAccAwsAppsyncResolver_multipleResolvers (47.98s)
--- PASS: TestAccAwsAppsyncDatasource_DynamoDBConfig_UseCallerCredentials (122.51s)
--- PASS: TestAccAwsAppsyncDatasource_DynamoDBConfig_Region (124.23s)
--- PASS: TestAccAwsAppsyncDatasource_ElasticsearchConfig_Region (551.20s)
--- PASS: TestAccAwsAppsyncDatasource_Type_Elasticsearch (648.43s)
```

Output from AWS GovCloud (US) acceptance testing:

```
--- SKIP: TestAccAwsAppsyncDatasource_Type_Elasticsearch (2.55s)
    resource_aws_appsync_graphql_api_test.go:790: skipping acceptance testing: RequestError: send request failed
        caused by: Get https://appsync.us-gov-west-1.amazonaws.com/v1/apis: dial tcp: lookup appsync.us-gov-west-1.amazonaws.com: no such host
--- SKIP: TestAccAWSAppsyncGraphqlApi_AuthenticationType (2.55s)
    resource_aws_appsync_graphql_api_test.go:790: skipping acceptance testing: RequestError: send request failed
        caused by: Get https://appsync.us-gov-west-1.amazonaws.com/v1/apis: dial tcp: lookup appsync.us-gov-west-1.amazonaws.com: no such host
--- SKIP: TestAccAwsAppsyncDatasource_Type_HTTP (2.55s)
    resource_aws_appsync_graphql_api_test.go:790: skipping acceptance testing: RequestError: send request failed
        caused by: Get https://appsync.us-gov-west-1.amazonaws.com/v1/apis: dial tcp: lookup appsync.us-gov-west-1.amazonaws.com: no such host
--- SKIP: TestAccAwsAppsyncDatasource_Type_DynamoDB (2.55s)
    resource_aws_appsync_graphql_api_test.go:790: skipping acceptance testing: RequestError: send request failed
        caused by: Get https://appsync.us-gov-west-1.amazonaws.com/v1/apis: dial tcp: lookup appsync.us-gov-west-1.amazonaws.com: no such host
--- SKIP: TestAccAwsAppsyncDatasource_Type_None (2.55s)
    resource_aws_appsync_graphql_api_test.go:790: skipping acceptance testing: RequestError: send request failed
        caused by: Get https://appsync.us-gov-west-1.amazonaws.com/v1/apis: dial tcp: lookup appsync.us-gov-west-1.amazonaws.com: no such host
--- SKIP: TestAccAwsAppsyncDatasource_ElasticsearchConfig_Region (2.55s)
    resource_aws_appsync_graphql_api_test.go:790: skipping acceptance testing: RequestError: send request failed
        caused by: Get https://appsync.us-gov-west-1.amazonaws.com/v1/apis: dial tcp: lookup appsync.us-gov-west-1.amazonaws.com: no such host
--- SKIP: TestAccAWSAppsyncGraphqlApi_basic (2.55s)
    resource_aws_appsync_graphql_api_test.go:790: skipping acceptance testing: RequestError: send request failed
        caused by: Get https://appsync.us-gov-west-1.amazonaws.com/v1/apis: dial tcp: lookup appsync.us-gov-west-1.amazonaws.com: no such host
--- SKIP: TestAccAWSAppsyncApiKey_basic (2.55s)
    resource_aws_appsync_graphql_api_test.go:790: skipping acceptance testing: RequestError: send request failed
        caused by: Get https://appsync.us-gov-west-1.amazonaws.com/v1/apis: dial tcp: lookup appsync.us-gov-west-1.amazonaws.com: no such host
--- SKIP: TestAccAWSAppsyncGraphqlApi_AuthenticationType_AWSIAM (2.55s)
    resource_aws_appsync_graphql_api_test.go:790: skipping acceptance testing: RequestError: send request failed
        caused by: Get https://appsync.us-gov-west-1.amazonaws.com/v1/apis: dial tcp: lookup appsync.us-gov-west-1.amazonaws.com: no such host
--- SKIP: TestAccAWSAppsyncApiKey_Expires (2.55s)
    resource_aws_appsync_graphql_api_test.go:790: skipping acceptance testing: RequestError: send request failed
        caused by: Get https://appsync.us-gov-west-1.amazonaws.com/v1/apis: dial tcp: lookup appsync.us-gov-west-1.amazonaws.com: no such host
--- SKIP: TestAccAwsAppsyncDatasource_Type_Lambda (2.55s)
    resource_aws_appsync_graphql_api_test.go:790: skipping acceptance testing: RequestError: send request failed
        caused by: Get https://appsync.us-gov-west-1.amazonaws.com/v1/apis: dial tcp: lookup appsync.us-gov-west-1.amazonaws.com: no such host
--- SKIP: TestAccAwsAppsyncDatasource_HTTPConfig_Endpoint (2.55s)
    resource_aws_appsync_graphql_api_test.go:790: skipping acceptance testing: RequestError: send request failed
        caused by: Get https://appsync.us-gov-west-1.amazonaws.com/v1/apis: dial tcp: lookup appsync.us-gov-west-1.amazonaws.com: no such host
--- SKIP: TestAccAWSAppsyncGraphqlApi_AuthenticationType_APIKey (2.55s)
    resource_aws_appsync_graphql_api_test.go:790: skipping acceptance testing: RequestError: send request failed
        caused by: Get https://appsync.us-gov-west-1.amazonaws.com/v1/apis: dial tcp: lookup appsync.us-gov-west-1.amazonaws.com: no such host
--- SKIP: TestAccAwsAppsyncDatasource_Type (2.55s)
    resource_aws_appsync_graphql_api_test.go:790: skipping acceptance testing: RequestError: send request failed
        caused by: Get https://appsync.us-gov-west-1.amazonaws.com/v1/apis: dial tcp: lookup appsync.us-gov-west-1.amazonaws.com: no such host
--- SKIP: TestAccAwsAppsyncDatasource_DynamoDBConfig_UseCallerCredentials (2.55s)
    resource_aws_appsync_graphql_api_test.go:790: skipping acceptance testing: RequestError: send request failed
        caused by: Get https://appsync.us-gov-west-1.amazonaws.com/v1/apis: dial tcp: lookup appsync.us-gov-west-1.amazonaws.com: no such host
--- SKIP: TestAccAWSAppsyncGraphqlApi_Schema (2.55s)
    resource_aws_appsync_graphql_api_test.go:790: skipping acceptance testing: RequestError: send request failed
        caused by: Get https://appsync.us-gov-west-1.amazonaws.com/v1/apis: dial tcp: lookup appsync.us-gov-west-1.amazonaws.com: no such host
--- SKIP: TestAccAWSAppsyncGraphqlApi_disappears (2.55s)
    resource_aws_appsync_graphql_api_test.go:790: skipping acceptance testing: RequestError: send request failed
        caused by: Get https://appsync.us-gov-west-1.amazonaws.com/v1/apis: dial tcp: lookup appsync.us-gov-west-1.amazonaws.com: no such host
--- SKIP: TestAccAwsAppsyncDatasource_Description (2.55s)
    resource_aws_appsync_graphql_api_test.go:790: skipping acceptance testing: RequestError: send request failed
        caused by: Get https://appsync.us-gov-west-1.amazonaws.com/v1/apis: dial tcp: lookup appsync.us-gov-west-1.amazonaws.com: no such host
--- SKIP: TestAccAwsAppsyncDatasource_basic (2.55s)
    resource_aws_appsync_graphql_api_test.go:790: skipping acceptance testing: RequestError: send request failed
        caused by: Get https://appsync.us-gov-west-1.amazonaws.com/v1/apis: dial tcp: lookup appsync.us-gov-west-1.amazonaws.com: no such host
--- SKIP: TestAccAwsAppsyncDatasource_DynamoDBConfig_Region (3.32s)
    resource_aws_appsync_graphql_api_test.go:790: skipping acceptance testing: RequestError: send request failed
        caused by: Get https://appsync.us-gov-west-1.amazonaws.com/v1/apis: dial tcp: lookup appsync.us-gov-west-1.amazonaws.com: no such host
--- SKIP: TestAccAWSAppsyncGraphqlApi_Tags (1.86s)
    resource_aws_appsync_graphql_api_test.go:790: skipping acceptance testing: RequestError: send request failed
        caused by: Get https://appsync.us-gov-west-1.amazonaws.com/v1/apis: dial tcp: lookup appsync.us-gov-west-1.amazonaws.com: no such host
--- SKIP: TestAccAwsAppsyncResolver_RequestTemplate (1.90s)
    resource_aws_appsync_graphql_api_test.go:790: skipping acceptance testing: RequestError: send request failed
        caused by: Get https://appsync.us-gov-west-1.amazonaws.com/v1/apis: dial tcp: lookup appsync.us-gov-west-1.amazonaws.com: no such host
--- SKIP: TestAccAWSAppsyncGraphqlApi_OpenIDConnectConfig_AuthTTL (1.90s)
    resource_aws_appsync_graphql_api_test.go:790: skipping acceptance testing: RequestError: send request failed
        caused by: Get https://appsync.us-gov-west-1.amazonaws.com/v1/apis: dial tcp: lookup appsync.us-gov-west-1.amazonaws.com: no such host
--- SKIP: TestAccAwsAppsyncResolver_disappears (1.91s)
    resource_aws_appsync_graphql_api_test.go:790: skipping acceptance testing: RequestError: send request failed
        caused by: Get https://appsync.us-gov-west-1.amazonaws.com/v1/apis: dial tcp: lookup appsync.us-gov-west-1.amazonaws.com: no such host
--- SKIP: TestAccAwsAppsyncResolver_DataSource (1.92s)
    resource_aws_appsync_graphql_api_test.go:790: skipping acceptance testing: RequestError: send request failed
        caused by: Get https://appsync.us-gov-west-1.amazonaws.com/v1/apis: dial tcp: lookup appsync.us-gov-west-1.amazonaws.com: no such host
--- SKIP: TestAccAWSAppsyncGraphqlApi_AuthenticationType_OpenIDConnect (1.92s)
    resource_aws_appsync_graphql_api_test.go:790: skipping acceptance testing: RequestError: send request failed
        caused by: Get https://appsync.us-gov-west-1.amazonaws.com/v1/apis: dial tcp: lookup appsync.us-gov-west-1.amazonaws.com: no such host
--- SKIP: TestAccAwsAppsyncResolver_basic (1.93s)
    resource_aws_appsync_graphql_api_test.go:790: skipping acceptance testing: RequestError: send request failed
        caused by: Get https://appsync.us-gov-west-1.amazonaws.com/v1/apis: dial tcp: lookup appsync.us-gov-west-1.amazonaws.com: no such host
--- SKIP: TestAccAwsAppsyncResolver_ResponseTemplate (1.93s)
    resource_aws_appsync_graphql_api_test.go:790: skipping acceptance testing: RequestError: send request failed
        caused by: Get https://appsync.us-gov-west-1.amazonaws.com/v1/apis: dial tcp: lookup appsync.us-gov-west-1.amazonaws.com: no such host
--- SKIP: TestAccAWSAppsyncGraphqlApi_UserPoolConfig_AwsRegion (1.93s)
    resource_aws_appsync_graphql_api_test.go:790: skipping acceptance testing: RequestError: send request failed
        caused by: Get https://appsync.us-gov-west-1.amazonaws.com/v1/apis: dial tcp: lookup appsync.us-gov-west-1.amazonaws.com: no such host
--- SKIP: TestAccAWSAppsyncGraphqlApi_OpenIDConnectConfig_ClientID (1.93s)
    resource_aws_appsync_graphql_api_test.go:790: skipping acceptance testing: RequestError: send request failed
        caused by: Get https://appsync.us-gov-west-1.amazonaws.com/v1/apis: dial tcp: lookup appsync.us-gov-west-1.amazonaws.com: no such host
--- SKIP: TestAccAWSAppsyncGraphqlApi_LogConfig (1.93s)
    resource_aws_appsync_graphql_api_test.go:790: skipping acceptance testing: RequestError: send request failed
        caused by: Get https://appsync.us-gov-west-1.amazonaws.com/v1/apis: dial tcp: lookup appsync.us-gov-west-1.amazonaws.com: no such host
--- SKIP: TestAccAWSAppsyncApiKey_Description (1.95s)
    resource_aws_appsync_graphql_api_test.go:790: skipping acceptance testing: RequestError: send request failed
        caused by: Get https://appsync.us-gov-west-1.amazonaws.com/v1/apis: dial tcp: lookup appsync.us-gov-west-1.amazonaws.com: no such host
--- SKIP: TestAccAWSAppsyncGraphqlApi_LogConfig_FieldLogLevel (1.95s)
    resource_aws_appsync_graphql_api_test.go:790: skipping acceptance testing: RequestError: send request failed
        caused by: Get https://appsync.us-gov-west-1.amazonaws.com/v1/apis: dial tcp: lookup appsync.us-gov-west-1.amazonaws.com: no such host
--- SKIP: TestAccAwsAppsyncResolver_multipleResolvers (1.96s)
    resource_aws_appsync_graphql_api_test.go:790: skipping acceptance testing: RequestError: send request failed
        caused by: Get https://appsync.us-gov-west-1.amazonaws.com/v1/apis: dial tcp: lookup appsync.us-gov-west-1.amazonaws.com: no such host
--- SKIP: TestAccAWSAppsyncGraphqlApi_OpenIDConnectConfig_Issuer (2.00s)
    resource_aws_appsync_graphql_api_test.go:790: skipping acceptance testing: RequestError: send request failed
        caused by: Get https://appsync.us-gov-west-1.amazonaws.com/v1/apis: dial tcp: lookup appsync.us-gov-west-1.amazonaws.com: no such host
--- SKIP: TestAccAWSAppsyncGraphqlApi_AuthenticationType_AmazonCognitoUserPools (2.00s)
    resource_aws_appsync_graphql_api_test.go:790: skipping acceptance testing: RequestError: send request failed
        caused by: Get https://appsync.us-gov-west-1.amazonaws.com/v1/apis: dial tcp: lookup appsync.us-gov-west-1.amazonaws.com: no such host
--- SKIP: TestAccAWSAppsyncGraphqlApi_UserPoolConfig_DefaultAction (2.01s)
    resource_aws_appsync_graphql_api_test.go:790: skipping acceptance testing: RequestError: send request failed
        caused by: Get https://appsync.us-gov-west-1.amazonaws.com/v1/apis: dial tcp: lookup appsync.us-gov-west-1.amazonaws.com: no such host
--- SKIP: TestAccAWSAppsyncGraphqlApi_Name (2.03s)
    resource_aws_appsync_graphql_api_test.go:790: skipping acceptance testing: RequestError: send request failed
        caused by: Get https://appsync.us-gov-west-1.amazonaws.com/v1/apis: dial tcp: lookup appsync.us-gov-west-1.amazonaws.com: no such host
--- SKIP: TestAccAWSAppsyncGraphqlApi_OpenIDConnectConfig_IatTTL (2.04s)
    resource_aws_appsync_graphql_api_test.go:790: skipping acceptance testing: RequestError: send request failed
        caused by: Get https://appsync.us-gov-west-1.amazonaws.com/v1/apis: dial tcp: lookup appsync.us-gov-west-1.amazonaws.com: no such host
```
@bflad
tests/resource/aws_appsync_datasource: Fix Lambda runtime
b01bfd6 
Previous output from acceptance testing:

```
--- FAIL: TestAccAwsAppsyncDatasource_Type_Lambda (25.53s)
    testing.go:568: Step 0 error: errors during apply:

        Error: Error creating Lambda function: InvalidParameterValueException: The runtime parameter of nodejs6.10 is no longer supported for creating or updating AWS Lambda functions. We recommend you use the new runtime (nodejs8.10) while creating or updating functions.
        	status code: 400, request id: 2ad8fdcd-78dd-11e9-82e1-0b28c3b9519b

          on /var/folders/v0/_d108fkx1pbbg4_sh864_7740000gn/T/tf-test220210354/main.tf line 21:
          (source code not available)
```

Output from acceptance testing:

```
--- PASS: TestAccAwsAppsyncDatasource_Type_Lambda (26.25s)
```
@ghost ghost added size/M Managed by automation to categorize the size of a PR. service/appsync Issues and PRs that pertain to the appsync service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels May 17, 2019
@bflad bflad added the partition/aws-us-gov Pertains to the aws-us-gov partition. label May 17, 2019
nywilken
nywilken approved these changes May 24, 2019
View reviewed changes
Copy link
Contributor

@nywilken nywilken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bflad bflad added this to the v2.13.0 milestone May 24, 2019
@bflad bflad merged commit 72ba3a0 into master May 24, 2019
@bflad bflad deleted the t-appsync-precheck branch May 24, 2019 10:22
@ghost
Copy link

ghost commented Mar 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nywilken nywilken nywilken approved these changes

Assignees
No one assigned
Labels
partition/aws-us-gov Pertains to the aws-us-gov partition. service/appsync Issues and PRs that pertain to the appsync service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v2.13.0
Development

Successfully merging this pull request may close these issues.
2 participants
@bflad @nywilken