Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws_elasticache_replication_group: Implement noop MigrateState for v0..v1 #8887

Merged
merged 4 commits into from
Jun 11, 2019
Merged

aws_elasticache_replication_group: Implement noop MigrateState for v0..v1 #8887

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ca38834
aws_elasticache_replication_group: Implement no-op MigrateState from …
akatrevorjay Jun 3, 2019
ac20102
gofmt
akatrevorjay Jun 6, 2019
122b8d5
Merge remote-tracking branch 'upstream/master' into upgrade-0.12
akatrevorjay Jun 6, 2019
dbc10a0
Swap MigrateState to one requested by reviewer.
akatrevorjay Jun 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions aws/resource_aws_elasticache_replication_group.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,11 @@ import (

"github.com/aws/aws-sdk-go/aws"
"github.com/aws/aws-sdk-go/service/elasticache"

"github.com/hashicorp/terraform/helper/resource"
"github.com/hashicorp/terraform/helper/schema"
"github.com/hashicorp/terraform/helper/validation"
"github.com/hashicorp/terraform/terraform"
)

func resourceAwsElasticacheReplicationGroup() *schema.Resource {
Expand Down Expand Up @@ -224,6 +226,13 @@ func resourceAwsElasticacheReplicationGroup() *schema.Resource {
},
SchemaVersion: 1,

// SchemaVersion: 1 did not include any state changes via MigrateState.
// Perform a no-operation state upgrade for Terraform 0.12 compatibility.
// Future state migrations should be performed with StateUpgraders.
MigrateState: func(v int, inst *terraform.InstanceState, meta interface{}) (*terraform.InstanceState, error) {
return inst, nil
},

Timeouts: &schema.ResourceTimeout{
Create: schema.DefaultTimeout(60 * time.Minute),
Delete: schema.DefaultTimeout(40 * time.Minute),
Expand Down