Add Lex slot type data source and resource

[jzbruno]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates #905 and split from PR #2616

Release note for CHANGELOG:

FEATURES:
* **New Data Source:** `aws_lex_slot_type`
* **New Resource:** `aws_lex_slot_type`

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAcc.*Lex.*'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAcc.*Lex.* -timeout 120m
?   	github.com/terraform-providers/terraform-provider-aws	[no test files]
=== RUN   TestAccDataSourceAwsLexSlotType
--- PASS: TestAccDataSourceAwsLexSlotType (12.52s)
=== RUN   TestAccLexSlotType_basic
=== PAUSE TestAccLexSlotType_basic
=== RUN   TestAccAwsLexSlotType_CreateVersion
=== PAUSE TestAccAwsLexSlotType_CreateVersion
=== RUN   TestAccAwsLexSlotType_Description
=== PAUSE TestAccAwsLexSlotType_Description
=== RUN   TestAccAwsLexSlotType_EnumerationValue
=== PAUSE TestAccAwsLexSlotType_EnumerationValue
=== RUN   TestAccAwsLexSlotType_Name
=== PAUSE TestAccAwsLexSlotType_Name
=== RUN   TestAccAwsLexSlotType_ValueSelectionStrategy
=== PAUSE TestAccAwsLexSlotType_ValueSelectionStrategy
=== CONT  TestAccLexSlotType_basic
=== CONT  TestAccAwsLexSlotType_Name
=== CONT  TestAccAwsLexSlotType_ValueSelectionStrategy
=== CONT  TestAccAwsLexSlotType_EnumerationValue
=== CONT  TestAccAwsLexSlotType_Description
=== CONT  TestAccAwsLexSlotType_CreateVersion
--- PASS: TestAccLexSlotType_basic (9.37s)
--- PASS: TestAccAwsLexSlotType_CreateVersion (18.77s)
--- PASS: TestAccAwsLexSlotType_Description (19.74s)
--- PASS: TestAccAwsLexSlotType_EnumerationValue (21.03s)
--- PASS: TestAccAwsLexSlotType_Name (22.03s)
--- PASS: TestAccAwsLexSlotType_ValueSelectionStrategy (23.35s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	35.933s
...

[nywilken]

@jzbruno thanks again for pushing this forward. These two resources are looking pretty good. Nicely done.

There are a few comments that I would like for you to address before I move onto the next PR. Please let me know if you have any questions or additional thoughts on the requested changes. Cheers.

[jzbruno]

@nywilken Except for the question above, I have made the requested changes to all 4 PRs.

[jzbruno]

@nywilken Ok. I have moved all common code into the resource that first uses them, and we will deal with the conflicts as each are merged. Waiting on response about moving expandLexSet into each of the 13 calls to it.

[nywilken]

@jzbruno thanks for you patience on the review, I had a little more time to dive into the API and get a sense of what is expected for this resource. I left a few implementation suggestions to address your questions, and to improve the Acceptance testing.

There is a question around the need for the version attribute within the schema which from my testing always appears to be set to $LATEST. Please take a look and let me know if you have any questions. I will start to review the other PRs now that I have a sense of what is happening with this service and this one is just about to be done.

Thanks again for your patience and support in pushing this service forward.

[jzbruno]

@jzbruno thanks for you patience on the review, I had a little more time to dive into the API and get a sense of what is expected for this resource. I left a few implementation suggestions to address your questions, and to improve the Acceptance testing.

There is a question around the need for the version attribute within the schema which from my testing always appears to be set to $LATEST. Please take a look and let me know if you have any questions. I will start to review the other PRs now that I have a sense of what is happening with this service and this one is just about to be done.

Thanks again for your patience and support in pushing this service forward.

@nywilken So, version doesn't always have to be $LATEST, you could for example manage multiple versions of bots, intents, and slot types. Let's say you create v1 and then roll out v2 but v1 is still active you would still want to manage both. Another example would be having a dev and prod version. This does highlight that import is not handling that correctly.

https://docs.aws.amazon.com/lex/latest/dg/versioning-aliases.html

What do you think?

[jzbruno]

@nywilken
Will wait on version until we discuss further. I updated the PR with the other suggestions.

How far do we want to go with breaking apart the tests for the other resources? For the Intent resource there are 56 different update combinations due to the multiple levels of nested resources.

[jzbruno]

@nywilken After reviewing the version issue further I think you are correct. The SlotType resource should always track the latest version so we can remove that as an input. I will add the create_version attribute to allow enable/disable of the version snapshotting for each change. And also add a resource for SlotTypeVersion to allow management of those version snapshots.

[jzbruno]

Ok. This is ready for review again. Should handle version correctly.

Only issue is dealing with attributes that are used for create / update but don't get returned from the API like create_version. They cause issues with importverifystate testing since the config isn't loaded at that stage and read can't get it from the API. Makes it so we have to disable the import verify on that particular test case. Any suggestions there?

[nywilken]

@jzbruno thanks for making the updates. This looks good! I addressed your question on how the ImportVerifyState step should looks for virtual arguments (i.e arguments that passed to the API, but are not part of the API response) to get the test to pass. I also left a few more requested changes to call this done.

[jzbruno]

@nywilken Ok. Updated for your comments. This should be good for another review. Thanks. And I will start work on the other PRs now.

[gdavison]

The dependency check is flagging the updates to go.mod, go.sum, and vendor/. Since this PR has been around for a while, you probably had to make a number of updates. The easiest way to work around this would be to either rebase your branch on the current main branch or to merge the current main branch into your PR. Github will see the changes either way. You may also need to run go mod tidy once or twice to remove changes to go.mod

[jzbruno]

Ok, thanks. I will try to resolve that and finish the other 2 comments tonight. Sorry for the delay on this.

[jzbruno]

@gdavison I believe I have addressed all of your comments. Latest acc test run shows

~/src/github/terraform-providers/terraform-provider-aws [error 2] $ make testacc TEST=./aws TESTARGS='-run=TestAcc.*AwsLex.*'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAcc.*AwsLex.* -timeout 120m
=== RUN   TestAccDataSourceAwsLexSlotType_basic
--- PASS: TestAccDataSourceAwsLexSlotType_basic (19.78s)
=== RUN   TestAccDataSourceAwsLexSlotType_withVersion
--- PASS: TestAccDataSourceAwsLexSlotType_withVersion (20.10s)
=== RUN   TestAccAwsLexSlotType_createVersion
=== PAUSE TestAccAwsLexSlotType_createVersion
=== RUN   TestAccAwsLexSlotType_description
=== PAUSE TestAccAwsLexSlotType_description
=== RUN   TestAccAwsLexSlotType_enumerationValues
=== PAUSE TestAccAwsLexSlotType_enumerationValues
=== RUN   TestAccAwsLexSlotType_name
=== PAUSE TestAccAwsLexSlotType_name
=== RUN   TestAccAwsLexSlotType_valueSelectionStrategy
=== PAUSE TestAccAwsLexSlotType_valueSelectionStrategy
=== RUN   TestAccAwsLexSlotType_disappears
=== PAUSE TestAccAwsLexSlotType_disappears
=== CONT  TestAccAwsLexSlotType_createVersion
=== CONT  TestAccAwsLexSlotType_valueSelectionStrategy
=== CONT  TestAccAwsLexSlotType_enumerationValues
=== CONT  TestAccAwsLexSlotType_name
=== CONT  TestAccAwsLexSlotType_disappears
=== CONT  TestAccAwsLexSlotType_description
--- PASS: TestAccAwsLexSlotType_disappears (15.02s)
--- PASS: TestAccAwsLexSlotType_description (33.38s)
--- PASS: TestAccAwsLexSlotType_createVersion (34.39s)
--- PASS: TestAccAwsLexSlotType_enumerationValues (35.59s)
--- PASS: TestAccAwsLexSlotType_valueSelectionStrategy (36.26s)
--- PASS: TestAccAwsLexSlotType_name (45.63s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	87.191s

[gdavison]

Thanks, @jzbruno, it's looking good. I have a number of suggested changes. I ran into some errors when testing, specifically the TestAccLexSlotType_basic() test.

[jzbruno]

Working through these. Will finish up tonight.

[jzbruno]

Addressed most comments but had a couple questions. Latest acceptance test results.

~/src/github/terraform-providers/terraform-provider-aws $ make testacc TEST=./aws TESTARGS='-run=TestAcc.*AwsLexSlotType.*'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAcc.*AwsLexSlotType.* -timeout 120m
=== RUN   TestAccDataSourceAwsLexSlotType_basic
=== PAUSE TestAccDataSourceAwsLexSlotType_basic
=== RUN   TestAccDataSourceAwsLexSlotType_withVersion
=== PAUSE TestAccDataSourceAwsLexSlotType_withVersion
=== RUN   TestAccAwsLexSlotType_basic
=== PAUSE TestAccAwsLexSlotType_basic
=== RUN   TestAccAwsLexSlotType_createVersion
=== PAUSE TestAccAwsLexSlotType_createVersion
=== RUN   TestAccAwsLexSlotType_description
=== PAUSE TestAccAwsLexSlotType_description
=== RUN   TestAccAwsLexSlotType_enumerationValues
=== PAUSE TestAccAwsLexSlotType_enumerationValues
=== RUN   TestAccAwsLexSlotType_name
=== PAUSE TestAccAwsLexSlotType_name
=== RUN   TestAccAwsLexSlotType_valueSelectionStrategy
=== PAUSE TestAccAwsLexSlotType_valueSelectionStrategy
=== RUN   TestAccAwsLexSlotType_disappears
=== PAUSE TestAccAwsLexSlotType_disappears
=== CONT  TestAccDataSourceAwsLexSlotType_basic
=== CONT  TestAccAwsLexSlotType_enumerationValues
=== CONT  TestAccAwsLexSlotType_createVersion
=== CONT  TestAccAwsLexSlotType_name
=== CONT  TestAccAwsLexSlotType_basic
=== CONT  TestAccAwsLexSlotType_valueSelectionStrategy
=== CONT  TestAccAwsLexSlotType_disappears
=== CONT  TestAccAwsLexSlotType_description
=== CONT  TestAccDataSourceAwsLexSlotType_withVersion
--- PASS: TestAccAwsLexSlotType_disappears (14.57s)
--- PASS: TestAccAwsLexSlotType_basic (19.99s)
--- PASS: TestAccDataSourceAwsLexSlotType_basic (20.33s)
--- PASS: TestAccDataSourceAwsLexSlotType_withVersion (26.15s)
--- PASS: TestAccAwsLexSlotType_enumerationValues (34.64s)
--- PASS: TestAccAwsLexSlotType_createVersion (35.31s)
--- PASS: TestAccAwsLexSlotType_description (35.99s)
--- PASS: TestAccAwsLexSlotType_valueSelectionStrategy (36.90s)
--- PASS: TestAccAwsLexSlotType_name (42.22s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	43.845s

[gdavison]

This is looking great, @jzbruno. A couple changes, including the multiple slot versions, and we can get it merged in.

You'll also need to update the version of the Terraform Plugin SDK to v2. Update references to the package github.com/hashicorp/terraform-plugin-sdk/* to github.com/hashicorp/terraform-plugin-sdk/v2/*. You may be able to Git rebase your branch against the current master branch (example below); replacing any remaining old import paths with the newer ones.

$ git fetch --all
$ git rebase origin/master

[jzbruno]

@gdavison Thanks I will take a look this weekend.

[ghost]

Hello, and thank you for your contribution!

This project recently upgraded to V2 of the Terraform Plugin SDK

This pull request appears to include at least one V1 import path of the SDK ("github.com/hashicorp/terraform-plugin-sdk/helper/schema"). Please import the V2 path github.com/hashicorp/terraform-plugin-sdk/v2/helper/PACKAGE

To resolve this situation without losing any existing work, you may be able to Git rebase your branch against the current master branch (example below); replacing any remaining old import paths with the newer ones.

$ git fetch --all
$ git rebase origin/master

Another option is to create a new branch from the current master with the same code changes (replacing the import paths), submit a new pull request, and close this existing pull request.

We apologize for this inconvenience and appreciate your effort. Thank you for contributing and helping make the Terraform AWS Provider better for everyone.

[ghost]

Hello, and thank you for your contribution!
This pull request appears to include the Go import path "github.com/hashicorp/terraform-plugin-sdk/helper/mutexkv", which was deprecated after upgrading to V2 of the Terraform Plugin SDK.
You may use a now internalized version of the package found in github.com/terraform-providers/terraform-provider-aws/aws/internal/PACKAGE.

[jzbruno]

@gdavison I think I finished all your suggestions.

[gdavison]

LGTM 🚀

Acceptance tests in Commercial partitions

--- PASS: TestAccAwsLexSlotType_disappears (24.29s)
--- PASS: TestAccDataSourceAwsLexSlotType_withVersion (27.80s)
--- PASS: TestAccAwsLexSlotType_basic (30.06s)
--- PASS: TestAccDataSourceAwsLexSlotType_basic (37.82s)
--- PASS: TestAccAwsLexSlotType_valueSelectionStrategy (44.35s)
--- PASS: TestAccAwsLexSlotType_createVersion (45.07s)
--- PASS: TestAccAwsLexSlotType_description (45.85s)
--- PASS: TestAccAwsLexSlotType_enumerationValues (47.16s)
--- PASS: TestAccAwsLexSlotType_name (47.87s)

Not supported in GovCloud partitions. #14893 captures requirement for preCheck to skip acceptance tests

[ghost]

This has been released in version 3.5.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[leonfs]

This is great news. @jzbruno Great work on getting the Lex Slot merged and deployed. Hopefully, the other 3 PRs will progress smoothly too.

New Resource: aws_lex_intent #8917
New Resource: aws_lex_bot #8918
New Resource: aws_lex_bot_alias #8919

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!