Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New resource: aws_apigatewayv2_stage #9232

Merged
merged 3 commits into from
Apr 16, 2020
Merged

New resource: aws_apigatewayv2_stage #9232

merged 3 commits into from
Apr 16, 2020

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Jul 3, 2019 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Another resource for #7004.

Release note for CHANGELOG:

FEATURES:

* New Resource: aws_api_gateway_v2_stage (#7004)

Output from acceptance testing:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSAPIGateway2Stage_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -parallel 20 -run=TestAccAWSAPIGateway2Stage_ -timeout 120m
=== RUN   TestAccAWSAPIGateway2Stage_basic
=== PAUSE TestAccAWSAPIGateway2Stage_basic
=== RUN   TestAccAWSAPIGateway2Stage_AccessLogSettings
=== PAUSE TestAccAWSAPIGateway2Stage_AccessLogSettings
=== RUN   TestAccAWSAPIGateway2Stage_ClientCertificateIdAndDescription
=== PAUSE TestAccAWSAPIGateway2Stage_ClientCertificateIdAndDescription
=== RUN   TestAccAWSAPIGateway2Stage_DefaultRouteSettings
=== PAUSE TestAccAWSAPIGateway2Stage_DefaultRouteSettings
=== RUN   TestAccAWSAPIGateway2Stage_Deployment
=== PAUSE TestAccAWSAPIGateway2Stage_Deployment
=== RUN   TestAccAWSAPIGateway2Stage_RouteSettings
=== PAUSE TestAccAWSAPIGateway2Stage_RouteSettings
=== RUN   TestAccAWSAPIGateway2Stage_StageVariables
=== PAUSE TestAccAWSAPIGateway2Stage_StageVariables
=== RUN   TestAccAWSAPIGateway2Stage_Tags
=== PAUSE TestAccAWSAPIGateway2Stage_Tags
=== CONT  TestAccAWSAPIGateway2Stage_basic
=== CONT  TestAccAWSAPIGateway2Stage_Tags
=== CONT  TestAccAWSAPIGateway2Stage_StageVariables
=== CONT  TestAccAWSAPIGateway2Stage_RouteSettings
=== CONT  TestAccAWSAPIGateway2Stage_Deployment
=== CONT  TestAccAWSAPIGateway2Stage_DefaultRouteSettings
=== CONT  TestAccAWSAPIGateway2Stage_ClientCertificateIdAndDescription
=== CONT  TestAccAWSAPIGateway2Stage_AccessLogSettings
--- PASS: TestAccAWSAPIGateway2Stage_basic (31.82s)
--- PASS: TestAccAWSAPIGateway2Stage_RouteSettings (32.55s)
--- PASS: TestAccAWSAPIGateway2Stage_DefaultRouteSettings (37.20s)
--- PASS: TestAccAWSAPIGateway2Stage_Deployment (38.77s)
--- PASS: TestAccAWSAPIGateway2Stage_StageVariables (41.24s)
--- PASS: TestAccAWSAPIGateway2Stage_ClientCertificateIdAndDescription (44.85s)
--- PASS: TestAccAWSAPIGateway2Stage_Tags (46.23s)
--- PASS: TestAccAWSAPIGateway2Stage_AccessLogSettings (84.62s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	84.660s

Currently based on #8842, will need to rebase once that PR is merged.

@ewbankkit ewbankkit requested a review from a team July 3, 2019 21:46
@ghost ghost added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/apigateway Issues and PRs that pertain to the apigateway service. service/apigatewayv2 Issues and PRs that pertain to the apigatewayv2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jul 3, 2019
@ewbankkit ewbankkit mentioned this pull request Jul 3, 2019
Closed
@ewbankkit ewbankkit force-pushed the issue-7004.aws_api_gateway_v2_stage branch from 5bac0bf to 3503217 Compare July 5, 2019 21:39
@ghost ghost added size/XXL Managed by automation to categorize the size of a PR. and removed size/XL Managed by automation to categorize the size of a PR. labels Jul 5, 2019
@ewbankkit ewbankkit force-pushed the issue-7004.aws_api_gateway_v2_stage branch 2 times, most recently from af19738 to 3b622c6 Compare July 10, 2019 20:44
@ewbankkit ewbankkit changed the title [WIP] New resource: aws_api_gateway_v2_stage New resource: aws_api_gateway_v2_stage Jul 11, 2019
@ewbankkit ewbankkit changed the title New resource: aws_api_gateway_v2_stage [WIP] New resource: aws_api_gateway_v2_stage Jul 13, 2019
@ewbankkit

This comment has been minimized.

Sign in to view
@ewbankkit
Copy link
Contributor Author

Includes

@ewbankkit ewbankkit changed the title [WIP] New resource: aws_api_gateway_v2_stage New resource: aws_api_gateway_v2_stage Jul 14, 2019
@ewbankkit ewbankkit mentioned this pull request Jul 23, 2019
Merged
@ewbankkit ewbankkit force-pushed the issue-7004.aws_api_gateway_v2_stage branch from 0745d9f to b633e62 Compare July 28, 2019 20:13
@ewbankkit
Copy link
Contributor Author

Rebased to fix merge conflict.
Acceptance tests:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSAPIGateway2Stage_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -parallel 20 -run=TestAccAWSAPIGateway2Stage_ -timeout 120m
=== RUN   TestAccAWSAPIGateway2Stage_basic
=== PAUSE TestAccAWSAPIGateway2Stage_basic
=== RUN   TestAccAWSAPIGateway2Stage_AccessLogSettings
=== PAUSE TestAccAWSAPIGateway2Stage_AccessLogSettings
=== RUN   TestAccAWSAPIGateway2Stage_ClientCertificateIdAndDescription
=== PAUSE TestAccAWSAPIGateway2Stage_ClientCertificateIdAndDescription
=== RUN   TestAccAWSAPIGateway2Stage_DefaultRouteSettings
=== PAUSE TestAccAWSAPIGateway2Stage_DefaultRouteSettings
=== RUN   TestAccAWSAPIGateway2Stage_Deployment
=== PAUSE TestAccAWSAPIGateway2Stage_Deployment
=== RUN   TestAccAWSAPIGateway2Stage_RouteSettings
=== PAUSE TestAccAWSAPIGateway2Stage_RouteSettings
=== RUN   TestAccAWSAPIGateway2Stage_StageVariables
=== PAUSE TestAccAWSAPIGateway2Stage_StageVariables
=== RUN   TestAccAWSAPIGateway2Stage_Tags
=== PAUSE TestAccAWSAPIGateway2Stage_Tags
=== CONT  TestAccAWSAPIGateway2Stage_basic
=== CONT  TestAccAWSAPIGateway2Stage_Tags
=== CONT  TestAccAWSAPIGateway2Stage_StageVariables
=== CONT  TestAccAWSAPIGateway2Stage_RouteSettings
=== CONT  TestAccAWSAPIGateway2Stage_Deployment
=== CONT  TestAccAWSAPIGateway2Stage_DefaultRouteSettings
=== CONT  TestAccAWSAPIGateway2Stage_ClientCertificateIdAndDescription
=== CONT  TestAccAWSAPIGateway2Stage_AccessLogSettings
--- PASS: TestAccAWSAPIGateway2Stage_RouteSettings (32.88s)
--- PASS: TestAccAWSAPIGateway2Stage_DefaultRouteSettings (38.23s)
--- PASS: TestAccAWSAPIGateway2Stage_Deployment (38.57s)
--- PASS: TestAccAWSAPIGateway2Stage_basic (41.96s)
--- PASS: TestAccAWSAPIGateway2Stage_StageVariables (42.46s)
--- PASS: TestAccAWSAPIGateway2Stage_Tags (45.56s)
--- PASS: TestAccAWSAPIGateway2Stage_ClientCertificateIdAndDescription (46.07s)
--- PASS: TestAccAWSAPIGateway2Stage_AccessLogSettings (64.36s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	64.402s

@ewbankkit ewbankkit mentioned this pull request Jul 28, 2019
Merged
@ewbankkit
Copy link
Contributor Author

Re-ran acceptance tests:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSAPIGateway2Stage_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -parallel 20 -run=TestAccAWSAPIGateway2Stage_ -timeout 120m
=== RUN   TestAccAWSAPIGateway2Stage_basic
=== PAUSE TestAccAWSAPIGateway2Stage_basic
=== RUN   TestAccAWSAPIGateway2Stage_AccessLogSettings
=== PAUSE TestAccAWSAPIGateway2Stage_AccessLogSettings
=== RUN   TestAccAWSAPIGateway2Stage_ClientCertificateIdAndDescription
=== PAUSE TestAccAWSAPIGateway2Stage_ClientCertificateIdAndDescription
=== RUN   TestAccAWSAPIGateway2Stage_DefaultRouteSettings
=== PAUSE TestAccAWSAPIGateway2Stage_DefaultRouteSettings
=== RUN   TestAccAWSAPIGateway2Stage_Deployment
=== PAUSE TestAccAWSAPIGateway2Stage_Deployment
=== RUN   TestAccAWSAPIGateway2Stage_RouteSettings
=== PAUSE TestAccAWSAPIGateway2Stage_RouteSettings
=== RUN   TestAccAWSAPIGateway2Stage_StageVariables
=== PAUSE TestAccAWSAPIGateway2Stage_StageVariables
=== RUN   TestAccAWSAPIGateway2Stage_Tags
=== PAUSE TestAccAWSAPIGateway2Stage_Tags
=== CONT  TestAccAWSAPIGateway2Stage_basic
=== CONT  TestAccAWSAPIGateway2Stage_Tags
=== CONT  TestAccAWSAPIGateway2Stage_StageVariables
=== CONT  TestAccAWSAPIGateway2Stage_RouteSettings
=== CONT  TestAccAWSAPIGateway2Stage_Deployment
=== CONT  TestAccAWSAPIGateway2Stage_DefaultRouteSettings
=== CONT  TestAccAWSAPIGateway2Stage_ClientCertificateIdAndDescription
=== CONT  TestAccAWSAPIGateway2Stage_AccessLogSettings
--- PASS: TestAccAWSAPIGateway2Stage_RouteSettings (27.10s)
--- PASS: TestAccAWSAPIGateway2Stage_Deployment (30.78s)
--- PASS: TestAccAWSAPIGateway2Stage_basic (35.01s)
--- PASS: TestAccAWSAPIGateway2Stage_ClientCertificateIdAndDescription (36.80s)
--- PASS: TestAccAWSAPIGateway2Stage_Tags (43.35s)
--- PASS: TestAccAWSAPIGateway2Stage_StageVariables (43.38s)
--- PASS: TestAccAWSAPIGateway2Stage_DefaultRouteSettings (45.93s)
--- PASS: TestAccAWSAPIGateway2Stage_AccessLogSettings (96.57s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	96.596s

@aeschright aeschright added the new-resource Introduces a new resource. label Aug 19, 2019
@mvisonneau
Copy link

mvisonneau commented Mar 9, 2020 •
edited
Loading

@ewbankkit, would you mind rebasing your branch please? 🙏 🙇

@ewbankkit ewbankkit mentioned this pull request Mar 14, 2020
Closed
@bflad bflad removed the service/apigateway Issues and PRs that pertain to the apigateway service. label Apr 15, 2020
@ewbankkit ewbankkit changed the title New resource: aws_api_gateway_v2_stage New resource: aws_apigatewayv2_stage Apr 16, 2020
@ewbankkit
Copy link
Contributor Author

After merge of #9245, incorporate all the feedback:

  • Migrate to Terraform provider SDK
  • Change resource name to aws_apigatewayv2_blah; Rename source files
  • Remove sidebar_current from documentation
  • Add subcategory: "API Gateway v2 (WebSocket and HTTP APIs)" to documentation
  • Change function names to ApiGatewayV2
  • Add _disappears acceptance test
  • Use multierror in any test sweeper

@ewbankkit ewbankkit force-pushed the issue-7004.aws_api_gateway_v2_stage branch from d686a5c to 28cb8b4 Compare April 16, 2020 12:17
@ewbankkit ewbankkit force-pushed the issue-7004.aws_api_gateway_v2_stage branch 2 times, most recently from 72af617 to 7488f28 Compare April 16, 2020 12:22
@ewbankkit ewbankkit force-pushed the issue-7004.aws_api_gateway_v2_stage branch 2 times, most recently from 32a2ad2 to 2608209 Compare April 16, 2020 14:54
@ewbankkit
Rename resource to 'aws_apigatewayv2_stage'.
0cbee2f 
Acceptance test output:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSAPIGatewayV2Stage_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSAPIGatewayV2Stage_ -timeout 120m
=== RUN   TestAccAWSAPIGatewayV2Stage_basic
=== PAUSE TestAccAWSAPIGatewayV2Stage_basic
=== RUN   TestAccAWSAPIGatewayV2Stage_disappears
=== PAUSE TestAccAWSAPIGatewayV2Stage_disappears
=== RUN   TestAccAWSAPIGatewayV2Stage_AccessLogSettings
=== PAUSE TestAccAWSAPIGatewayV2Stage_AccessLogSettings
=== RUN   TestAccAWSAPIGatewayV2Stage_ClientCertificateIdAndDescription
=== PAUSE TestAccAWSAPIGatewayV2Stage_ClientCertificateIdAndDescription
=== RUN   TestAccAWSAPIGatewayV2Stage_DefaultRouteSettings
=== PAUSE TestAccAWSAPIGatewayV2Stage_DefaultRouteSettings
=== RUN   TestAccAWSAPIGatewayV2Stage_Deployment
=== PAUSE TestAccAWSAPIGatewayV2Stage_Deployment
=== RUN   TestAccAWSAPIGatewayV2Stage_RouteSettings
=== PAUSE TestAccAWSAPIGatewayV2Stage_RouteSettings
=== RUN   TestAccAWSAPIGatewayV2Stage_StageVariables
=== PAUSE TestAccAWSAPIGatewayV2Stage_StageVariables
=== RUN   TestAccAWSAPIGatewayV2Stage_Tags
=== PAUSE TestAccAWSAPIGatewayV2Stage_Tags
=== CONT  TestAccAWSAPIGatewayV2Stage_basic
=== CONT  TestAccAWSAPIGatewayV2Stage_Tags
=== CONT  TestAccAWSAPIGatewayV2Stage_StageVariables
=== CONT  TestAccAWSAPIGatewayV2Stage_RouteSettings
=== CONT  TestAccAWSAPIGatewayV2Stage_Deployment
=== CONT  TestAccAWSAPIGatewayV2Stage_DefaultRouteSettings
=== CONT  TestAccAWSAPIGatewayV2Stage_ClientCertificateIdAndDescription
=== CONT  TestAccAWSAPIGatewayV2Stage_disappears
=== CONT  TestAccAWSAPIGatewayV2Stage_AccessLogSettings
--- PASS: TestAccAWSAPIGatewayV2Stage_disappears (25.76s)
--- PASS: TestAccAWSAPIGatewayV2Stage_RouteSettings (30.12s)
--- PASS: TestAccAWSAPIGatewayV2Stage_basic (31.60s)
--- PASS: TestAccAWSAPIGatewayV2Stage_Deployment (37.39s)
--- PASS: TestAccAWSAPIGatewayV2Stage_DefaultRouteSettings (46.18s)
--- PASS: TestAccAWSAPIGatewayV2Stage_ClientCertificateIdAndDescription (46.37s)
--- PASS: TestAccAWSAPIGatewayV2Stage_Tags (46.58s)
--- PASS: TestAccAWSAPIGatewayV2Stage_StageVariables (47.17s)
--- PASS: TestAccAWSAPIGatewayV2Stage_AccessLogSettings (79.02s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	79.074s
@ewbankkit ewbankkit force-pushed the issue-7004.aws_api_gateway_v2_stage branch from 2608209 to 0cbee2f Compare April 16, 2020 18:50
@ewbankkit
Copy link
Contributor Author

Renamed resource to aws_apigatewayv2_stage.
Re-ran acceptance tests:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSAPIGatewayV2Stage_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSAPIGatewayV2Stage_ -timeout 120m
=== RUN   TestAccAWSAPIGatewayV2Stage_basic
=== PAUSE TestAccAWSAPIGatewayV2Stage_basic
=== RUN   TestAccAWSAPIGatewayV2Stage_disappears
=== PAUSE TestAccAWSAPIGatewayV2Stage_disappears
=== RUN   TestAccAWSAPIGatewayV2Stage_AccessLogSettings
=== PAUSE TestAccAWSAPIGatewayV2Stage_AccessLogSettings
=== RUN   TestAccAWSAPIGatewayV2Stage_ClientCertificateIdAndDescription
=== PAUSE TestAccAWSAPIGatewayV2Stage_ClientCertificateIdAndDescription
=== RUN   TestAccAWSAPIGatewayV2Stage_DefaultRouteSettings
=== PAUSE TestAccAWSAPIGatewayV2Stage_DefaultRouteSettings
=== RUN   TestAccAWSAPIGatewayV2Stage_Deployment
=== PAUSE TestAccAWSAPIGatewayV2Stage_Deployment
=== RUN   TestAccAWSAPIGatewayV2Stage_RouteSettings
=== PAUSE TestAccAWSAPIGatewayV2Stage_RouteSettings
=== RUN   TestAccAWSAPIGatewayV2Stage_StageVariables
=== PAUSE TestAccAWSAPIGatewayV2Stage_StageVariables
=== RUN   TestAccAWSAPIGatewayV2Stage_Tags
=== PAUSE TestAccAWSAPIGatewayV2Stage_Tags
=== CONT  TestAccAWSAPIGatewayV2Stage_basic
=== CONT  TestAccAWSAPIGatewayV2Stage_Deployment
=== CONT  TestAccAWSAPIGatewayV2Stage_Tags
=== CONT  TestAccAWSAPIGatewayV2Stage_StageVariables
=== CONT  TestAccAWSAPIGatewayV2Stage_RouteSettings
=== CONT  TestAccAWSAPIGatewayV2Stage_ClientCertificateIdAndDescription
=== CONT  TestAccAWSAPIGatewayV2Stage_DefaultRouteSettings
=== CONT  TestAccAWSAPIGatewayV2Stage_AccessLogSettings
=== CONT  TestAccAWSAPIGatewayV2Stage_disappears
--- PASS: TestAccAWSAPIGatewayV2Stage_disappears (25.02s)
--- PASS: TestAccAWSAPIGatewayV2Stage_basic (29.68s)
--- PASS: TestAccAWSAPIGatewayV2Stage_Deployment (37.20s)
--- PASS: TestAccAWSAPIGatewayV2Stage_RouteSettings (46.32s)
--- PASS: TestAccAWSAPIGatewayV2Stage_DefaultRouteSettings (47.29s)
--- PASS: TestAccAWSAPIGatewayV2Stage_Tags (47.70s)
--- PASS: TestAccAWSAPIGatewayV2Stage_ClientCertificateIdAndDescription (55.28s)
--- PASS: TestAccAWSAPIGatewayV2Stage_StageVariables (60.01s)
--- PASS: TestAccAWSAPIGatewayV2Stage_AccessLogSettings (73.02s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	73.068s

@ewbankkit
Copy link
Contributor Author

Ready for review.

gdavison
gdavison approved these changes Apr 16, 2020
View reviewed changes
Copy link
Contributor

@gdavison gdavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

--- PASS: TestExpandIPPerms_nonVPC (0.00s)
--- PASS: TestExpandStringList (0.00s)
--- PASS: TestExpandIPPerms_NegOneProtocol (0.00s)
--- PASS: TestExpandIPPerms (0.00s)
--- PASS: TestExpandListeners (0.00s)
--- PASS: TestExpandParameters (0.00s)
--- PASS: TestExpandElasticacheParameters (0.00s)
--- PASS: TestExpandRedshiftParameters (0.00s)
--- PASS: TestExpandStepAdjustments (0.00s)
--- PASS: TestDiffStringMaps (0.00s)
--- PASS: TestExpandStringListEmptyItems (0.00s)
--- PASS: TestFlattenHealthCheck (0.00s)
--- PASS: TestFlattenElasticacheParameters (0.00s)
--- PASS: TestExpandInstanceString (0.00s)
--- PASS: TestFlattenRedshiftParameters (0.00s)
--- PASS: TestFlattenParameters (0.00s)
--- PASS: TestFlattenGroupIdentifiers (0.00s)
--- PASS: TestExpandListeners_invalid (0.00s)
--- PASS: TestFlattenAsgEnabledMetrics (0.00s)
--- PASS: TestFlattenOrganizationsOrganizationalUnits (0.00s)
--- PASS: TestFlattenAttachment (0.00s)
--- PASS: TestFlattenAttachmentWhenNoInstanceId (0.00s)
--- PASS: TestExpandPrivateIPAddresses (0.00s)
--- PASS: TestFlattenNetworkInterfacesPrivateIPAddresses (0.00s)
--- PASS: TestFlattenResourceRecords (0.00s)
--- PASS: TestFlattenResourceRecords/TXT (0.00s)
--- PASS: TestFlattenResourceRecords/SPF (0.00s)
--- PASS: TestFlattenResourceRecords/CNAME (0.00s)
--- PASS: TestFlattenResourceRecords/MX (0.00s)
--- PASS: TestFlattenStepAdjustments (0.00s)
--- PASS: TestFlattenApiGatewayThrottleSettings (0.00s)
--- PASS: TestFlattenPolicyAttributes (0.00s)
--- PASS: TestCheckYamlString (0.00s)
--- PASS: TestExpandPolicyAttributes_empty (0.00s)
--- PASS: TestExpandPolicyAttributes (0.00s)
--- PASS: TestExpandPolicyAttributes_invalid (0.00s)
--- PASS: TestFlattenSecurityGroups (0.00s)
--- PASS: TestNormalizeCloudFormationTemplate (0.00s)
--- PASS: TestExpandRdsClusterScalingConfiguration_basic (0.00s)
--- PASS: TestCognitoUserPoolSchemaAttributeMatchesStandardAttribute (0.00s)
--- PASS: TestExpandRdsClusterScalingConfiguration_serverless (0.00s)
--- PASS: TestCanonicalXML (0.00s)
--- PASS: TestCanonicalXML/Config_sample_from_MSDN (0.00s)
--- PASS: TestCanonicalXML/Config_sample_from_MSDN,_modified (0.00s)
--- PASS: TestCanonicalXML/Config_sample_from_MSDN,_flaw (0.00s)
--- PASS: TestCanonicalXML/A_note (0.00s)
--- PASS: TestFlattenKinesisShardLevelMetrics (0.00s)
--- PASS: TestAccAWSAPIGatewayV2Stage_disappears (10.52s)
--- PASS: TestAccAWSAPIGatewayV2Stage_basic (12.27s)
--- PASS: TestAccAWSAPIGatewayV2Stage_Deployment (13.32s)
--- PASS: TestAccAWSAPIGatewayV2Stage_ClientCertificateIdAndDescription (19.04s)
--- PASS: TestAccAWSAPIGatewayV2Stage_StageVariables (18.93s)
--- PASS: TestAccAWSAPIGatewayV2Stage_DefaultRouteSettings (19.73s)
--- PASS: TestAccAWSAPIGatewayV2Stage_Tags (27.26s)
--- PASS: TestAccAWSAPIGatewayV2Stage_RouteSettings (29.56s)
--- PASS: TestAccAWSAPIGatewayV2Stage_AccessLogSettings (65.33s)

@gdavison gdavison added this to the v2.58.0 milestone Apr 16, 2020
@gdavison gdavison merged commit 124b9ed into hashicorp:master Apr 16, 2020
gdavison added a commit that referenced this pull request Apr 16, 2020
@gdavison
Update CHANGELOG for #9232
d7747df
@ghost
Copy link

ghost commented Apr 17, 2020

This has been released in version 2.58.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ewbankkit ewbankkit deleted the issue-7004.aws_api_gateway_v2_stage branch April 17, 2020 11:42
@LaurenceGA LaurenceGA mentioned this pull request Apr 20, 2020
Closed
@ewbankkit ewbankkit mentioned this pull request Apr 22, 2020
Open
@ghost
Copy link

ghost commented May 17, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators May 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gdavison gdavison gdavison approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/apigatewayv2 Issues and PRs that pertain to the apigatewayv2 service. size/XXL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v2.58.0
Development

Successfully merging this pull request may close these issues.
5 participants
@ewbankkit @mvisonneau @gdavison @aeschright @bflad