Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/aws_ssm_maintenance_window_task: Prevent task_parameters ordering differences #9364

Merged

Commits on Jul 16, 2019

  1. resource/aws_ssm_maintenance_window_task: Prevent task_parameters o…

    …rdering differences
    
    Reference: #3218
    
    Previously (before code update):
    
    ```
    --- FAIL: TestAccAWSSSMMaintenanceWindowTask_TaskParameters (12.95s)
        testing.go:568: Step 0 error: After applying this step, the plan was not empty:
    
            DIFF:
    
            UPDATE: aws_ssm_maintenance_window_task.test
    ...
              task_parameters.#:            "3" => "3"
              task_parameters.0.name:       "commandLine" => "sourceType"
              task_parameters.0.values.#:   "1" => "1"
              task_parameters.0.values.0:   "date" => "s3"
              task_parameters.1.name:       "sourceInfo" => "sourceInfo"
              task_parameters.1.values.#:   "1" => "1"
              task_parameters.1.values.0:   "https://s3.amazonaws.com/bucket" => "https://s3.amazonaws.com/bucket"
              task_parameters.2.name:       "sourceType" => "commandLine"
              task_parameters.2.values.#:   "1" => "1"
              task_parameters.2.values.0:   "s3" => "date"
    ```
    
    Output from acceptance testing:
    
    ```
    --- PASS: TestAccAWSSSMMaintenanceWindowTask_TaskParameters (18.13s)
    --- PASS: TestAccAWSSSMMaintenanceWindowTask_TaskInvocationStepFunctionParameters (126.33s)
    --- PASS: TestAccAWSSSMMaintenanceWindowTask_basic (127.14s)
    --- PASS: TestAccAWSSSMMaintenanceWindowTask_updateForcesNewResource (157.65s)
    --- PASS: TestAccAWSSSMMaintenanceWindowTask_TaskInvocationRunCommandParameters (158.38s)
    --- PASS: TestAccAWSSSMMaintenanceWindowTask_TaskInvocationAutomationParameters (178.09s)
    --- PASS: TestAccAWSSSMMaintenanceWindowTask_TaskInvocationLambdaParameters (233.40s)
    ```
    bflad committed Jul 16, 2019
    Configuration menu
    Copy the full SHA
    9a46c52 View commit details
    Browse the repository at this point in the history