Final retries for LB resources

[ryndaniels]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates #7873

Release note for CHANGELOG:

BUG FIXES
* resource/aws_lb: Final retry after timeout waiting for network interfaces to detach
* resource/aws_lb_listener_certificate: Final retry after timeout reading listener certificate
* resource/aws_lb_listener_rule: Final retries after timeout reading and creating listener rules

Output from acceptance testing:

$ make testacc TESTARGS="-run=TestAccAWSLB_ALB"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSLB_ALB -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSLB_ALB_basic
=== PAUSE TestAccAWSLB_ALB_basic
=== RUN   TestAccAWSLB_ALB_AccessLogs
=== PAUSE TestAccAWSLB_ALB_AccessLogs
=== RUN   TestAccAWSLB_ALB_AccessLogs_Prefix
=== PAUSE TestAccAWSLB_ALB_AccessLogs_Prefix
=== CONT  TestAccAWSLB_ALB_basic
=== CONT  TestAccAWSLB_ALB_AccessLogs_Prefix
=== CONT  TestAccAWSLB_ALB_AccessLogs
--- PASS: TestAccAWSLB_ALB_basic (244.69s)
--- PASS: TestAccAWSLB_ALB_AccessLogs_Prefix (431.42s)
--- PASS: TestAccAWSLB_ALB_AccessLogs (495.25s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       496.367s

make testacc TESTARGS="-run=TestAccAwsLbListenerCertificate"      
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAwsLbListenerCertificate -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAwsLbListenerCertificate_basic
=== PAUSE TestAccAwsLbListenerCertificate_basic
=== RUN   TestAccAwsLbListenerCertificate_cycle
=== PAUSE TestAccAwsLbListenerCertificate_cycle
=== CONT  TestAccAwsLbListenerCertificate_basic
=== CONT  TestAccAwsLbListenerCertificate_cycle
--- PASS: TestAccAwsLbListenerCertificate_basic (268.32s)
--- PASS: TestAccAwsLbListenerCertificate_cycle (376.76s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       377.916s

 make testacc TESTARGS="-run=TestAccAWSLBListenerRule"       
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSLBListenerRule -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSLBListenerRule_basic
=== PAUSE TestAccAWSLBListenerRule_basic
=== RUN   TestAccAWSLBListenerRuleBackwardsCompatibility
=== PAUSE TestAccAWSLBListenerRuleBackwardsCompatibility
=== RUN   TestAccAWSLBListenerRule_redirect
=== PAUSE TestAccAWSLBListenerRule_redirect
=== RUN   TestAccAWSLBListenerRule_fixedResponse
=== PAUSE TestAccAWSLBListenerRule_fixedResponse
=== RUN   TestAccAWSLBListenerRule_updateRulePriority
=== PAUSE TestAccAWSLBListenerRule_updateRulePriority
=== RUN   TestAccAWSLBListenerRule_changeListenerRuleArnForcesNew
=== PAUSE TestAccAWSLBListenerRule_changeListenerRuleArnForcesNew
=== RUN   TestAccAWSLBListenerRule_multipleConditionThrowsError
=== PAUSE TestAccAWSLBListenerRule_multipleConditionThrowsError
=== RUN   TestAccAWSLBListenerRule_priority
=== PAUSE TestAccAWSLBListenerRule_priority
=== RUN   TestAccAWSLBListenerRule_cognito
=== PAUSE TestAccAWSLBListenerRule_cognito
=== RUN   TestAccAWSLBListenerRule_oidc
=== PAUSE TestAccAWSLBListenerRule_oidc
=== RUN   TestAccAWSLBListenerRule_Action_Order
=== PAUSE TestAccAWSLBListenerRule_Action_Order
=== RUN   TestAccAWSLBListenerRule_Action_Order_Recreates
=== PAUSE TestAccAWSLBListenerRule_Action_Order_Recreates
=== CONT  TestAccAWSLBListenerRule_basic
=== CONT  TestAccAWSLBListenerRule_cognito
=== CONT  TestAccAWSLBListenerRuleBackwardsCompatibility
=== CONT  TestAccAWSLBListenerRule_updateRulePriority
=== CONT  TestAccAWSLBListenerRule_priority
=== CONT  TestAccAWSLBListenerRule_Action_Order
=== CONT  TestAccAWSLBListenerRule_oidc
=== CONT  TestAccAWSLBListenerRule_fixedResponse
=== CONT  TestAccAWSLBListenerRule_redirect
=== CONT  TestAccAWSLBListenerRule_multipleConditionThrowsError
=== CONT  TestAccAWSLBListenerRule_changeListenerRuleArnForcesNew
=== CONT  TestAccAWSLBListenerRule_Action_Order_Recreates
--- PASS: TestAccAWSLBListenerRule_multipleConditionThrowsError (3.43s)
--- PASS: TestAccAWSLBListenerRuleBackwardsCompatibility (241.60s)
--- PASS: TestAccAWSLBListenerRule_fixedResponse (250.10s)
--- PASS: TestAccAWSLBListenerRule_cognito (251.40s)
--- PASS: TestAccAWSLBListenerRule_oidc (251.95s)
--- PASS: TestAccAWSLBListenerRule_basic (260.68s)
--- PASS: TestAccAWSLBListenerRule_Action_Order (263.79s)
--- PASS: TestAccAWSLBListenerRule_redirect (295.22s)
--- PASS: TestAccAWSLBListenerRule_Action_Order_Recreates (305.41s)
--- PASS: TestAccAWSLBListenerRule_changeListenerRuleArnForcesNew (343.01s)
--- PASS: TestAccAWSLBListenerRule_updateRulePriority (365.65s)
--- PASS: TestAccAWSLBListenerRule_priority (595.01s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       596.267s

[bflad]

LGTM 🚀

--- PASS: TestAccAWSLBListenerRule_multipleConditionThrowsError (4.57s)
--- PASS: TestAccAWSLBCookieStickinessPolicy_basic (24.57s)
--- PASS: TestAccAWSLBCookieStickinessPolicy_drift (25.29s)
--- PASS: TestAccAWSLBCookieStickinessPolicy_missingLB (29.81s)
--- PASS: TestAccAWSLBListenerRule_Action_Order (186.83s)
--- PASS: TestAccAWSLBListener_BackwardsCompatibility (195.80s)
--- PASS: TestAccAWSLBListener_redirect (180.51s)
--- PASS: TestAccAWSLBListenerRuleBackwardsCompatibility (207.90s)
--- PASS: TestAccAWSLBListenerRule_changeListenerRuleArnForcesNew (213.92s)
--- PASS: TestAccAWSLBListener_basic (216.67s)
--- PASS: TestAccAWSLBListenerRule_Action_Order_Recreates (226.69s)
--- PASS: TestAccAWSLBListener_Protocol_Tls (211.34s)
--- PASS: TestAccAWSLBSSLNegotiationPolicy_basic (22.70s)
--- PASS: TestAccAWSLBListenerRule_basic (250.88s)
--- PASS: TestAccAWSLBListenerRule_redirect (258.14s)
--- PASS: TestAccAWSLBListenerRule_updateRulePriority (260.14s)
--- PASS: TestAccAWSLBTargetGroup_basic (9.46s)
--- PASS: TestAccAWSLBTargetGroup_basicUdp (9.38s)
--- PASS: TestAccAWSLBTargetGroup_withoutHealthcheck (9.03s)
--- PASS: TestAccAWSLBListenerRule_fixedResponse (276.44s)
--- PASS: TestAccAWSLBSSLNegotiationPolicy_missingLB (63.55s)
--- PASS: TestAccAWSLBTargetGroup_Protocol_Tls (11.36s)
--- PASS: TestAccAWSLBTargetGroupAttachment_lambda (30.22s)
--- PASS: TestAccAWSLBListener_basicUdp (289.59s)
--- PASS: TestAccAWSLBListener_fixedResponse (265.68s)
--- PASS: TestAccAWSLBTargetGroup_networkLB_TargetGroupWithProxy (19.15s)
--- PASS: TestAccAWSLBTargetGroup_networkLB_TargetGroup (26.30s)
--- PASS: TestAccAWSLBTargetGroupAttachment_basic (71.28s)
--- PASS: TestAccAWSLBTargetGroup_namePrefix (10.28s)
--- PASS: TestAccAWSLBListenerRule_priority (298.69s)
--- PASS: TestAccAWSLBTargetGroup_TCP_HTTPHealthCheck (19.67s)
--- PASS: TestAccAWSLBTargetGroup_generatedName (12.66s)
--- PASS: TestAccAWSLBTargetGroupBackwardsCompatibility (14.52s)
--- PASS: TestAccAWSLBTargetGroupAttachment_disappears (71.66s)
--- PASS: TestAccAWSLBListener_https (306.86s)
--- PASS: TestAccAwsLbListenerCertificate_basic (313.97s)
--- PASS: TestAccAWSLBTargetGroup_stickinessWithTCPEnabledShouldError (3.83s)
--- PASS: TestAccAWSLBTargetGroup_defaults_application (20.76s)
--- PASS: TestAccAWSLBTargetGroup_changeProtocolForceNew (27.50s)
--- PASS: TestAccAWSLBTargetGroup_changeVpcForceNew (26.96s)
--- PASS: TestAccAWSLBTargetGroup_changePortForceNew (31.18s)
--- PASS: TestAccAWSLBTargetGroup_enableHealthCheck (37.27s)
--- PASS: TestAccAWSLBTargetGroup_tags (38.68s)
--- PASS: TestAccAWSLBTargetGroup_stickinessWithTCPDisabled (25.52s)
--- PASS: TestAccAWSLBTargetGroup_updateHealthCheck (37.86s)
--- PASS: TestAccAWSLBTargetGroup_changeNameForceNew (44.79s)
--- PASS: TestAccAWSLBTargetGroup_defaults_network (34.39s)
--- PASS: TestAccAWSLBTargetGroup_updateSticknessEnabled (42.10s)
--- PASS: TestAccAWSLBTargetGroupAttachment_withoutPort (101.74s)
--- PASS: TestAccAWSLBListenerRule_oidc (346.20s)
--- PASS: TestAccAwsLbListenerCertificate_cycle (374.70s)
--- PASS: TestAccAWSLBListener_DefaultAction_Order_Recreates (180.82s)
--- PASS: TestAccAWSLBListener_oidc (192.68s)
--- PASS: TestAccAWSLBListener_DefaultAction_Order (192.16s)
--- PASS: TestAccAWSLBListener_cognito (218.69s)
--- PASS: TestAccAWSLBListenerRule_cognito (419.97s)
--- PASS: TestAccAWSLB_ALB_basic (181.31s)
--- PASS: TestAccAWSLB_generatesNameForZeroValue (190.46s)
--- PASS: TestAccAWSLB_NLB_basic (207.09s)
--- PASS: TestAccAWSLB_generatedName (204.87s)
--- PASS: TestAccAWSLB_namePrefix (203.84s)
--- PASS: TestAccAWSLB_networkLoadbalancerEIP (229.86s)
--- PASS: TestAccAWSLB_noSecurityGroup (188.57s)
--- PASS: TestAccAWSLB_tags (227.87s)
--- PASS: TestAccAWSLB_updatedSecurityGroups (228.31s)
--- PASS: TestAccAWSLBBackwardsCompatibility (270.60s)
--- PASS: TestAccAWSLB_updatedIpAddressType (267.64s)
--- PASS: TestAccAWSLB_applicationLoadBalancer_updateDeletionProtection (273.05s)
--- PASS: TestAccAWSLB_applicationLoadBalancer_updateHttp2 (307.06s)
--- PASS: TestAccAWSLB_networkLoadbalancer_updateCrossZone (311.07s)
--- PASS: TestAccAWSLB_ALB_AccessLogs_Prefix (273.47s)
--- PASS: TestAccAWSLB_networkLoadbalancer_subnet_change (247.08s)
--- PASS: TestAccAWSLB_ALB_AccessLogs (301.15s)
--- PASS: TestAccAWSLB_NLB_AccessLogs_Prefix (344.11s)
--- PASS: TestAccAWSLB_NLB_AccessLogs (401.11s)

[ghost]

This has been released in version 2.25.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!