Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix retiring_principal argument name for aws_kms_grant resource #9819

Merged
merged 1 commit into from
Aug 27, 2019

Conversation

fbreckle
Copy link
Contributor

The documentation for the aws_kms_grant resource mistakenly shows retiree_principal instead of the correct argument retiring_principal.
Using retiree_principal results in an Error: Unsupported argument.

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Release note for CHANGELOG:

* resource/aws_kms_grant: Fix documentation to match provider code.

@fbreckle fbreckle requested a review from a team August 19, 2019 15:01
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. service/kms Issues and PRs that pertain to the kms service. documentation Introduces or discusses updates to documentation. labels Aug 19, 2019
@ryndaniels ryndaniels self-assigned this Aug 26, 2019
Copy link
Contributor

@ryndaniels ryndaniels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks @fbreckle! 👍

@ryndaniels ryndaniels added this to the v2.26.0 milestone Aug 27, 2019
@ryndaniels ryndaniels merged commit 72e690b into hashicorp:master Aug 27, 2019
@ghost
Copy link

ghost commented Aug 29, 2019

This has been released in version 2.26.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Nov 1, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/kms Issues and PRs that pertain to the kms service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants