Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Acceptance test import refactor for service resources #9963

Merged
merged 1 commit into from
Sep 5, 2019

Conversation

ryndaniels
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates #8944

Release note for CHANGELOG:

NONE

Output from acceptance testing:

$ make testacc TESTARGS="-run=TestAccAWSServiceDiscoveryService"        
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSServiceDiscoveryService -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSServiceDiscoveryService_private
=== PAUSE TestAccAWSServiceDiscoveryService_private
=== RUN   TestAccAWSServiceDiscoveryService_public
=== PAUSE TestAccAWSServiceDiscoveryService_public
=== RUN   TestAccAWSServiceDiscoveryService_http
=== PAUSE TestAccAWSServiceDiscoveryService_http
=== CONT  TestAccAWSServiceDiscoveryService_private
=== CONT  TestAccAWSServiceDiscoveryService_http
=== CONT  TestAccAWSServiceDiscoveryService_public
--- PASS: TestAccAWSServiceDiscoveryService_http (108.73s)
--- PASS: TestAccAWSServiceDiscoveryService_public (138.16s)
--- PASS: TestAccAWSServiceDiscoveryService_private (168.48s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       170.671s

make testacc TESTARGS="-run=TestAccAWSServiceCatalogPortfolio"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSServiceCatalogPortfolio -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSServiceCatalogPortfolio_Basic
=== PAUSE TestAccAWSServiceCatalogPortfolio_Basic
=== RUN   TestAccAWSServiceCatalogPortfolio_Disappears
=== PAUSE TestAccAWSServiceCatalogPortfolio_Disappears
=== CONT  TestAccAWSServiceCatalogPortfolio_Basic
=== CONT  TestAccAWSServiceCatalogPortfolio_Disappears
--- PASS: TestAccAWSServiceCatalogPortfolio_Disappears (20.11s)
--- PASS: TestAccAWSServiceCatalogPortfolio_Basic (62.93s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       63.766s

@ryndaniels ryndaniels requested a review from a team September 2, 2019 15:55
@ghost ghost added size/L Managed by automation to categorize the size of a PR. service/servicediscovery Issues and PRs that pertain to the servicediscovery service. service/servicecatalog Issues and PRs that pertain to the servicecatalog service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Sep 2, 2019
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

--- PASS: TestAccAWSServiceCatalogPortfolio_Disappears (7.29s)
--- PASS: TestAccAWSServiceCatalogPortfolio_Basic (19.49s)
--- PASS: TestAccAWSServiceDiscoveryService_private (101.18s)
--- PASS: TestAccAWSServiceDiscoveryService_public (108.58s)

@ryndaniels ryndaniels added this to the v2.27.0 milestone Sep 5, 2019
@ryndaniels ryndaniels merged commit 636a0ea into master Sep 5, 2019
@ryndaniels ryndaniels deleted the rfd-at002-service branch September 5, 2019 08:58
@ghost
Copy link

ghost commented Sep 5, 2019

This has been released in version 2.27.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Nov 1, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/servicecatalog Issues and PRs that pertain to the servicecatalog service. service/servicediscovery Issues and PRs that pertain to the servicediscovery service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants