Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azuread_application: support ignore_changes lifecycle argument #1403

Merged
merged 3 commits into from
Jun 13, 2024

Conversation

manicminer
Copy link
Contributor

@manicminer manicminer commented Jun 10, 2024

Support ignore_changes lifecycle argument for app_role, oauth2_permission_scope, identifier_uris, optional_claims, and required_resource_access

Fixes: #1344

Screenshot 2024-06-10 at 19 10 03

…`app_role`, `oauth2_permission_scope`, `identifier_uris`, `optional_claims`, and `required_resource_access`
@github-actions github-actions bot added size/M and removed size/S labels Jun 10, 2024
Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@manicminer manicminer merged commit 5f41456 into main Jun 13, 2024
25 checks passed
@manicminer manicminer deleted the bugfix/application-ignore-changes branch June 13, 2024 20:25
@github-actions github-actions bot added this to the v2.52.0 milestone Jun 13, 2024
manicminer added a commit that referenced this pull request Jun 13, 2024
dduportal pushed a commit to jenkins-infra/azure that referenced this pull request Jun 18, 2024
<Actions>
<action
id="6d17e7acdb2f3311576150379e22805f2f9b4aa72ff00ec136aceee45cae4b98">
        <h3>Bump Terraform `azuread` provider version</h3>
<details
id="1d9343c012f5434ac9fe8a98135bae3667b399259be16d9b14302ea3bd424a24">
            <summary>Update Terraform lock file</summary>
<p>changes detected:&#xA;&#x9;&#34;hashicorp/azuread&#34; updated from
&#34;2.51.0&#34; to &#34;2.52.0&#34; in file
&#34;.terraform.lock.hcl&#34;</p>
            <details>
                <summary>2.52.0</summary>
<pre>Changelog retrieved
from:&#xA;&#x9;https://github.com/hashicorp/terraform-provider-azuread/releases/tag/v2.52.0&#xA;BUG
FIXES:&#xA;&#xA;* `azuread_application` - fix a bug that could prevent
the `ignore_changes` lifecycle argument from working for the `app_role`,
`oauth2_permission_scope`, `identifier_uris`, `optional_claims`, and
`required_resource_access` properties
([#1403](hashicorp/terraform-provider-azuread#1403
`azuread_application` - add a workaround for an API bug when
instantiating an application from template using the `template_id`
property
([#1406](https://github.com/hashicorp/terraform-provider-azuread/issues/1406))&#xA;&#xA;&#xA;</pre>
            </details>
        </details>
<a
href="https://infra.ci.jenkins.io/job/updatecli/job/azure/job/main/245/">Jenkins
pipeline link</a>
    </action>
</Actions>

---

<table>
  <tr>
    <td width="77">
<img src="https://www.updatecli.io/images/updatecli.png" alt="Updatecli
logo" width="50" height="50">
    </td>
    <td>
      <p>
Created automatically by <a
href="https://www.updatecli.io/">Updatecli</a>
      </p>
      <details><summary>Options:</summary>
        <br />
<p>Most of Updatecli configuration is done via <a
href="https://www.updatecli.io/docs/prologue/quick-start/">its
manifest(s)</a>.</p>
        <ul>
<li>If you close this pull request, Updatecli will automatically reopen
it, the next time it runs.</li>
<li>If you close this pull request and delete the base branch, Updatecli
will automatically recreate it, erasing all previous commits made.</li>
        </ul>
        <p>
Feel free to report any issues at <a
href="https://github.com/updatecli/updatecli/issues">github.com/updatecli/updatecli</a>.<br
/>
If you find this tool useful, do not hesitate to star <a
href="https://github.com/updatecli/updatecli/stargazers">our GitHub
repository</a> as a sign of appreciation, and/or to tell us directly on
our <a
href="https://matrix.to/#/#Updatecli_community:gitter.im">chat</a>!
        </p>
      </details>
    </td>
  </tr>
</table>

Co-authored-by: Jenkins Infra Bot (updatecli) <60776566+jenkins-infra-bot@users.noreply.github.com>
BrendanThompson pushed a commit to BrendanThompson/terraform-provider-azuread that referenced this pull request Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ignore_changes does not ignore app_role block on azuread_application
2 participants