Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: timeouts and notes on restrictive API limits #1419

Merged
merged 4 commits into from
Jun 26, 2024

Conversation

manicminer
Copy link
Contributor

@manicminer manicminer commented Jun 26, 2024

  • Ensure timeouts are documented for all resources, and all resources have correct timeouts
  • Remove use of deprecated application_id (renamed to client_id) from examples
  • Add info notes about restrictive API limits for azuread_conditional_access_policy and azuread_named_location
Screenshot 2024-06-26 at 19 07 10

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⏳

@manicminer manicminer merged commit cc808a9 into main Jun 26, 2024
27 checks passed
@manicminer manicminer deleted the docs/timeouts-and-api-limits branch June 26, 2024 20:02
@github-actions github-actions bot added this to the v2.53.0 milestone Jun 26, 2024
manicminer added a commit that referenced this pull request Jun 26, 2024
dduportal pushed a commit to jenkins-infra/azure that referenced this pull request Jun 28, 2024
<Actions>
<action
id="6d17e7acdb2f3311576150379e22805f2f9b4aa72ff00ec136aceee45cae4b98">
        <h3>Bump Terraform `azuread` provider version</h3>
<details
id="1d9343c012f5434ac9fe8a98135bae3667b399259be16d9b14302ea3bd424a24">
            <summary>Update Terraform lock file</summary>
<p>changes detected:&#xA;&#x9;&#34;hashicorp/azuread&#34; updated from
&#34;2.52.0&#34; to &#34;2.53.0&#34; in file
&#34;.terraform.lock.hcl&#34;</p>
            <details>
                <summary>2.53.0</summary>
<pre>Changelog retrieved
from:&#xA;&#x9;https://github.com/hashicorp/terraform-provider-azuread/releases/tag/v2.53.0&#xA;ENHANCEMENTS:&#xA;&#xA;*
`azuread_application` - support for the `password` block
([#1389](https://github.com/hashicorp/terraform-provider-azuread/issues/1389))&#xA;&#xA;BUG
FIXES:&#xA;&#xA;* `azuread_claims_mapping_policy` - set the correct
timeouts for this resource
([#1419](hashicorp/terraform-provider-azuread#1419
`azuread_service_principal_claims_mapping_policy_assignment` - set the
correct timeouts for this resource
([#1419](hashicorp/terraform-provider-azuread#1419
`azuread_synchronization_secret` - set the correct timeouts for this
resource
([#1419](https://github.com/hashicorp/terraform-provider-azuread/issues/1419))&#xA;&#xA;&#xA;</pre>
            </details>
        </details>
<a
href="https://infra.ci.jenkins.io/job/updatecli/job/azure/job/main/286/">Jenkins
pipeline link</a>
    </action>
</Actions>

---

<table>
  <tr>
    <td width="77">
<img src="https://www.updatecli.io/images/updatecli.png" alt="Updatecli
logo" width="50" height="50">
    </td>
    <td>
      <p>
Created automatically by <a
href="https://www.updatecli.io/">Updatecli</a>
      </p>
      <details><summary>Options:</summary>
        <br />
<p>Most of Updatecli configuration is done via <a
href="https://www.updatecli.io/docs/prologue/quick-start/">its
manifest(s)</a>.</p>
        <ul>
<li>If you close this pull request, Updatecli will automatically reopen
it, the next time it runs.</li>
<li>If you close this pull request and delete the base branch, Updatecli
will automatically recreate it, erasing all previous commits made.</li>
        </ul>
        <p>
Feel free to report any issues at <a
href="https://github.com/updatecli/updatecli/issues">github.com/updatecli/updatecli</a>.<br
/>
If you find this tool useful, do not hesitate to star <a
href="https://github.com/updatecli/updatecli/stargazers">our GitHub
repository</a> as a sign of appreciation, and/or to tell us directly on
our <a
href="https://matrix.to/#/#Updatecli_community:gitter.im">chat</a>!
        </p>
      </details>
    </td>
  </tr>
</table>

Co-authored-by: Jenkins Infra Bot (updatecli) <60776566+jenkins-infra-bot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment