-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP : feat(guest-user) #297
Conversation
@Maarc-D Many thanks for opening this PR and for making headway towards MS Graph support in the SDK. Your efforts are greatly appreciated. We are however heading in a different direction and won't be pursuing MS Graph support for Azure-sdk-for-go. We're currently readying a major release for AzureAD (see #298) which lays the groundwork for MS Graph support as a next phase, and we hope to make it easier to build in new features in future. As such, we won't be merging this. Guest user invitations are a core feature that we'd like to support as early as we can. I have opened #307 to track this and I encourage you (and anyone else reading this) to upvote that issue if it's important to you. Thanks again for your contribution. I'm sorry in this case that we won't be able to adopt this work. If you are not already a member of our contributor Slack workspace, you are most welcome to join. You can find an invitation link in the AzureRM readme. |
Ok, but the Implementation I did work and is in used in our production account because we really need this (more that 1000 guest to managed on each differents tenants (partners and customers dedicated) and we have no other solution right now. I'll follow your new implementation after my holiday come back. for information the code used with the provider of my fork : resource "azuread_guest_user" "toto1" {
mail = "toto1@company.com"
display_name = "TOTO 1"
}
resource "azuread_guest_user" "toto2" {
mail = "toto2@company.com"
display_name = "TOTO 2"
}
resource "azuread_guest_user" "toto3" {
mail = "toto3@company.com"
display_name = "TOTO 3"
}
[...]
resource "azuread_group" "application-manager" {
name = "APPLICATION-MANAGER"
}
[...]
resource "azuread_group_member" "application-manager_tot1" {
group_object_id = azuread_group.application-manager.id
member_object_id = azuread_guest_user.toto1.id
}
[...] and we have not any issue for creation update and delete, but you need the right API permission on your app registration if you are using it, writed in the documentation. I hope your new strategy will be not a nightmare to implement as this one could be when you really don't know the process on each dependencies like me, it take a moment to understant everything ;). |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
Description
Aim of this is to be able to manage guest user using terraform
Related Issues
#41
Usefull links
Azure/azure-rest-api-specs#10275