Merge pull request #15948 from hashicorp/kt/delete-on-destroy-default

feature log_analytics_workspace/permanently_delete_on_destroy defaults to true
hashicorp · Mar 23, 2022 · 4f0cbb8 · 4f0cbb8
2 parents a257990 + e13405d
commit 4f0cbb8
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/internal/provider/features.go b/internal/provider/features.go
@@ -73,7 +73,8 @@ func schemaFeatures(supportLegacyTestSuite bool) *pluginsdk.Schema {
 				Schema: map[string]*pluginsdk.Schema{
 					"permanently_delete_on_destroy": {
 						Type:     pluginsdk.TypeBool,
-						Required: true,
+						Optional: true,
+						Default:  true,
 					},
 				},
 			},

diff --git a/website/docs/guides/features-block.html.markdown b/website/docs/guides/features-block.html.markdown
@@ -118,7 +118,7 @@ The `key_vault` block supports the following:
 
 The `log_analytics_workspace` block supports the following:
 
-* `permanently_delete_on_destroy` - (Optional) Should the `azurerm_log_analytics_workspace` be permanently deleted (e.g. purged) when destroyed? Defaults to `false`.
+* `permanently_delete_on_destroy` - (Optional) Should the `azurerm_log_analytics_workspace` be permanently deleted (e.g. purged) when destroyed? Defaults to `true`.
 
 ---
-Original file line number
+Diff line change
@@ Expand Up / @@ -118,7 +118,7 @@ The `key_vault` block supports the following: @@
     The `log_analytics_workspace` block supports the following:
-    * `permanently_delete_on_destroy` - (Optional) Should the `azurerm_log_analytics_workspace` be permanently deleted (e.g. purged) when destroyed? Defaults to `false`.
+    * `permanently_delete_on_destroy` - (Optional) Should the `azurerm_log_analytics_workspace` be permanently deleted (e.g. purged) when destroyed? Defaults to `true`.
     ---
@@ Expand Down @@