Skip to content

Commit

Permalink
CUD method/timeout consistency across code and doc (#23796)
Browse files Browse the repository at this point in the history
  • Loading branch information
magodo authored Nov 24, 2023
1 parent 46cacb4 commit 6815d73
Show file tree
Hide file tree
Showing 105 changed files with 22 additions and 130 deletions.
12 changes: 6 additions & 6 deletions internal/provider/provider_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -80,11 +80,11 @@ func TestResourcesSupportCustomTimeouts(t *testing.T) {
// every Resource has to have a Create, Read & Destroy timeout

//lint:ignore SA1019 SDKv2 migration - staticcheck's own linter directives are currently being ignored under golanci-lint
if resource.Timeouts.Create == nil && resource.Create != nil { //nolint:staticcheck
t.Fatalf("Resource %q defines a Create method but no Create Timeout", resourceName)
if (resource.Timeouts.Create == nil) != (resource.Create == nil && resource.CreateContext == nil) { //nolint:staticcheck
t.Fatalf("Resource %q should define/not define the Create(Context) method and the Create Timeout at the same time", resourceName)
}
if resource.Timeouts.Delete == nil && resource.Delete != nil { //nolint:staticcheck
t.Fatalf("Resource %q defines a Delete method but no Delete Timeout", resourceName)
if (resource.Timeouts.Delete == nil) != (resource.Delete == nil && resource.DeleteContext == nil) { //nolint:staticcheck
t.Fatalf("Resource %q should define/not define the Delete(Context) method and the Delete Timeout at the same time", resourceName)
}
if resource.Timeouts.Read == nil {
t.Fatalf("Resource %q doesn't define a Read timeout", resourceName)
Expand All @@ -101,8 +101,8 @@ func TestResourcesSupportCustomTimeouts(t *testing.T) {
}

// Optional
if resource.Timeouts.Update == nil && resource.Update != nil { //nolint:staticcheck
t.Fatalf("Resource %q defines a Update method but no Update Timeout", resourceName)
if (resource.Timeouts.Update == nil) != (resource.Update == nil && resource.UpdateContext == nil) { //nolint:staticcheck
t.Fatalf("Resource %q should define/not define the Update(Context) method and the Update Timeout at the same time", resourceName)
}
})
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@ func resourceApiManagementGatewayApi() *pluginsdk.Resource {
Timeouts: &pluginsdk.ResourceTimeout{
Create: pluginsdk.DefaultTimeout(30 * time.Minute),
Read: pluginsdk.DefaultTimeout(5 * time.Minute),
Update: pluginsdk.DefaultTimeout(30 * time.Minute),
Delete: pluginsdk.DefaultTimeout(30 * time.Minute),
},

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ func resourceApiManagementGroupUser() *pluginsdk.Resource {
Timeouts: &pluginsdk.ResourceTimeout{
Create: pluginsdk.DefaultTimeout(30 * time.Minute),
Read: pluginsdk.DefaultTimeout(5 * time.Minute),
Update: pluginsdk.DefaultTimeout(30 * time.Minute),
Delete: pluginsdk.DefaultTimeout(30 * time.Minute),
},

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ func resourceApiManagementProductApi() *pluginsdk.Resource {
Timeouts: &pluginsdk.ResourceTimeout{
Create: pluginsdk.DefaultTimeout(30 * time.Minute),
Read: pluginsdk.DefaultTimeout(5 * time.Minute),
Update: pluginsdk.DefaultTimeout(30 * time.Minute),
Delete: pluginsdk.DefaultTimeout(30 * time.Minute),
},

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ func resourceApiManagementProductGroup() *pluginsdk.Resource {
Timeouts: &pluginsdk.ResourceTimeout{
Create: pluginsdk.DefaultTimeout(30 * time.Minute),
Read: pluginsdk.DefaultTimeout(5 * time.Minute),
Update: pluginsdk.DefaultTimeout(30 * time.Minute),
Delete: pluginsdk.DefaultTimeout(30 * time.Minute),
},

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ func resourceApiManagementProductTag() *pluginsdk.Resource {
Timeouts: &pluginsdk.ResourceTimeout{
Create: pluginsdk.DefaultTimeout(30 * time.Minute),
Read: pluginsdk.DefaultTimeout(5 * time.Minute),
Update: pluginsdk.DefaultTimeout(30 * time.Minute),
Delete: pluginsdk.DefaultTimeout(30 * time.Minute),
},

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@ func resourceApplicationInsightsAPIKey() *pluginsdk.Resource {
Timeouts: &pluginsdk.ResourceTimeout{
Create: pluginsdk.DefaultTimeout(30 * time.Minute),
Read: pluginsdk.DefaultTimeout(5 * time.Minute),
Update: pluginsdk.DefaultTimeout(30 * time.Minute),
Delete: pluginsdk.DefaultTimeout(30 * time.Minute),
},

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@ func resourceArmRoleAssignment() *pluginsdk.Resource {
Timeouts: &pluginsdk.ResourceTimeout{
Create: pluginsdk.DefaultTimeout(30 * time.Minute),
Read: pluginsdk.DefaultTimeout(5 * time.Minute),
Update: pluginsdk.DefaultTimeout(30 * time.Minute),
Delete: pluginsdk.DefaultTimeout(30 * time.Minute),
},

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@ func resourceAutomationJobSchedule() *pluginsdk.Resource {
Timeouts: &pluginsdk.ResourceTimeout{
Create: pluginsdk.DefaultTimeout(30 * time.Minute),
Read: pluginsdk.DefaultTimeout(5 * time.Minute),
Update: pluginsdk.DefaultTimeout(30 * time.Minute),
Delete: pluginsdk.DefaultTimeout(30 * time.Minute),
},

Expand Down
1 change: 0 additions & 1 deletion internal/services/cdn/cdn_frontdoor_rule_set_resource.go
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ func resourceCdnFrontDoorRuleSet() *pluginsdk.Resource {
Timeouts: &pluginsdk.ResourceTimeout{
Create: pluginsdk.DefaultTimeout(30 * time.Minute),
Read: pluginsdk.DefaultTimeout(5 * time.Minute),
Update: pluginsdk.DefaultTimeout(30 * time.Minute),
Delete: pluginsdk.DefaultTimeout(30 * time.Minute),
},

Expand Down
5 changes: 2 additions & 3 deletions internal/services/compute/marketplace_agreement_resource.go
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ import (

func resourceMarketplaceAgreement() *pluginsdk.Resource {
return &pluginsdk.Resource{
Create: resourceMarketplaceAgreementCreateUpdate,
Create: resourceMarketplaceAgreementCreate,
Read: resourceMarketplaceAgreementRead,
Delete: resourceMarketplaceAgreementDelete,
Importer: pluginsdk.ImporterValidatingResourceId(func(id string) error {
Expand All @@ -31,7 +31,6 @@ func resourceMarketplaceAgreement() *pluginsdk.Resource {
Timeouts: &pluginsdk.ResourceTimeout{
Create: pluginsdk.DefaultTimeout(30 * time.Minute),
Read: pluginsdk.DefaultTimeout(5 * time.Minute),
Update: pluginsdk.DefaultTimeout(30 * time.Minute),
Delete: pluginsdk.DefaultTimeout(30 * time.Minute),
},

Expand Down Expand Up @@ -70,7 +69,7 @@ func resourceMarketplaceAgreement() *pluginsdk.Resource {
}
}

func resourceMarketplaceAgreementCreateUpdate(d *pluginsdk.ResourceData, meta interface{}) error {
func resourceMarketplaceAgreementCreate(d *pluginsdk.ResourceData, meta interface{}) error {
client := meta.(*clients.Client).Compute.MarketplaceAgreementsClient
ctx, cancel := timeouts.ForCreateUpdate(meta.(*clients.Client).StopContext, d)
subscriptionId := meta.(*clients.Client).Account.SubscriptionId
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ func resourceDataProtectionBackupPolicyBlobStorage() *schema.Resource {
Timeouts: &schema.ResourceTimeout{
Create: schema.DefaultTimeout(30 * time.Minute),
Read: schema.DefaultTimeout(5 * time.Minute),
Update: schema.DefaultTimeout(30 * time.Minute),
Delete: schema.DefaultTimeout(30 * time.Minute),
},

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ func resourceDataProtectionBackupPolicyDisk() *schema.Resource {
Timeouts: &schema.ResourceTimeout{
Create: schema.DefaultTimeout(30 * time.Minute),
Read: schema.DefaultTimeout(5 * time.Minute),
Update: schema.DefaultTimeout(30 * time.Minute),
Delete: schema.DefaultTimeout(30 * time.Minute),
},

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ func resourceDataProtectionBackupPolicyPostgreSQL() *pluginsdk.Resource {
Timeouts: &pluginsdk.ResourceTimeout{
Create: pluginsdk.DefaultTimeout(30 * time.Minute),
Read: pluginsdk.DefaultTimeout(5 * time.Minute),
Update: pluginsdk.DefaultTimeout(30 * time.Minute),
Delete: pluginsdk.DefaultTimeout(30 * time.Minute),
},

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ func resourceVirtualDesktopWorkspaceApplicationGroupAssociation() *pluginsdk.Res
Timeouts: &pluginsdk.ResourceTimeout{
Create: pluginsdk.DefaultTimeout(60 * time.Minute),
Read: pluginsdk.DefaultTimeout(5 * time.Minute),
Update: pluginsdk.DefaultTimeout(60 * time.Minute),
Delete: pluginsdk.DefaultTimeout(60 * time.Minute),
},

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ func resourceActiveDirectoryDomainServiceReplicaSet() *pluginsdk.Resource {
Timeouts: &pluginsdk.ResourceTimeout{
Create: pluginsdk.DefaultTimeout(3 * time.Hour),
Read: pluginsdk.DefaultTimeout(5 * time.Minute),
Update: pluginsdk.DefaultTimeout(2 * time.Hour),
Delete: pluginsdk.DefaultTimeout(1 * time.Hour),
},

Expand Down
1 change: 0 additions & 1 deletion internal/services/iothub/iothub_consumer_group_resource.go
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@ func resourceIotHubConsumerGroup() *pluginsdk.Resource {
Timeouts: &pluginsdk.ResourceTimeout{
Create: pluginsdk.DefaultTimeout(30 * time.Minute),
Read: pluginsdk.DefaultTimeout(5 * time.Minute),
Update: pluginsdk.DefaultTimeout(30 * time.Minute),
Delete: pluginsdk.DefaultTimeout(30 * time.Minute),
},

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ import (

func resourceKustoClusterPrincipalAssignment() *pluginsdk.Resource {
return &pluginsdk.Resource{
Create: resourceKustoClusterPrincipalAssignmentCreateUpdate,
Create: resourceKustoClusterPrincipalAssignmentCreate,
Read: resourceKustoClusterPrincipalAssignmentRead,
Delete: resourceKustoClusterPrincipalAssignmentDelete,

Expand All @@ -39,7 +39,6 @@ func resourceKustoClusterPrincipalAssignment() *pluginsdk.Resource {
Timeouts: &pluginsdk.ResourceTimeout{
Create: pluginsdk.DefaultTimeout(60 * time.Minute),
Read: pluginsdk.DefaultTimeout(5 * time.Minute),
Update: pluginsdk.DefaultTimeout(60 * time.Minute),
Delete: pluginsdk.DefaultTimeout(60 * time.Minute),
},

Expand Down Expand Up @@ -101,7 +100,7 @@ func resourceKustoClusterPrincipalAssignment() *pluginsdk.Resource {
}
}

func resourceKustoClusterPrincipalAssignmentCreateUpdate(d *pluginsdk.ResourceData, meta interface{}) error {
func resourceKustoClusterPrincipalAssignmentCreate(d *pluginsdk.ResourceData, meta interface{}) error {
client := meta.(*clients.Client).Kusto.ClusterPrincipalAssignmentsClient
subscriptionId := meta.(*clients.Client).Account.SubscriptionId
ctx, cancel := timeouts.ForCreateUpdate(meta.(*clients.Client).StopContext, d)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@ func resourceLogAnalyticsSavedSearch() *pluginsdk.Resource {
Timeouts: &pluginsdk.ResourceTimeout{
Create: pluginsdk.DefaultTimeout(30 * time.Minute),
Read: pluginsdk.DefaultTimeout(5 * time.Minute),
Update: pluginsdk.DefaultTimeout(30 * time.Minute),
Delete: pluginsdk.DefaultTimeout(30 * time.Minute),
},

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@ func resourceAksInferenceCluster() *pluginsdk.Resource {
Timeouts: &pluginsdk.ResourceTimeout{
Create: pluginsdk.DefaultTimeout(30 * time.Minute),
Read: pluginsdk.DefaultTimeout(5 * time.Minute),
Update: pluginsdk.DefaultTimeout(30 * time.Minute),
Delete: pluginsdk.DefaultTimeout(30 * time.Minute),
},

Expand Down
5 changes: 2 additions & 3 deletions internal/services/mariadb/mariadb_configuration_resource.go
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ import (

func resourceMariaDbConfiguration() *pluginsdk.Resource {
return &pluginsdk.Resource{
Create: resourceMariaDbConfigurationCreateUpdate,
Create: resourceMariaDbConfigurationCreate,
Read: resourceMariaDbConfigurationRead,
Delete: resourceMariaDbConfigurationDelete,
Importer: pluginsdk.ImporterValidatingResourceId(func(id string) error {
Expand All @@ -32,7 +32,6 @@ func resourceMariaDbConfiguration() *pluginsdk.Resource {
Timeouts: &pluginsdk.ResourceTimeout{
Create: pluginsdk.DefaultTimeout(30 * time.Minute),
Read: pluginsdk.DefaultTimeout(5 * time.Minute),
Update: pluginsdk.DefaultTimeout(30 * time.Minute),
Delete: pluginsdk.DefaultTimeout(30 * time.Minute),
},

Expand Down Expand Up @@ -62,7 +61,7 @@ func resourceMariaDbConfiguration() *pluginsdk.Resource {
}
}

func resourceMariaDbConfigurationCreateUpdate(d *pluginsdk.ResourceData, meta interface{}) error {
func resourceMariaDbConfigurationCreate(d *pluginsdk.ResourceData, meta interface{}) error {
client := meta.(*clients.Client).MariaDB.ConfigurationsClient
subscriptionId := meta.(*clients.Client).Account.SubscriptionId
ctx, cancel := timeouts.ForCreateUpdate(meta.(*clients.Client).StopContext, d)
Expand Down
5 changes: 2 additions & 3 deletions internal/services/mariadb/mariadb_database_resource.go
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ import (

func resourceMariaDbDatabase() *pluginsdk.Resource {
return &pluginsdk.Resource{
Create: resourceMariaDbDatabaseCreateUpdate,
Create: resourceMariaDbDatabaseCreate,
Read: resourceMariaDbDatabaseRead,
Delete: resourceMariaDbDatabaseDelete,

Expand All @@ -35,7 +35,6 @@ func resourceMariaDbDatabase() *pluginsdk.Resource {
Timeouts: &pluginsdk.ResourceTimeout{
Create: pluginsdk.DefaultTimeout(60 * time.Minute),
Read: pluginsdk.DefaultTimeout(5 * time.Minute),
Update: pluginsdk.DefaultTimeout(60 * time.Minute),
Delete: pluginsdk.DefaultTimeout(60 * time.Minute),
},

Expand Down Expand Up @@ -82,7 +81,7 @@ func resourceMariaDbDatabase() *pluginsdk.Resource {
}
}

func resourceMariaDbDatabaseCreateUpdate(d *pluginsdk.ResourceData, meta interface{}) error {
func resourceMariaDbDatabaseCreate(d *pluginsdk.ResourceData, meta interface{}) error {
client := meta.(*clients.Client).MariaDB.DatabasesClient
subscriptionId := meta.(*clients.Client).Account.SubscriptionId
ctx, cancel := timeouts.ForCreateUpdate(meta.(*clients.Client).StopContext, d)
Expand Down
1 change: 0 additions & 1 deletion internal/services/media/media_live_output_resource.go
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@ func resourceMediaLiveOutput() *pluginsdk.Resource {
Timeouts: &pluginsdk.ResourceTimeout{
Create: pluginsdk.DefaultTimeout(30 * time.Minute),
Read: pluginsdk.DefaultTimeout(5 * time.Minute),
Update: pluginsdk.DefaultTimeout(30 * time.Minute),
Delete: pluginsdk.DefaultTimeout(30 * time.Minute),
},

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,14 +26,13 @@ import (

func resourceMonitorPrivateLinkScopedService() *pluginsdk.Resource {
return &pluginsdk.Resource{
Create: resourceMonitorPrivateLinkScopedServiceCreateUpdate,
Create: resourceMonitorPrivateLinkScopedServiceCreate,
Read: resourceMonitorPrivateLinkScopedServiceRead,
Delete: resourceMonitorPrivateLinkScopedServiceDelete,

Timeouts: &pluginsdk.ResourceTimeout{
Create: pluginsdk.DefaultTimeout(30 * time.Minute),
Read: pluginsdk.DefaultTimeout(5 * time.Minute),
Update: pluginsdk.DefaultTimeout(30 * time.Minute),
Delete: pluginsdk.DefaultTimeout(30 * time.Minute),
},

Expand Down Expand Up @@ -74,7 +73,7 @@ func resourceMonitorPrivateLinkScopedService() *pluginsdk.Resource {
}
}

func resourceMonitorPrivateLinkScopedServiceCreateUpdate(d *pluginsdk.ResourceData, meta interface{}) error {
func resourceMonitorPrivateLinkScopedServiceCreate(d *pluginsdk.ResourceData, meta interface{}) error {
subscriptionId := meta.(*clients.Client).Account.SubscriptionId
client := meta.(*clients.Client).Monitor.PrivateLinkScopedResourcesClient
ctx, cancel := timeouts.ForCreateUpdate(meta.(*clients.Client).StopContext, d)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ func resourceMsSqlOutboundFirewallRule() *pluginsdk.Resource {
return &pluginsdk.Resource{
Create: resourceMsSqlOutboundFirewallRuleCreate,
Read: resourceMsSqlOutboundFirewallRuleRead,
// Update: resourceMsSqlOutboundFirewallRuleCreateUpdate,
Delete: resourceMsSqlOutboundFirewallRuleDelete,

Importer: pluginsdk.ImporterValidatingResourceId(func(id string) error {
Expand All @@ -33,7 +32,6 @@ func resourceMsSqlOutboundFirewallRule() *pluginsdk.Resource {
Timeouts: &pluginsdk.ResourceTimeout{
Create: pluginsdk.DefaultTimeout(30 * time.Minute),
Read: pluginsdk.DefaultTimeout(5 * time.Minute),
Update: pluginsdk.DefaultTimeout(30 * time.Minute),
Delete: pluginsdk.DefaultTimeout(30 * time.Minute),
},

Expand Down
1 change: 0 additions & 1 deletion internal/services/mysql/mysql_configuration_resource.go
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ func resourceMySQLConfiguration() *pluginsdk.Resource {
Timeouts: &pluginsdk.ResourceTimeout{
Create: pluginsdk.DefaultTimeout(30 * time.Minute),
Read: pluginsdk.DefaultTimeout(5 * time.Minute),
Update: pluginsdk.DefaultTimeout(30 * time.Minute),
Delete: pluginsdk.DefaultTimeout(30 * time.Minute),
},

Expand Down
1 change: 0 additions & 1 deletion internal/services/mysql/mysql_database_resource.go
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ func resourceMySqlDatabase() *pluginsdk.Resource {
Timeouts: &pluginsdk.ResourceTimeout{
Create: pluginsdk.DefaultTimeout(60 * time.Minute),
Read: pluginsdk.DefaultTimeout(5 * time.Minute),
Update: pluginsdk.DefaultTimeout(60 * time.Minute),
Delete: pluginsdk.DefaultTimeout(60 * time.Minute),
},

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ func resourceMySqlFlexibleDatabase() *pluginsdk.Resource {
Timeouts: &pluginsdk.ResourceTimeout{
Create: pluginsdk.DefaultTimeout(60 * time.Minute),
Read: pluginsdk.DefaultTimeout(5 * time.Minute),
Update: pluginsdk.DefaultTimeout(60 * time.Minute),
Delete: pluginsdk.DefaultTimeout(60 * time.Minute),
},

Expand Down
1 change: 0 additions & 1 deletion internal/services/netapp/netapp_snapshot_resource.go
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ func resourceNetAppSnapshot() *pluginsdk.Resource {
Timeouts: &pluginsdk.ResourceTimeout{
Create: pluginsdk.DefaultTimeout(30 * time.Minute),
Read: pluginsdk.DefaultTimeout(5 * time.Minute),
Update: pluginsdk.DefaultTimeout(30 * time.Minute),
Delete: pluginsdk.DefaultTimeout(30 * time.Minute),
},
Importer: pluginsdk.ImporterValidatingResourceId(func(id string) error {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ func resourceExpressRouteCircuitAuthorization() *pluginsdk.Resource {
Timeouts: &pluginsdk.ResourceTimeout{
Create: pluginsdk.DefaultTimeout(30 * time.Minute),
Read: pluginsdk.DefaultTimeout(5 * time.Minute),
Update: pluginsdk.DefaultTimeout(30 * time.Minute),
Delete: pluginsdk.DefaultTimeout(30 * time.Minute),
},

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ func resourceExpressRoutePortAuthorization() *pluginsdk.Resource {
Timeouts: &pluginsdk.ResourceTimeout{
Create: pluginsdk.DefaultTimeout(30 * time.Minute),
Read: pluginsdk.DefaultTimeout(5 * time.Minute),
Update: pluginsdk.DefaultTimeout(30 * time.Minute),
Delete: pluginsdk.DefaultTimeout(30 * time.Minute),
},

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@ func resourceNetworkInterfaceApplicationGatewayBackendAddressPoolAssociation() *
Timeouts: &pluginsdk.ResourceTimeout{
Create: pluginsdk.DefaultTimeout(30 * time.Minute),
Read: pluginsdk.DefaultTimeout(5 * time.Minute),
Update: pluginsdk.DefaultTimeout(30 * time.Minute),
Delete: pluginsdk.DefaultTimeout(30 * time.Minute),
},

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,6 @@ func resourceNetworkInterfaceApplicationSecurityGroupAssociation() *pluginsdk.Re
Timeouts: &pluginsdk.ResourceTimeout{
Create: pluginsdk.DefaultTimeout(30 * time.Minute),
Read: pluginsdk.DefaultTimeout(5 * time.Minute),
Update: pluginsdk.DefaultTimeout(30 * time.Minute),
Delete: pluginsdk.DefaultTimeout(30 * time.Minute),
},

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,6 @@ func resourceNetworkInterfaceBackendAddressPoolAssociation() *pluginsdk.Resource
Timeouts: &pluginsdk.ResourceTimeout{
Create: pluginsdk.DefaultTimeout(30 * time.Minute),
Read: pluginsdk.DefaultTimeout(5 * time.Minute),
Update: pluginsdk.DefaultTimeout(30 * time.Minute),
Delete: pluginsdk.DefaultTimeout(30 * time.Minute),
},

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,6 @@ func resourceNetworkInterfaceNatRuleAssociation() *pluginsdk.Resource {
Timeouts: &pluginsdk.ResourceTimeout{
Create: pluginsdk.DefaultTimeout(30 * time.Minute),
Read: pluginsdk.DefaultTimeout(5 * time.Minute),
Update: pluginsdk.DefaultTimeout(30 * time.Minute),
Delete: pluginsdk.DefaultTimeout(30 * time.Minute),
},

Expand Down
Loading

0 comments on commit 6815d73

Please sign in to comment.