fix golint error

internal/services/lighthouse/lighthouse_definition_resource.go

@@ -444,18 +444,14 @@ func expandLighthouseDefinitionJustInTimeAccessPolicy(input []interface{}) (*reg
 	}
 	result.MultiFactorAuthProvider = multiFactorAuthProvider
 
-	approvers, err := expandLighthouseDefinitionApprover(justInTimeAccessPolicy["approver"].(*pluginsdk.Set).List())
-	if err != nil {
-		return nil, err
-	}
-	result.ManagedByTenantApprovers = approvers
+	result.ManagedByTenantApprovers = expandLighthouseDefinitionApprover(justInTimeAccessPolicy["approver"].(*pluginsdk.Set).List())
 
 	return &result, nil
 }
 
-func expandLighthouseDefinitionApprover(input []interface{}) (*[]registrationdefinitions.EligibleApprover, error) {
+func expandLighthouseDefinitionApprover(input []interface{}) *[]registrationdefinitions.EligibleApprover {
 	if len(input) == 0 || input[0] == nil {
-		return nil, nil
+		return nil
 	}
 
 	var results []registrationdefinitions.EligibleApprover
@@ -474,7 +470,7 @@ func expandLighthouseDefinitionApprover(input []interface{}) (*[]registrationdef
 		results = append(results, result)
 	}
 
-	return &results, nil
+	return &results
 }
 
 func flattenLighthouseDefinitionEligibleAuthorization(input *[]registrationdefinitions.EligibleAuthorization) []interface{} {

internal/services/network/route_map_resource.go

@@ -373,11 +373,7 @@ func expandRules(input []Rule) (*[]network.RouteMapRule, error) {
 			Name: utils.String(v.Name),
 		}
 
-		actions, err := expandActions(v.Actions)
-		if err != nil {
-			return nil, err
-		}
-		rule.Actions = actions
+		rule.Actions = expandActions(v.Actions)
 
 		rule.MatchCriteria = expandCriteria(v.MatchCriteria)
 
@@ -391,7 +387,7 @@ func expandRules(input []Rule) (*[]network.RouteMapRule, error) {
 	return &rules, nil
 }
 
-func expandActions(input []Action) (*[]network.Action, error) {
+func expandActions(input []Action) *[]network.Action {
 	var actions []network.Action
 
 	for _, v := range input {
@@ -404,7 +400,7 @@ func expandActions(input []Action) (*[]network.Action, error) {
 		actions = append(actions, action)
 	}
 
-	return &actions, nil
+	return &actions
 }
 
 func expandParameters(input []Parameter) *[]network.Parameter {
@@ -468,17 +464,9 @@ func flattenRules(input *[]network.RouteMapRule) ([]Rule, error) {
 	for _, v := range *input {
 		rule := Rule{}
 
-		actions, err := flattenActions(v.Actions)
-		if err != nil {
-			return nil, err
-		}
-		rule.Actions = actions
+		rule.Actions = flattenActions(v.Actions)
 
-		matchCriteria, err := flattenCriteria(v.MatchCriteria)
-		if err != nil {
-			return nil, err
-		}
-		rule.MatchCriteria = matchCriteria
+		rule.MatchCriteria = flattenCriteria(v.MatchCriteria)
 
 		if v.Name != nil {
 			rule.Name = *v.Name
@@ -494,10 +482,10 @@ func flattenRules(input *[]network.RouteMapRule) ([]Rule, error) {
 	return rules, nil
 }
 
-func flattenActions(input *[]network.Action) ([]Action, error) {
+func flattenActions(input *[]network.Action) []Action {
 	var actions []Action
 	if input == nil {
-		return actions, nil
+		return actions
 	}
 
 	for _, v := range *input {
@@ -512,7 +500,7 @@ func flattenActions(input *[]network.Action) ([]Action, error) {
 		actions = append(actions, action)
 	}
 
-	return actions, nil
+	return actions
 }
 
 func flattenParameters(input *[]network.Parameter) []Parameter {
@@ -542,10 +530,10 @@ func flattenParameters(input *[]network.Parameter) []Parameter {
 	return parameters
 }
 
-func flattenCriteria(input *[]network.Criterion) ([]Criterion, error) {
+func flattenCriteria(input *[]network.Criterion) []Criterion {
 	var criteria []Criterion
 	if input == nil {
-		return criteria, nil
+		return criteria
 	}
 
 	for _, v := range *input {
@@ -570,5 +558,5 @@ func flattenCriteria(input *[]network.Criterion) ([]Criterion, error) {
 		criteria = append(criteria, criterion)
 	}
 
-	return criteria, nil
+	return criteria
 }