Apply suggestions from code review

Co-authored-by: stephybun <steph@hashicorp.com>
hashicorp · Jan 10, 2025 · dc56d01 · dc56d01
1 parent 545b720
commit dc56d01
Showing 1 changed file with 6 additions and 12 deletions.
diff --git a/internal/services/costmanagement/anomaly_alert_resource.go b/internal/services/costmanagement/anomaly_alert_resource.go
@@ -124,13 +124,10 @@ func (r AnomalyAlertResource) Create() sdk.ResourceFunc {
 			schedule.SetEndDateAsTime(time.Now().AddDate(1, 0, 0))
 			schedule.SetStartDateAsTime(time.Now())
 
-			var senderEmail string
+			notificationEmail := (*emailAddresses)[0]
 			if v, ok := metadata.ResourceData.GetOk("notification_email"); ok {
-				senderEmail = v.(string)
-			} else {
-				senderEmail = (*emailAddresses)[0]
+				notificationEmail = v.(string)
 			}
-
 			param := scheduledactions.ScheduledAction{
 				Kind: pointer.To(scheduledactions.ScheduledActionKindInsightAlert),
 				Properties: &scheduledactions.ScheduledActionProperties{
@@ -149,7 +146,7 @@ func (r AnomalyAlertResource) Create() sdk.ResourceFunc {
 					Schedule: schedule,
 				},
 			}
-			if _, err := client.CreateOrUpdateByScope(ctx, id, param, scheduledactions.CreateOrUpdateByScopeOperationOptions{}); err != nil {
+			if _, err := client.CreateOrUpdateByScope(ctx, id, param, scheduledactions.DefaultCreateOrUpdateByScopeOperationOptions()); err != nil {
 				return fmt.Errorf("creating %s: %+v", id, err)
 			}
 
@@ -198,13 +195,10 @@ func (r AnomalyAlertResource) Update() sdk.ResourceFunc {
 			schedule.SetEndDateAsTime(time.Now().AddDate(1, 0, 0))
 			schedule.SetStartDateAsTime(time.Now())
 
-			var senderEmail string
+			notificationEmail := (*emailAddresses)[0]
 			if v, ok := metadata.ResourceData.GetOk("notification_email"); ok {
-				senderEmail = v.(string)
-			} else {
-				senderEmail = (*emailAddresses)[0]
+				notificationEmail = v.(string)
 			}
-
 			param := scheduledactions.ScheduledAction{
 				Kind: pointer.To(scheduledactions.ScheduledActionKindInsightAlert),
 				ETag: resp.Model.ETag,
@@ -221,7 +215,7 @@ func (r AnomalyAlertResource) Update() sdk.ResourceFunc {
 					Schedule: schedule,
 				},
 			}
-			if _, err := client.CreateOrUpdateByScope(ctx, *id, param, scheduledactions.CreateOrUpdateByScopeOperationOptions{}); err != nil {
+			if _, err := client.CreateOrUpdateByScope(ctx, *id, param, scheduledactions.DefaultCreateOrUpdateByScopeOperationOptions()); err != nil {
 				return fmt.Errorf("creating %s: %+v", id, err)
 			}