Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

custom_domain_verification_id output not being written to state file for azurerm_windows_function_app and azurerm_windows_function_app_slot resources #17042

Closed
1 task done
bdorplatt opened this issue May 31, 2022 · 5 comments

Comments

@bdorplatt
Copy link

bdorplatt commented May 31, 2022

Is there an existing issue for this?

  • I have searched the existing issues

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Terraform Version

1.0.0

AzureRM Provider Version

3.8.0

Affected Resource(s)/Data Source(s)

azurerm_windows_function_app, azurerm_windows_function_app_slot

Terraform Configuration Files

output "fa_custom_domain_verification_id" {
  description = "Custom Domain name verification ID"
  value       = azurerm_windows_function_app.function_app.custom_domain_verification_id
  sensitive   = true

Debug Output/Panic Output

State File:

 "outputs": {
    "fa_custom_domain_verification_id": {
      "value": "",
      "type": "string",
      "sensitive": true
    },

Expected Behaviour

The Custom Domain Verification ID should be output to the state file for use as inputs for other modules.

Actual Behaviour

A blank output is written to the state file.

This works correctly for the resouce: azurerm_windows_web_app

Looking at the code, it appears there are discrepancies in what is written to state between the azurerm_windows_web_app and the azurerm_windows_function_app resources. Notably, CustomDomainVerificationId is missing from the section "state := WindowsFunctionAppModel" for azurerm_windows_function_app

azurerm_windows_function_app
Starting at line 580, CustomDomainVerificationId isn't present
https://github.com/hashicorp/terraform-provider-azurerm/blob/main/internal/services/appservice/windows_function_app_resource.go

azurerm_windows_web_app
On line 500, there is an entry for:
CustomDomainVerificationId
https://github.com/hashicorp/terraform-provider-azurerm/blob/main/internal/services/appservice/windows_web_app_resource.go

It appears these are missing for azurerm_linux_function_app and azurerm_linux_function_app_slot as well.

Steps to Reproduce

Apply code for any function app or function app slot with custom_domain_verification_id as an output

Important Factoids

No response

References

No response

@bdorplatt bdorplatt added the bug label May 31, 2022
@github-actions github-actions bot removed the bug label May 31, 2022
@bdorplatt bdorplatt changed the title custom_domain_verification_id output not writing to state file in azurerm_windows_function_app and azurerm_windows_function_app_slot resources custom_domain_verification_id output not being written to state file for azurerm_windows_function_app and azurerm_windows_function_app_slot resources May 31, 2022
@SergiyDivnych
Copy link
Contributor

Hi, I have the same issue

SergiyDivnych added a commit to SergiyDivnych/terraform-provider-azurerm that referenced this issue Jun 9, 2022
SergiyDivnych added a commit to SergiyDivnych/terraform-provider-azurerm that referenced this issue Jun 9, 2022
SergiyDivnych added a commit to SergiyDivnych/terraform-provider-azurerm that referenced this issue Jun 9, 2022
@mbfrahry mbfrahry added this to the v3.10.0 milestone Jun 9, 2022
@tombuildsstuff tombuildsstuff modified the milestones: v3.10.0, v3.11.0 Jun 10, 2022
@SergiyDivnych
Copy link
Contributor

Works now in azurerm provider v3.10.0

@jackofallops
Copy link
Member

Closed by #17183

@github-actions
Copy link

This functionality has been released in v3.11.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

7 participants