Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dependencies - update proximityplacementgroups to 2022-03-01 #19537

Merged
merged 1 commit into from
Dec 7, 2022
Merged

dependencies - update proximityplacementgroups to 2022-03-01 #19537

merged 1 commit into from
Dec 7, 2022

Conversation

myc2h6o
Copy link
Contributor

@myc2h6o myc2h6o commented Dec 2, 2022 •
edited
Loading

Updating sdk version of proximityplacementgroups to 2022-03-01
Updating go-szure-sdk version to v0.20221130.1102501

@myc2h6o
Copy link
Contributor Author

myc2h6o commented Dec 2, 2022 •
edited
Loading

There are some breaking changes in generated sdk: Vm->VM, and in vmware: VmotionNetwork -> VMotionNetwork. Is this ok, or we need to keep it consistent across API version, by using more specific names here for resolving the eventual consistency issue introduced by compute 2022-03-01(hashicorp/pandora#1873) (hashicorp/pandora#1883)?

@ziyeqf ziyeqf mentioned this pull request Dec 5, 2022
Merged
tombuildsstuff
tombuildsstuff approved these changes Dec 7, 2022
View reviewed changes
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tombuildsstuff tombuildsstuff added this to the v3.35.0 milestone Dec 7, 2022
@tombuildsstuff tombuildsstuff merged commit 744f7ed into hashicorp:main Dec 7, 2022
tombuildsstuff added a commit that referenced this pull request Dec 7, 2022
@tombuildsstuff
updating to include #19537
6e871c9
@myc2h6o myc2h6o deleted the ppg_2022-03-01 branch December 7, 2022 13:32
@github-actions
Copy link

github-actions bot commented Dec 9, 2022

This functionality has been released in v3.35.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Jan 9, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tombuildsstuff tombuildsstuff tombuildsstuff approved these changes

Assignees
No one assigned
Labels
dependencies service/automation service/machine-learning service/service-fabric-managed-cluster service/vmware size/XL
Projects
None yet
Milestone
v3.35.0
Development

Successfully merging this pull request may close these issues.
2 participants
@myc2h6o @tombuildsstuff