depencies: `azurerm_recovery_services_vault` - swap SDK to `go-azure-sdk` #19551

ziyeqf · 2022-12-05T06:12:52Z

depends on #19537 to rename properties

Test

 TF_ACC=1 go test -v ./internal/services/recoveryservices -run=TestAccRecoveryServicesVault -timeout=600m    
=== RUN   TestAccRecoveryServicesVault_basic
=== PAUSE TestAccRecoveryServicesVault_basic
=== RUN   TestAccRecoveryServicesVault_basicWithCrossRegionRestore
=== PAUSE TestAccRecoveryServicesVault_basicWithCrossRegionRestore
=== RUN   TestAccRecoveryServicesVault_basicWithCrossRegionRestoreAndWrongStorageType
=== PAUSE TestAccRecoveryServicesVault_basicWithCrossRegionRestoreAndWrongStorageType
=== RUN   TestAccRecoveryServicesVault_zrs
=== PAUSE TestAccRecoveryServicesVault_zrs
=== RUN   TestAccRecoveryServicesVault_complete
=== PAUSE TestAccRecoveryServicesVault_complete
=== RUN   TestAccRecoveryServicesVault_update
=== PAUSE TestAccRecoveryServicesVault_update
=== RUN   TestAccRecoveryServicesVault_requiresImport
=== PAUSE TestAccRecoveryServicesVault_requiresImport
=== RUN   TestAccRecoveryServicesVault_identity
=== PAUSE TestAccRecoveryServicesVault_identity
=== RUN   TestAccRecoveryServicesVault_softDelete
=== PAUSE TestAccRecoveryServicesVault_softDelete
=== RUN   TestAccRecoveryServicesVault_storageModeType
=== PAUSE TestAccRecoveryServicesVault_storageModeType
=== RUN   TestAccRecoveryServicesVault_crossRegionRestore
=== PAUSE TestAccRecoveryServicesVault_crossRegionRestore
=== RUN   TestAccRecoveryServicesVault_sku
=== PAUSE TestAccRecoveryServicesVault_sku
=== RUN   TestAccRecoveryServicesVault_updateSkuWithExistingEncryption
=== PAUSE TestAccRecoveryServicesVault_updateSkuWithExistingEncryption
=== RUN   TestAccRecoveryServicesVault_encryptionWithKeyVaultKey
=== PAUSE TestAccRecoveryServicesVault_encryptionWithKeyVaultKey
=== RUN   TestAccRecoveryServicesVault_turnOnEncryptionWithKeyVaultKey
=== PAUSE TestAccRecoveryServicesVault_turnOnEncryptionWithKeyVaultKey
=== RUN   TestAccRecoveryServicesVault_turnOffEncryptionWithKeyVaultKeyShouldHaveClearlyErrorMessage
=== PAUSE TestAccRecoveryServicesVault_turnOffEncryptionWithKeyVaultKeyShouldHaveClearlyErrorMessage
=== RUN   TestAccRecoveryServicesVault_changeInfrastructureEncryptionEnabledShouldHaveClearlyErrorMessage
=== PAUSE TestAccRecoveryServicesVault_changeInfrastructureEncryptionEnabledShouldHaveClearlyErrorMessage
=== RUN   TestAccRecoveryServicesVault_encryptionWithInfrastructureEncryption
=== PAUSE TestAccRecoveryServicesVault_encryptionWithInfrastructureEncryption
=== RUN   TestAccRecoveryServicesVault_switchEncryptionKeyVaultKey
=== PAUSE TestAccRecoveryServicesVault_switchEncryptionKeyVaultKey
=== CONT  TestAccRecoveryServicesVault_basic
=== CONT  TestAccRecoveryServicesVault_crossRegionRestore
=== CONT  TestAccRecoveryServicesVault_turnOffEncryptionWithKeyVaultKeyShouldHaveClearlyErrorMessage
=== CONT  TestAccRecoveryServicesVault_update
=== CONT  TestAccRecoveryServicesVault_encryptionWithKeyVaultKey
=== CONT  TestAccRecoveryServicesVault_turnOnEncryptionWithKeyVaultKey
=== CONT  TestAccRecoveryServicesVault_softDelete
=== CONT  TestAccRecoveryServicesVault_complete
--- PASS: TestAccRecoveryServicesVault_basic (212.09s)
=== CONT  TestAccRecoveryServicesVault_zrs
--- PASS: TestAccRecoveryServicesVault_complete (271.64s)
=== CONT  TestAccRecoveryServicesVault_basicWithCrossRegionRestoreAndWrongStorageType
--- PASS: TestAccRecoveryServicesVault_crossRegionRestore (392.60s)
=== CONT  TestAccRecoveryServicesVault_basicWithCrossRegionRestore
--- PASS: TestAccRecoveryServicesVault_basicWithCrossRegionRestoreAndWrongStorageType (150.63s)
=== CONT  TestAccRecoveryServicesVault_storageModeType
--- PASS: TestAccRecoveryServicesVault_zrs (239.40s)
=== CONT  TestAccRecoveryServicesVault_identity
--- PASS: TestAccRecoveryServicesVault_update (521.01s)
=== CONT  TestAccRecoveryServicesVault_updateSkuWithExistingEncryption
--- PASS: TestAccRecoveryServicesVault_basicWithCrossRegionRestore (251.38s)
=== CONT  TestAccRecoveryServicesVault_requiresImport
--- PASS: TestAccRecoveryServicesVault_encryptionWithKeyVaultKey (724.98s)
=== CONT  TestAccRecoveryServicesVault_sku
--- PASS: TestAccRecoveryServicesVault_turnOnEncryptionWithKeyVaultKey (745.89s)
=== CONT  TestAccRecoveryServicesVault_encryptionWithInfrastructureEncryption
--- PASS: TestAccRecoveryServicesVault_storageModeType (327.04s)
=== CONT  TestAccRecoveryServicesVault_switchEncryptionKeyVaultKey
--- PASS: TestAccRecoveryServicesVault_requiresImport (195.06s)
=== CONT  TestAccRecoveryServicesVault_changeInfrastructureEncryptionEnabledShouldHaveClearlyErrorMessage
--- PASS: TestAccRecoveryServicesVault_softDelete (904.02s)
--- PASS: TestAccRecoveryServicesVault_turnOffEncryptionWithKeyVaultKeyShouldHaveClearlyErrorMessage (927.55s)
--- PASS: TestAccRecoveryServicesVault_identity (513.27s)
--- PASS: TestAccRecoveryServicesVault_updateSkuWithExistingEncryption (743.67s)
--- PASS: TestAccRecoveryServicesVault_encryptionWithInfrastructureEncryption (739.34s)
--- PASS: TestAccRecoveryServicesVault_changeInfrastructureEncryptionEnabledShouldHaveClearlyErrorMessage (784.33s)
--- PASS: TestAccRecoveryServicesVault_sku (930.73s)
--- PASS: TestAccRecoveryServicesVault_switchEncryptionKeyVaultKey (1130.90s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/recoveryservices      1881.375s

katbyte

CI is fialing

ziyeqf · 2022-12-06T01:46:52Z

@katbyte sorry, it needs the dependent PR to pass CI pipelines, temporarily close this pr to wait..

…ry_vault

ziyeqf · 2022-12-08T02:18:20Z

internal/services/streamanalytics/stream_analytics_output_blob_resource.go changed due to swagger and sdk changed.
swagger change

…ry_vault

katbyte

Need to fix up CI @ziyeqf

tombuildsstuff

hey @ziyeqf

Thanks for pushing those changes, I've taken a look through and left a few comments inline, but if we can fix those up then we should be able to take another look here 👍

Thanks!

internal/services/recoveryservices/recovery_services_vault_resource_test.go

internal/services/recoveryservices/recovery_services_vault_resource.go

…ry_vault

ziyeqf · 2023-01-11T06:04:16Z

I'm not sure why this CI failed..

Test result after modification

terraform-provider-azurerm ❯ TF_ACC=1 go test -v ./internal/services/recoveryservices -run=TestAccRecoveryServicesVault -timeout=600m
=== RUN   TestAccRecoveryServicesVault_basic
=== PAUSE TestAccRecoveryServicesVault_basic
=== RUN   TestAccRecoveryServicesVault_basicWithCrossRegionRestore
=== PAUSE TestAccRecoveryServicesVault_basicWithCrossRegionRestore
=== RUN   TestAccRecoveryServicesVault_basicWithCrossRegionRestoreAndWrongStorageType
=== PAUSE TestAccRecoveryServicesVault_basicWithCrossRegionRestoreAndWrongStorageType
=== RUN   TestAccRecoveryServicesVault_zrs
=== PAUSE TestAccRecoveryServicesVault_zrs
=== RUN   TestAccRecoveryServicesVault_complete
=== PAUSE TestAccRecoveryServicesVault_complete
=== RUN   TestAccRecoveryServicesVault_update
=== PAUSE TestAccRecoveryServicesVault_update
=== RUN   TestAccRecoveryServicesVault_requiresImport
=== PAUSE TestAccRecoveryServicesVault_requiresImport
=== RUN   TestAccRecoveryServicesVault_identity
=== PAUSE TestAccRecoveryServicesVault_identity
=== RUN   TestAccRecoveryServicesVault_softDelete
=== PAUSE TestAccRecoveryServicesVault_softDelete
=== RUN   TestAccRecoveryServicesVault_storageModeType
=== PAUSE TestAccRecoveryServicesVault_storageModeType
=== RUN   TestAccRecoveryServicesVault_crossRegionRestore
=== PAUSE TestAccRecoveryServicesVault_crossRegionRestore
=== RUN   TestAccRecoveryServicesVault_sku
=== PAUSE TestAccRecoveryServicesVault_sku
=== RUN   TestAccRecoveryServicesVault_updateSkuWithExistingEncryption
=== PAUSE TestAccRecoveryServicesVault_updateSkuWithExistingEncryption
=== RUN   TestAccRecoveryServicesVault_encryptionWithKeyVaultKey
=== PAUSE TestAccRecoveryServicesVault_encryptionWithKeyVaultKey
=== RUN   TestAccRecoveryServicesVault_turnOnEncryptionWithKeyVaultKey
=== PAUSE TestAccRecoveryServicesVault_turnOnEncryptionWithKeyVaultKey
=== RUN   TestAccRecoveryServicesVault_turnOffEncryptionWithKeyVaultKeyShouldHaveClearlyErrorMessage
=== PAUSE TestAccRecoveryServicesVault_turnOffEncryptionWithKeyVaultKeyShouldHaveClearlyErrorMessage
=== RUN   TestAccRecoveryServicesVault_changeInfrastructureEncryptionEnabledShouldHaveClearlyErrorMessage
=== PAUSE TestAccRecoveryServicesVault_changeInfrastructureEncryptionEnabledShouldHaveClearlyErrorMessage
=== RUN   TestAccRecoveryServicesVault_encryptionWithInfrastructureEncryption
=== PAUSE TestAccRecoveryServicesVault_encryptionWithInfrastructureEncryption
=== RUN   TestAccRecoveryServicesVault_switchEncryptionKeyVaultKey
=== PAUSE TestAccRecoveryServicesVault_switchEncryptionKeyVaultKey
=== CONT  TestAccRecoveryServicesVault_basic
=== CONT  TestAccRecoveryServicesVault_crossRegionRestore
=== CONT  TestAccRecoveryServicesVault_update
=== CONT  TestAccRecoveryServicesVault_turnOffEncryptionWithKeyVaultKeyShouldHaveClearlyErrorMessage
=== CONT  TestAccRecoveryServicesVault_complete
=== CONT  TestAccRecoveryServicesVault_zrs
=== CONT  TestAccRecoveryServicesVault_basicWithCrossRegionRestoreAndWrongStorageType
=== CONT  TestAccRecoveryServicesVault_basicWithCrossRegionRestore
--- PASS: TestAccRecoveryServicesVault_basicWithCrossRegionRestoreAndWrongStorageType (217.35s)
=== CONT  TestAccRecoveryServicesVault_encryptionWithKeyVaultKey
--- PASS: TestAccRecoveryServicesVault_zrs (433.93s)
=== CONT  TestAccRecoveryServicesVault_turnOnEncryptionWithKeyVaultKey
--- PASS: TestAccRecoveryServicesVault_complete (434.34s)
=== CONT  TestAccRecoveryServicesVault_encryptionWithInfrastructureEncryption
--- PASS: TestAccRecoveryServicesVault_basicWithCrossRegionRestore (442.71s)
=== CONT  TestAccRecoveryServicesVault_switchEncryptionKeyVaultKey
--- PASS: TestAccRecoveryServicesVault_basic (465.36s)
=== CONT  TestAccRecoveryServicesVault_updateSkuWithExistingEncryption
--- PASS: TestAccRecoveryServicesVault_crossRegionRestore (693.18s)
=== CONT  TestAccRecoveryServicesVault_sku
--- PASS: TestAccRecoveryServicesVault_update (861.18s)
=== CONT  TestAccRecoveryServicesVault_softDelete
--- PASS: TestAccRecoveryServicesVault_turnOffEncryptionWithKeyVaultKeyShouldHaveClearlyErrorMessage (1143.52s)
=== CONT  TestAccRecoveryServicesVault_storageModeType
--- PASS: TestAccRecoveryServicesVault_encryptionWithKeyVaultKey (1057.48s)
=== CONT  TestAccRecoveryServicesVault_identity
--- PASS: TestAccRecoveryServicesVault_encryptionWithInfrastructureEncryption (928.42s)
=== CONT  TestAccRecoveryServicesVault_requiresImport
--- PASS: TestAccRecoveryServicesVault_updateSkuWithExistingEncryption (899.96s)
=== CONT  TestAccRecoveryServicesVault_changeInfrastructureEncryptionEnabledShouldHaveClearlyErrorMessage
--- PASS: TestAccRecoveryServicesVault_turnOnEncryptionWithKeyVaultKey (1035.11s)
--- PASS: TestAccRecoveryServicesVault_switchEncryptionKeyVaultKey (1133.45s)
--- PASS: TestAccRecoveryServicesVault_storageModeType (481.87s)
--- PASS: TestAccRecoveryServicesVault_requiresImport (313.77s)
--- PASS: TestAccRecoveryServicesVault_sku (1148.78s)
--- PASS: TestAccRecoveryServicesVault_softDelete (1040.00s)
--- PASS: TestAccRecoveryServicesVault_identity (704.77s)
--- PASS: TestAccRecoveryServicesVault_changeInfrastructureEncryptionEnabledShouldHaveClearlyErrorMessage (719.43s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/recoveryservices      2086.007s

katbyte

LGTM 🌵

github-actions · 2023-01-20T04:51:05Z

This functionality has been released in v3.40.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

github-actions · 2023-02-20T02:15:52Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

azurerm_recovery_services_vault - swap SDK to go-azure-sdk

b435453

ziyeqf mentioned this pull request Dec 5, 2022

azurerm_recovery_services_vault - support immutability property, support UserAssigned of identity property #19294

Closed

github-actions bot added dependencies service/recovery-services size/XL labels Dec 5, 2022

go mod vendor

85e592a

katbyte added the waiting-response label Dec 5, 2022

katbyte requested changes Dec 5, 2022

View reviewed changes

ziyeqf closed this Dec 6, 2022

github-actions bot removed the waiting-response label Dec 6, 2022

ziyeqf reopened this Dec 8, 2022

ziyeqf added 2 commits December 8, 2022 10:13

Merge remote-tracking branch 'hashi/main' into tengzh/swap_sdk/recove…

b45af77

…ry_vault

refresh vendor

bf410c3

github-actions bot added the service/stream-analytics label Dec 8, 2022

ziyeqf added 2 commits December 9, 2022 14:33

Merge remote-tracking branch 'hashi/main' into tengzh/swap_sdk/recove…

d40c277

…ry_vault

refresh vendor

92ed934

github-actions bot removed the service/stream-analytics label Dec 9, 2022

katbyte requested changes Dec 12, 2022

View reviewed changes

github-actions bot added the waiting-response label Dec 12, 2022

ziyeqf added 2 commits December 12, 2022 15:20

Merge branch 'main' into tengzh/swap_sdk/recovery_vault

3c08a29

go lint

4b4383a

github-actions bot removed the waiting-response label Dec 12, 2022

Merge branch 'main' into tengzh/swap_sdk/recovery_vault

513c3b4

ziyeqf force-pushed the tengzh/swap_sdk/recovery_vault branch from 211a13f to 513c3b4 Compare December 12, 2022 07:29

tombuildsstuff suggested changes Dec 12, 2022

View reviewed changes

github-actions bot added the waiting-response label Dec 12, 2022

ziyeqf mentioned this pull request Dec 13, 2022

add recoveryservices@2021-12-01 hashicorp/pandora#1929

Merged

swap config & storageconfig for recovery vault

3512139

refresh vendor

5bdb418

github-actions bot removed the waiting-response label Jan 11, 2023

ziyeqf added 3 commits January 11, 2023 13:50

Merge remote-tracking branch 'hashi/main' into tengzh/swap_sdk/recove…

8b7afaa

…ry_vault

merge main

46e2769

update per review

519df04

bug fix

9e4da57

katbyte approved these changes Jan 17, 2023

View reviewed changes

katbyte merged commit 7c4d7a7 into hashicorp:main Jan 17, 2023

github-actions bot added this to the v3.40.0 milestone Jan 17, 2023

ziyeqf deleted the tengzh/swap_sdk/recovery_vault branch January 18, 2023 01:34

github-actions bot locked as resolved and limited conversation to collaborators Feb 20, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

depencies: `azurerm_recovery_services_vault` - swap SDK to `go-azure-sdk` #19551

depencies: `azurerm_recovery_services_vault` - swap SDK to `go-azure-sdk` #19551

ziyeqf commented Dec 5, 2022 •

edited

Loading

katbyte left a comment

ziyeqf commented Dec 6, 2022

ziyeqf commented Dec 8, 2022

katbyte left a comment

tombuildsstuff left a comment

ziyeqf commented Jan 11, 2023 •

edited

Loading

katbyte left a comment

github-actions bot commented Jan 20, 2023

github-actions bot commented Feb 20, 2023

depencies: azurerm_recovery_services_vault - swap SDK to go-azure-sdk #19551

depencies: azurerm_recovery_services_vault - swap SDK to go-azure-sdk #19551

Conversation

ziyeqf commented Dec 5, 2022 • edited Loading

Test

katbyte left a comment

Choose a reason for hiding this comment

ziyeqf commented Dec 6, 2022

ziyeqf commented Dec 8, 2022

katbyte left a comment

Choose a reason for hiding this comment

tombuildsstuff left a comment

Choose a reason for hiding this comment

ziyeqf commented Jan 11, 2023 • edited Loading

Test result after modification

katbyte left a comment

Choose a reason for hiding this comment

github-actions bot commented Jan 20, 2023

github-actions bot commented Feb 20, 2023

depencies: `azurerm_recovery_services_vault` - swap SDK to `go-azure-sdk` #19551

depencies: `azurerm_recovery_services_vault` - swap SDK to `go-azure-sdk` #19551

ziyeqf commented Dec 5, 2022 •

edited

Loading

ziyeqf commented Jan 11, 2023 •

edited

Loading