-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azurerm_cdn_frontdoor_profile
- missing identity settings
#20289
Comments
azurerm_cdn_frontdoor_profile
- missing identity settings
@AlmirKadric, thanks for opening this issue. When I first implemented this resource I had originally added these settings, however I was told by the service team to remove them as the feature was not 100% complete as of GA of the REST API's. I will check back with the service team and ask them if this is currently supported. Thanks again for the issue. 🚀 UPDATE (February 6, 2023):I have confirmed with the service team that this functionality is currently in |
Hi, |
The (Preview) suffix next to Identity has disappeared from the Azure Portal GUI, however there is no official announcement that I can find. |
@WodansSon Please be advised of the below. |
@manicminer could you please assist to remove the upstream/microsoft tag as it is no longer the case. |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
Hi, Do you have any news ? |
@WodansSon It's been 3 month since API is in GA. We need to decide to go to AzAPI provider or wait for AzureRM provider to be updated. Please provide some timeframes so we can make intelligent decisions. |
We have the same issue, identity as a feature is there but not present in the terraform module. It's still missing. |
Need this feature too .. |
I think maybe we need to log a new issue to get some attention? This one is still marked as upstream/microsoft. I don't think anyone is going to look at it when it has this tag. The tag has been incorrect for 4+ months. |
I am working on getting the new API implemented in the SDK so I can implement the Update:The swagger has an issue and cannot be imported into the SDK. I am now working with the service team to get their swagger fixed so we can implement the new version in the SDK and then expose the Additional:I am still negotiating with the service team to get an ETA on getting a fix for the swagger issue merged into main. |
Re-adding the |
Any updates on this issue? |
The service team is still working with the Azure Breaking Change Review Board on a path forward. I will update this issue when more information is available. |
Has anyone tried adding a user assigned identity to front door using az api? I can't seem to get that working too.
What am I doing wrong here? The resource provisions without an error but can't see a UMI added to the service. |
The
Anyway, I am looking forward to have this natively in the azurerm provider. |
Any update on this issue? |
Any update on this? My current work around is to manually turn on Identity after the FD resource is created and give it access to my Keyvault for get secrets, then re-apply my terraform script - not ideal, but workable |
@stevef51 why doing anything manually, when you can use the |
How are you using azure_role_assignments after the managed identity creation? Can you give a code example? |
It's pretty easy, please see:
I hope it helps. |
Hi @WodansSon its been a while, was the fix on swagger now merged into main, so you could proceed? |
has something changed?
|
According to the API docs, nothing changed: https://learn.microsoft.com/en-us/rest/api/cdn/profiles/create?view=rest-cdn-2024-02-01&tabs=HTTP#managedserviceidentity Almost the same code works for me all the time.
|
Yes, azapi provider v2 was released, with breaking changes. |
I solved removing the jsonencode wrapping I'll have a look at azapi changes
…On Sat, Nov 2, 2024, 13:39 Stephan ***@***.***> wrote:
It's pretty easy, please see:
resource "azurerm_user_assigned_identity" "this" {
name = var.front_door.identity_name
resource_group_name = var.resource_group_name
location = var.region
lifecycle {
ignore_changes = [tags]
}
}
resource "azurerm_role_assignment" "this" {
scope = var.front_door.key_vault_id
role_definition_name = "Key Vault Secrets Officer"
principal_id = azurerm_user_assigned_identity.this.principal_id
}
resource "azurerm_cdn_frontdoor_profile" "this" {
name = var.front_door.name
resource_group_name = var.resource_group_name
sku_name = "Standard_AzureFrontDoor"
lifecycle {
ignore_changes = [tags]
}
}
resource "azapi_update_resource" "this" {
type = ***@***.***"
resource_id = azurerm_cdn_frontdoor_profile.this.id
body = jsonencode({
identity = {
type = "UserAssigned"
userAssignedIdentities = {
"${azurerm_user_assigned_identity.this.id}" = {}
}
}
})
}
resource "azurerm_cdn_frontdoor_secret" "this" {
name = var.front_door.secret_name
cdn_frontdoor_profile_id = azurerm_cdn_frontdoor_profile.this.id
secret {
customer_certificate {
key_vault_certificate_id = var.front_door.ssl_certificate_id
}
}
depends_on = [
azurerm_role_assignment.this,
azapi_update_resource.this
]
}
I hope it helps.
has something changed? today i was updating some code for frontdoor and
got this:
│ Error: Invalid Type
│
│ with azapi_update_resource.this,
│ on frontdoor.tf line 29, in resource "azapi_update_resource" "this":
│ 29: body = jsonencode({
│ 30: identity = {
│ 31: type = "UserAssigned"
│ 32: userAssignedIdentities = {
│ 33: "${azurerm_user_assigned_identity.this.id}" = {}
│ 34: }
│ 35: }
│ 36: })
│
│ The value must not be a string
Yes, azapi provider v2 was released, with breaking changes.
https://github.com/Azure/terraform-provider-azapi/blob/main/CHANGELOG.md
Guess you do not controll which version is used, so the newest was taken
having this effekt
—
Reply to this email directly, view it on GitHub
<#20289 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AALOV2XWMNYE6OIEZYSMMMLZ6TBYPAVCNFSM6AAAAAAUPYXNNCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINJSHE3TONZZGA>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
@skytime-sh, I am currently looking at getting this implemented in the AzureRM provider. |
NOTE: Getting the |
Is there an existing issue for this?
Community Note
Terraform Version
1.3.6
AzureRM Provider Version
3.41.0
Affected Resource(s)/Data Source(s)
azurerm_cdn_frontdoor_profile
Terraform Configuration Files
Debug Output/Panic Output
Expected Behaviour
I should be allowed to set the identity on a azurerm_cdn_frontdoor_profile resource
Actual Behaviour
I get an error and this seems to not be supported yet
Steps to Reproduce
Important Factoids
No response
References
No response
The text was updated successfully, but these errors were encountered: