Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_kubernetes_cluster - service_mesh_profile added #21516

Merged
merged 8 commits into from
Apr 25, 2023

Conversation

aristosvo
Copy link
Contributor

@aristosvo aristosvo commented Apr 24, 2023

Fixes #21517

Preview

This is a preview feature, to make the test pass please execute az feature register --namespace "Microsoft.ContainerService" --name "AzureServiceMeshPreview" and reregister the container provider after this is done (az provider register --namespace Microsoft.ContainerService).

ToDo

  • Run basic test without Preview feature enabled
  • Add update/disabling test
  • Add link to Preview explainer in the docs

Acceptance Tests

❯ go install && make acctests SERVICE='containers' TESTARGS='-run=TestAccKubernetesCluster_serviceMeshProfile'
==> Checking that code complies with gofmt requirements...
./internal/services/containers/kubernetes_cluster_network_resource_test.go:1042:78: missing ',' in parameter list
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./internal/services/containers -run=TestAccKubernetesCluster_serviceMeshProfile -timeout 180m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccKubernetesCluster_serviceMeshProfile
=== PAUSE TestAccKubernetesCluster_serviceMeshProfile
=== CONT  TestAccKubernetesCluster_serviceMeshProfile
--- PASS: TestAccKubernetesCluster_serviceMeshProfile (679.90s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/containers 682.012s

Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @aristosvo LGTM 🌳

@stephybun stephybun merged commit 5dcb274 into hashicorp:main Apr 25, 2023
@github-actions github-actions bot added this to the v3.54.0 milestone Apr 25, 2023
stephybun added a commit that referenced this pull request Apr 25, 2023
@github-actions
Copy link

This functionality has been released in v3.54.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

github-actions bot commented Jun 1, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for managed Istio Service Mesh on AKS
2 participants