Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_kubernetes_cluster - service_mesh_profile added #21516

Merged
merged 8 commits into from
Apr 25, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,54 @@ func TestAccKubernetesCluster_advancedNetworkingKubenet(t *testing.T) {
})
}

func TestAccKubernetesCluster_serviceMeshProfile(t *testing.T) {
data := acceptance.BuildTestData(t, "azurerm_kubernetes_cluster", "test")
r := KubernetesClusterResource{}

data.ResourceTest(t, r, []acceptance.TestStep{
{
Config: r.serviceMeshProfile(data),
Check: acceptance.ComposeTestCheckFunc(
check.That(data.ResourceName).ExistsInAzure(r),
check.That(data.ResourceName).Key("network_profile.0.network_plugin").HasValue("kubenet"),
),
},
data.ImportStep(),
})
}

func TestAccKubernetesCluster_serviceMeshProfileLifeCycle(t *testing.T) {
data := acceptance.BuildTestData(t, "azurerm_kubernetes_cluster", "test")
r := KubernetesClusterResource{}

data.ResourceTest(t, r, []acceptance.TestStep{
{
Config: r.serviceMeshProfileDisabled(data),
Check: acceptance.ComposeTestCheckFunc(
check.That(data.ResourceName).ExistsInAzure(r),
check.That(data.ResourceName).Key("network_profile.0.network_plugin").HasValue("kubenet"),
),
},
data.ImportStep(),
{
Config: r.serviceMeshProfile(data),
Check: acceptance.ComposeTestCheckFunc(
check.That(data.ResourceName).ExistsInAzure(r),
check.That(data.ResourceName).Key("network_profile.0.network_plugin").HasValue("kubenet"),
),
},
data.ImportStep(),
{
Config: r.serviceMeshProfileDisabled(data),
Check: acceptance.ComposeTestCheckFunc(
check.That(data.ResourceName).ExistsInAzure(r),
check.That(data.ResourceName).Key("network_profile.0.network_plugin").HasValue("kubenet"),
),
},
data.ImportStep(),
})
}

func TestAccKubernetesCluster_advancedNetworkingIPVersionsIPv4(t *testing.T) {
data := acceptance.BuildTestData(t, "azurerm_kubernetes_cluster", "test")
r := KubernetesClusterResource{}
Expand Down Expand Up @@ -1023,6 +1071,130 @@ resource "azurerm_kubernetes_cluster" "test" {
`, data.RandomInteger, data.Locations.Primary, data.RandomInteger, data.RandomInteger, data.RandomInteger, data.RandomInteger, data.RandomInteger, networkPlugin)
}

func (KubernetesClusterResource) serviceMeshProfile(data acceptance.TestData) string {
return fmt.Sprintf(`
provider "azurerm" {
features {}
}

resource "azurerm_resource_group" "test" {
name = "acctestRG-aks-%[1]d"
location = "%[2]s"
}

resource "azurerm_virtual_network" "test" {
name = "acctestvirtnet%[1]d"
address_space = ["10.1.0.0/16", "fd00:db8:deca::/48"]
location = azurerm_resource_group.test.location
resource_group_name = azurerm_resource_group.test.name
}

resource "azurerm_subnet" "test" {
name = "acctestsubnet%[1]d"
resource_group_name = azurerm_resource_group.test.name
virtual_network_name = azurerm_virtual_network.test.name
address_prefixes = ["10.1.0.0/24", "fd00:db8:deca:deed::/64"]
}

resource "azurerm_kubernetes_cluster" "test" {
name = "acctestaks%[1]d"
location = azurerm_resource_group.test.location
resource_group_name = azurerm_resource_group.test.name
dns_prefix = "acctestaks%[1]d"

linux_profile {
admin_username = "acctestuser%[1]d"

ssh_key {
key_data = "ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAABAQCqaZoyiz1qbdOQ8xEf6uEu1cCwYowo5FHtsBhqLoDnnp7KUTEBN+L2NxRIfQ781rxV6Iq5jSav6b2Q8z5KiseOlvKA/RF2wqU0UPYqQviQhLmW6THTpmrv/YkUCuzxDpsH7DUDhZcwySLKVVe0Qm3+5N2Ta6UYH3lsDf9R9wTP2K/+vAnflKebuypNlmocIvakFWoZda18FOmsOoIVXQ8HWFNCuw9ZCunMSN62QGamCe3dL5cXlkgHYv7ekJE15IA9aOJcM7e90oeTqo+7HTcWfdu0qQqPWY5ujyMw/llas8tsXY85LFqRnr3gJ02bAscjc477+X+j/gkpFoN1QEmt terraform@demo.tld"
}
}

default_node_pool {
name = "default"
node_count = 2
vm_size = "Standard_DS2_v2"
vnet_subnet_id = azurerm_subnet.test.id
}

identity {
type = "SystemAssigned"
}

network_profile {
network_plugin = "kubenet"
dns_service_ip = "10.10.0.10"
docker_bridge_cidr = "172.18.0.1/16"
service_cidr = "10.10.0.0/16"
}

service_mesh_profile {
mode = "Istio"
}
}
`, data.RandomInteger, data.Locations.Primary)
}

func (KubernetesClusterResource) serviceMeshProfileDisabled(data acceptance.TestData) string {
return fmt.Sprintf(`
provider "azurerm" {
features {}
}

resource "azurerm_resource_group" "test" {
name = "acctestRG-aks-%[1]d"
location = "%[2]s"
}

resource "azurerm_virtual_network" "test" {
name = "acctestvirtnet%[1]d"
address_space = ["10.1.0.0/16", "fd00:db8:deca::/48"]
location = azurerm_resource_group.test.location
resource_group_name = azurerm_resource_group.test.name
}

resource "azurerm_subnet" "test" {
name = "acctestsubnet%[1]d"
resource_group_name = azurerm_resource_group.test.name
virtual_network_name = azurerm_virtual_network.test.name
address_prefixes = ["10.1.0.0/24", "fd00:db8:deca:deed::/64"]
}

resource "azurerm_kubernetes_cluster" "test" {
name = "acctestaks%[1]d"
location = azurerm_resource_group.test.location
resource_group_name = azurerm_resource_group.test.name
dns_prefix = "acctestaks%[1]d"

linux_profile {
admin_username = "acctestuser%[1]d"

ssh_key {
key_data = "ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAABAQCqaZoyiz1qbdOQ8xEf6uEu1cCwYowo5FHtsBhqLoDnnp7KUTEBN+L2NxRIfQ781rxV6Iq5jSav6b2Q8z5KiseOlvKA/RF2wqU0UPYqQviQhLmW6THTpmrv/YkUCuzxDpsH7DUDhZcwySLKVVe0Qm3+5N2Ta6UYH3lsDf9R9wTP2K/+vAnflKebuypNlmocIvakFWoZda18FOmsOoIVXQ8HWFNCuw9ZCunMSN62QGamCe3dL5cXlkgHYv7ekJE15IA9aOJcM7e90oeTqo+7HTcWfdu0qQqPWY5ujyMw/llas8tsXY85LFqRnr3gJ02bAscjc477+X+j/gkpFoN1QEmt terraform@demo.tld"
}
}

default_node_pool {
name = "default"
node_count = 2
vm_size = "Standard_DS2_v2"
vnet_subnet_id = azurerm_subnet.test.id
}

identity {
type = "SystemAssigned"
}

network_profile {
network_plugin = "kubenet"
dns_service_ip = "10.10.0.10"
docker_bridge_cidr = "172.18.0.1/16"
service_cidr = "10.10.0.0/16"
}
}
`, data.RandomInteger, data.Locations.Primary)
}

func (KubernetesClusterResource) advancedNetworkingConfigWithIPVersions(data acceptance.TestData, ipVersions []string) string {
temp := make([]string, 0)
for _, v := range ipVersions {
Expand Down
103 changes: 85 additions & 18 deletions internal/services/containers/kubernetes_cluster_resource.go
Original file line number Diff line number Diff line change
Expand Up @@ -1093,6 +1093,23 @@ func resourceKubernetesCluster() *pluginsdk.Resource {
Default: true,
},

"service_mesh_profile": {
Type: pluginsdk.TypeList,
Optional: true,
MaxItems: 1,
Elem: &pluginsdk.Resource{
Schema: map[string]*pluginsdk.Schema{
"mode": {
Type: pluginsdk.TypeString,
Required: true,
ValidateFunc: validation.StringInSlice([]string{
string(managedclusters.ServiceMeshModeIstio),
}, false),
},
},
},
},

"service_principal": {
Type: pluginsdk.TypeList,
Optional: true,
Expand Down Expand Up @@ -1434,24 +1451,25 @@ func resourceKubernetesClusterCreate(d *pluginsdk.ResourceData, meta interface{}
Tier: utils.ToPtr(managedclusters.ManagedClusterSKUTier(d.Get("sku_tier").(string))),
},
Properties: &managedclusters.ManagedClusterProperties{
ApiServerAccessProfile: apiAccessProfile,
AadProfile: azureADProfile,
AddonProfiles: addonProfiles,
AgentPoolProfiles: agentProfiles,
AutoScalerProfile: autoScalerProfile,
AzureMonitorProfile: azureMonitorProfile,
DnsPrefix: utils.String(dnsPrefix),
EnableRBAC: utils.Bool(d.Get("role_based_access_control_enabled").(bool)),
KubernetesVersion: utils.String(kubernetesVersion),
LinuxProfile: linuxProfile,
WindowsProfile: windowsProfile,
NetworkProfile: networkProfile,
NodeResourceGroup: utils.String(nodeResourceGroup),
PublicNetworkAccess: &publicNetworkAccess,
DisableLocalAccounts: utils.Bool(d.Get("local_account_disabled").(bool)),
HTTPProxyConfig: httpProxyConfig,
OidcIssuerProfile: oidcIssuerProfile,
SecurityProfile: securityProfile,
ApiServerAccessProfile: apiAccessProfile,
AadProfile: azureADProfile,
AddonProfiles: addonProfiles,
AgentPoolProfiles: agentProfiles,
AutoScalerProfile: autoScalerProfile,
AzureMonitorProfile: azureMonitorProfile,
DnsPrefix: utils.String(dnsPrefix),
EnableRBAC: utils.Bool(d.Get("role_based_access_control_enabled").(bool)),
KubernetesVersion: utils.String(kubernetesVersion),
LinuxProfile: linuxProfile,
WindowsProfile: windowsProfile,
NetworkProfile: networkProfile,
NodeResourceGroup: utils.String(nodeResourceGroup),
PublicNetworkAccess: &publicNetworkAccess,
DisableLocalAccounts: utils.Bool(d.Get("local_account_disabled").(bool)),
HTTPProxyConfig: httpProxyConfig,
OidcIssuerProfile: oidcIssuerProfile,
SecurityProfile: securityProfile,

StorageProfile: storageProfile,
WorkloadAutoScalerProfile: workloadAutoscalerProfile,
},
Expand Down Expand Up @@ -1522,6 +1540,10 @@ func resourceKubernetesClusterCreate(d *pluginsdk.ResourceData, meta interface{}
parameters.Properties.IngressProfile = ingressProfile
}

if serviceMeshProfile := expandKubernetesClusterServiceMeshProfile(d.Get("service_mesh_profile").([]interface{}), &managedclusters.ServiceMeshProfile{}); serviceMeshProfile != nil {
parameters.Properties.ServiceMeshProfile = serviceMeshProfile
}

future, err := client.CreateOrUpdate(ctx, id, parameters)
if err != nil {
return fmt.Errorf("creating %s: %+v", id, err)
Expand Down Expand Up @@ -1829,6 +1851,12 @@ func resourceKubernetesClusterUpdate(d *pluginsdk.ResourceData, meta interface{}
existing.Model.Properties.NetworkProfile.NatGatewayProfile = &natGatewayProfile
}
}
if d.HasChange("service_mesh_profile") {
updateCluster = true
if serviceMeshProfile := expandKubernetesClusterServiceMeshProfile(d.Get("service_mesh_profile").([]interface{}), existing.Model.Properties.ServiceMeshProfile); serviceMeshProfile != nil {
existing.Model.Properties.ServiceMeshProfile = serviceMeshProfile
}
}

if d.HasChange("tags") {
updateCluster = true
Expand Down Expand Up @@ -2254,6 +2282,11 @@ func resourceKubernetesClusterRead(d *pluginsdk.ResourceData, meta interface{})
return fmt.Errorf("setting `monitor_metrics`: %+v", err)
}

serviceMeshProfile := flattenKubernetesClusterAzureServiceMeshProfile(props.ServiceMeshProfile)
if err := d.Set("service_mesh_profile", serviceMeshProfile); err != nil {
return fmt.Errorf("setting `service_mesh_profile`: %+v", err)
}

flattenedDefaultNodePool, err := FlattenDefaultNodePool(props.AgentPoolProfiles, d)
if err != nil {
return fmt.Errorf("flattening `default_node_pool`: %+v", err)
Expand Down Expand Up @@ -3752,6 +3785,28 @@ func base64IsEncoded(data string) bool {
return err == nil
}

func expandKubernetesClusterServiceMeshProfile(input []interface{}, existing *managedclusters.ServiceMeshProfile) *managedclusters.ServiceMeshProfile {
if (input == nil) || len(input) == 0 {
// explicitly disable istio if it was enabled before
if existing != nil && existing.Mode == managedclusters.ServiceMeshModeIstio {
return &managedclusters.ServiceMeshProfile{
Mode: managedclusters.ServiceMeshModeDisabled,
}
}

return nil
}

raw := input[0].(map[string]interface{})
profile := managedclusters.ServiceMeshProfile{}
if managedclusters.ServiceMeshMode(raw["mode"].(string)) == managedclusters.ServiceMeshModeIstio {
profile.Mode = managedclusters.ServiceMeshMode(raw["mode"].(string))
profile.Istio = &managedclusters.IstioServiceMesh{}
}

return &profile
}

func expandKubernetesClusterIngressProfile(d *pluginsdk.ResourceData, input []interface{}) *managedclusters.ManagedClusterIngressProfile {
if len(input) == 0 && d.HasChange("web_app_routing") {
return &managedclusters.ManagedClusterIngressProfile{
Expand Down Expand Up @@ -3822,6 +3877,18 @@ func expandKubernetesClusterAzureMonitorProfile(input []interface{}) *managedclu
}
}

func flattenKubernetesClusterAzureServiceMeshProfile(input *managedclusters.ServiceMeshProfile) []interface{} {
if input == nil || input.Mode != managedclusters.ServiceMeshModeIstio {
return nil
}

return []interface{}{
map[string]interface{}{
"mode": string(managedclusters.ServiceMeshModeIstio),
},
}
}

func flattenKubernetesClusterAzureMonitorProfile(input *managedclusters.ManagedClusterAzureMonitorProfile) []interface{} {
if input == nil || input.Metrics == nil || !input.Metrics.Enabled {
return nil
Expand Down
10 changes: 10 additions & 0 deletions website/docs/r/kubernetes_cluster.html.markdown
Original file line number Diff line number Diff line change
Expand Up @@ -207,6 +207,10 @@ resource "azurerm_kubernetes_cluster" "example" {

```

* `service_mesh_profile` - (Optional) A `service_mesh_profile` block as defined below.

-> **Note:** This requires that the Preview Feature `Microsoft.ContainerService/AzureServiceMeshPreview` is enabled and the Resource Provider is re-registered, see [the documentation](https://learn.microsoft.com/en-us/azure/aks/istio-deploy-addon#register-the-azureservicemeshpreview-feature-flag) for more information.

* `workload_autoscaler_profile` - (Optional) A `workload_autoscaler_profile` block defined below.

* `workload_identity_enabled` - (Optional) Specifies whether Azure AD Workload Identity should be enabled for the Cluster. Defaults to `false`.
Expand Down Expand Up @@ -702,6 +706,12 @@ An `ingress_application_gateway` block supports the following:

---

A `service_mesh_profile` block supports the following:

* `mode` - (Required) The mode of the service mesh. Possible value is `Istio`.

---

A `service_principal` block supports the following:

* `client_id` - (Required) The Client ID for the Service Principal.
Expand Down