Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azurerm_key_vault_managed_hardware_security_module - support for activating an HSM through security_domain_key_vault_certificate_ids #22162

Merged
merged 7 commits into from
Jun 26, 2023
Merged

azurerm_key_vault_managed_hardware_security_module - support for activating an HSM through security_domain_key_vault_certificate_ids #22162

merged 7 commits into from
Jun 26, 2023

Conversation

mbfrahry
Copy link
Member

Supersedes #20855

@wuxu92 wuxu92 mentioned this pull request Jun 15, 2023
Closed
katbyte
katbyte approved these changes Jun 16, 2023
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🔆

@jackofallops
Copy link
Member

Tests look good

image

@jackofallops jackofallops merged commit 397035c into main Jun 26, 2023
@jackofallops jackofallops deleted the wuxu92-mhsm2/active branch June 26, 2023 12:57
@github-actions github-actions bot added this to the v3.63.0 milestone Jun 26, 2023
jackofallops added a commit that referenced this pull request Jun 26, 2023
@jackofallops
Update CHANGELOG for #22162
8420db0
@baaym baaym mentioned this pull request Aug 16, 2023
Closed
1 task
@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@katbyte katbyte katbyte approved these changes

Assignees
No one assigned
Labels
documentation enhancement service/key-vault Key Vault size/XL
Projects
None yet
Milestone
v3.63.0
Development

Successfully merging this pull request may close these issues.
5 participants
@mbfrahry @jackofallops @katbyte @stephybun @wuxu92