Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Resource: azurerm_key_vault_role_definition, azurerm_key_vault_role_assignment #20976

Closed
wants to merge 8 commits into from

Conversation

wuxu92
Copy link
Contributor

@wuxu92 wuxu92 commented Mar 16, 2023

dependent on #20855

resolves #20112.

To Support creating key for Managed HSM, add two resource and one data resource. Spilt from #20930

@favoretti
Copy link
Collaborator

Out of curiosity - is this an HSM-only thing or something normal keyvaults would support too?

@wuxu92
Copy link
Contributor Author

wuxu92 commented Mar 18, 2023

Out of curiosity - is this an HSM-only thing or something normal keyvaults would support too?

according to the swagger definition description, it should be used only for HSMs. more details here: https://learn.microsoft.com/en-us/azure/key-vault/managed-hsm/role-management

@katbyte
Copy link
Collaborator

katbyte commented Apr 2, 2023

@wuxu92 - should that not mean the resources names should have a reference to managed HSM so that is clear?

@katbyte
Copy link
Collaborator

katbyte commented Jun 12, 2023

@wuxu92 - is this still being worked on?

@wuxu92
Copy link
Contributor Author

wuxu92 commented Jun 12, 2023

@katbyte since #20855 has been merged, I will update this PR to ready in the next few days.

@wuxu92
Copy link
Contributor Author

wuxu92 commented Jun 15, 2023

@katbyte sorry just noticed that this PR dependent on #22162. will continue working on this when #22162 merged. maybe I should close this PR now. will open a new one later.

@wuxu92 wuxu92 closed this Jun 15, 2023
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Managed HSM role assignments
4 participants