#24317: Support preferred_data_persistence_auth_method for azurerm_redis_cache resource

[harshavmb]

Support preferred_data_persistence_auth_method for azurerm_redis_cache resource.

Fixes #24317.

[catriona-m]

Hi @harshavmb thanks for submitting this. This is looking good so far but could we include this new property in the tests? Thanks!

[harshavmb]

Hi @catriona-m ,

I've added the check now.

[catriona-m]

Hi @harshavmb thanks for updating this, however it looks like there is a test failure that needs to be addressed:

Test ended in panic.
------- Stdout: -------
=== RUN   TestAccRedisCacheDataSource_standard
=== PAUSE TestAccRedisCacheDataSource_standard
=== CONT  TestAccRedisCacheDataSource_standard
------- Stderr: -------
panic: Invalid address to set: []string{"redis_configuration", "0", "preferred_data_persistence_auth_method"}

[harshavmb]

Hi @harshavmb thanks for updating this, however it looks like there is a test failure that needs to be addressed:

Test ended in panic.
------- Stdout: -------
=== RUN   TestAccRedisCacheDataSource_standard
=== PAUSE TestAccRedisCacheDataSource_standard
=== CONT  TestAccRedisCacheDataSource_standard
------- Stderr: -------
panic: Invalid address to set: []string{"redis_configuration", "0", "preferred_data_persistence_auth_method"}

Hi @catriona-m ,

I added a new test case for this field. Could you please retest & let me know if this worked?

Thanks,
Harsha

[katbyte]

Looks like we still have a test failure:

Test ended in panic.

------- Stdout: -------
=== RUN   TestAccRedisCacheDataSource_standard
=== PAUSE TestAccRedisCacheDataSource_standard
=== CONT  TestAccRedisCacheDataSource_standard

------- Stderr: -------
panic: Invalid address to set: []string{"redis_configuration", "0", "data_persistence_authentication_method"}

goroutine 1978 [running]:
github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema.(*ResourceData).Set(0xc004bdb580, {0x8bbfe5d, 0x13}, {0x78468c0, 0xc00137e570})
	/opt/teamcity-agent/work/3337027aeff310bf/vendor/github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema/resource_data.go:233 +0x2b5
github.com/hashicorp/terraform-provider-azurerm/internal/services/redis.dataSourceRedisCacheRead(0x0?, {0x7bd03a0?, 0xc003ef5680?})
	/opt/teamcity-agent/work/3337027aeff310bf/internal/services/redis/redis_cache_data_source.go:311 +0xf14
github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema.(*Resource).read(0x9442bc8?, {0x9442bc8?, 0xc002703a70?}, 0xd?, {0x7bd03a0?, 0xc003ef5680?})
	/opt/teamcity-agent/work/3337027aeff310bf/vendor/github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema/resource.go:783 +0x163
github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema.(*Resource).ReadDataApply(0xc00109a1c0, {0x9442bc8, 0xc002703a70}, 0xc004bdb480, {0x7bd03a0, 0xc003ef5680})
	/opt/teamcity-agent/work/3337027aeff310bf/vendor/github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema/resource.go:1015 +0x149
github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema.(*GRPCProviderServer).ReadDataSource(0xc003cee4c8, {0x9442bc8?, 0xc0027039e0?}, 0xc004eeb2e0)
	/opt/teamcity-agent/work/3337027aeff310bf/vendor/github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema/grpc_provider.go:1237 +0x366
github.com/hashicorp/terraform-plugin-go/tfprotov5/tf5server.(*server).ReadDataSource(0xc00497a1e0, {0x9442bc8?, 0xc002703020?}, 0xc004876f50)
	/opt/teamcity-agent/work/3337027aeff310bf/vendor/github.com/hashicorp/terraform-plugin-go/tfprotov5/tf5server/server.go:699 +0x3df
github.com/hashicorp/terraform-plugin-go/tfprotov5/internal/tfplugin5._Provider_ReadDataSource_Handler({0x87c5be0?, 0xc00497a1e0}, {0x9442bc8, 0xc002703020}, 0xc00506d650, 0x0)
	/opt/teamcity-agent/work/3337027aeff310bf/vendor/github.com/hashicorp/terraform-plugin-go/tfprotov5/internal/tfplugin5/tfplugin5_grpc.pb.go:503 +0x169
google.golang.org/grpc.(*Server).processUnaryRPC(0xc002ec05a0, {0x9469ee0, 0xc0022ec000}, 0xc004c4fc20, 0xc0015d3020, 0xef91c28, 0x0)
	/opt/teamcity-agent/work/3337027aeff310bf/vendor/google.golang.org/grpc/server.go:1374 +0xde7
google.golang.org/grpc.(*Server).handleStream(0xc002ec05a0, {0x9469ee0, 0xc0022ec000}, 0xc004c4fc20, 0x0)
	/opt/teamcity-agent/work/3337027aeff310bf/vendor/google.golang.org/grpc/server.go:1751 +0x9e7
google.golang.org/grpc.(*Server).serveStreams.func1.1()
	/opt/teamcity-agent/work/3337027aeff310bf/vendor/google.golang.org/grpc/server.go:986 +0xbb
created by google.golang.org/grpc.(*Server).serveStreams.func1 in goroutine 340
	/opt/teamcity-agent/work/3337027aeff310bf/vendor/google.golang.org/grpc/server.go:997 +0x145```

[harshavmb]

Thanks @katbyte ,

I paid bit more attention to the error message this time & found azurerm_redis_cache datasource having dependency on flattenRedisConfiguration function. I fixed the testcase. Logs from my run..

harsha@dev terraform-provider-azurerm % make acctests SERVICE='redis' TESTARGS='-run=TestAccRedisCacheDataSource_standard' TESTTIMEOUT='60m'
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./internal/services/redis -run=TestAccRedisCacheDataSource_standard -timeout 60m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccRedisCacheDataSource_standard
=== PAUSE TestAccRedisCacheDataSource_standard
=== CONT  TestAccRedisCacheDataSource_standard

--- PASS: TestAccRedisCacheDataSource_standard (1640.70s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/redis 1644.867s

[catriona-m]

Hi @harshavmb, it looks like this test is passing now, thanks! LGTM!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.