azurerm_servicebus_namespace - support for the premium_messaging_partitions property

[xiaxyi]

part of the MS vanguard, the premium namespace is now support messaging partitions, add the feature to terraform as well.

acc tests:

--- PASS: TestAccAzureRMServiceBusNamespace_premiumCapacity (107.95s)
--- PASS: TestAccAzureRMServiceBusNamespace_premiumMessagingPartition (107.95s)

fix #24597

For the accepted value and the validation part, in theory, we shouldn't add 0 into the acceptable list because the feature only applies to servicebus premium namespace, not to the standard/ basic namespace, however, api will add 0 value for the standard/basic namespaces, as a result, we'll see diff like 0->null during the second apply.

For the default value, 0 is for the standard/basic namespace while 1 is for the premium namespace. we need to add the validation to check if users are trying to set 0 for the premium namespace, if they do, we throw error before the api does. Things are the same for the standard/ basic namespace, but we check the >0 value.

Product information: https://learn.microsoft.com/en-us/azure/service-bus-messaging/enable-partitions-premium

[jackofallops]

Thanks @xiaxyi - There's some comments to take a look at below, as it appears there is some confusion about allowed values? Can you take a look?

[jackofallops]

Suggested change

	* `premium_messaging_partitions` - (Optional) Specifies the messaging partitions. When `sku` is `Premium`, messaging partitions can be `1`, `2`, `4`. When `sku` is `Basic` or `Standard`, messaging partitions can be `0` only. Changing this forces a new resource to be created.
	* `premium_messaging_partitions` - (Optional) Specifies the number of Premium Messaging Partitions. Only valid when `sku` is `Premium`. Possible values include `0`, `1`, `2`, and `4`. Defaults to `0`. Changing this forces a new resource to be created.

[jackofallops]

This defaults to 0 so should be omitted here?

Suggested change

premium_messaging_partitions = 0

[jackofallops]

This doesn't match the schema validation above?

[xiaxyi]

The validation error is for the premium namespaces

[jackofallops]

This doesn't match the schema validation above? The property defaults to 0 also.

[xiaxyi]

This is for the premium namespace, 0 is not a valid value for premium namespace.

[xiaxyi]

Thanks @jackofallops for reviewing this pr!

The feature is only available in service bus premium namespace but we still need to set it to 0 for the standard/ basic namespace

For premium namespace, the default value is 1, despite of the 0 value we put in the request body, like

[katbyte]

We have some test fialures

------- Stdout: -------
=== RUN   TestAccAzureRMServiceBusNamespacePairing_basic
=== PAUSE TestAccAzureRMServiceBusNamespacePairing_basic
=== CONT  TestAccAzureRMServiceBusNamespacePairing_basic
    testcase.go:113: Step 1/2 error: Error running apply: exit status 1
        
        Error: Service Bus SKU "Premium" only supports `premium_messaging_partitions` of 1, 2, 4
        
          with azurerm_servicebus_namespace.primary_namespace_test,
          on terraform_plugin_test.tf line 31, in resource "azurerm_servicebus_namespace" "primary_namespace_test":
          31: resource "azurerm_servicebus_namespace" "primary_namespace_test" {
        
        
        Error: Service Bus SKU "Premium" only supports `premium_messaging_partitions` of 1, 2, 4
        
          with azurerm_servicebus_namespace.secondary_namespace_test,
          on terraform_plugin_test.tf line 39, in resource "azurerm_servicebus_namespace" "secondary_namespace_test":
          39: resource "azurerm_servicebus_namespace" "secondary_namespace_test" {
        
--- FAIL: TestAccAzureRMServiceBusNamespacePairing_basic (48.64s)
FAIL

[katbyte]

can you please fix all failed test cases:

=== RUN   TestAccAzureRMServiceBusNamespace_networkRuleSet
=== PAUSE TestAccAzureRMServiceBusNamespace_networkRuleSet
=== CONT  TestAccAzureRMServiceBusNamespace_networkRuleSet
    testcase.go:113: Step 1/6 error: Error running apply: exit status 1
        
        Error: Service Bus SKU "Premium" only supports `premium_messaging_partitions` of 1, 2, 4
        
          with azurerm_servicebus_namespace.test,
          on terraform_plugin_test.tf line 43, in resource "azurerm_servicebus_namespace" "test":
          43: resource "azurerm_servicebus_namespace" "test" {
        
--- FAIL: TestAccAzureRMServiceBusNamespace_networkRuleSet (118.34s)
FAIL

------- Stdout: -------
=== RUN   TestAccServiceBusQueueAuthorizationRule_withAliasConnectionString
=== PAUSE TestAccServiceBusQueueAuthorizationRule_withAliasConnectionString
=== CONT  TestAccServiceBusQueueAuthorizationRule_withAliasConnectionString
    testcase.go:113: Step 1/3 error: Error running apply: exit status 1
        
        Error: Service Bus SKU "Premium" only supports `premium_messaging_partitions` of 1, 2, 4
        
          with azurerm_servicebus_namespace.primary_namespace_test,
          on terraform_plugin_test.tf line 31, in resource "azurerm_servicebus_namespace" "primary_namespace_test":
          31: resource "azurerm_servicebus_namespace" "primary_namespace_test" {
        
        
        Error: Service Bus SKU "Premium" only supports `premium_messaging_partitions` of 1, 2, 4
        
          with azurerm_servicebus_namespace.secondary_namespace_test,
          on terraform_plugin_test.tf line 44, in resource "azurerm_servicebus_namespace" "secondary_namespace_test":
          44: resource "azurerm_servicebus_namespace" "secondary_namespace_test" {
        
--- FAIL: TestAccServiceBusQueueAuthorizationRule_withAliasConnectionString (98.40s)
FAIL

[katbyte]

LGTM ⛈️

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.