Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for azurerm_orchestrated_virtual_machine_scale_set documentation adjustment #24963

Closed
1 task done
alselivonets opened this issue Feb 21, 2024 · 2 comments · Fixed by #24964
Closed
1 task done
Labels
Milestone

Comments

@alselivonets
Copy link
Contributor

alselivonets commented Feb 21, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment and review the contribution guide to help.

Description

In documentation for azurerm_orchestrated_virtual_machine_scale_set in argument reference block there's a misleading description of eviction_policy. It says:
"eviction_policy - (Optional) The Policy which should be used Virtual Machines are Evicted from the Scale Set. Possible values are Deallocate and Delete. Changing this forces a new resource to be created."

The Microsoft documentation says that eviction policy can be set only for Spot VMs. The description for eviction_policy argument should say:
"eviction_policy - (Optional) The Policy which should be used by Spot Virtual Machines that are Evicted from the Scale Set. Possible values are Deallocate and Delete. Changing this forces a new resource to be created."

See reference documentation below.

New or Affected Resource(s)/Data Source(s)

azurerm_orchestrated_virtual_machine_scale_set

Potential Terraform Configuration

No response

References

https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/resources/orchestrated_virtual_machine_scale_set
https://learn.microsoft.com/en-us/azure/virtual-machine-scale-sets/use-spot
https://learn.microsoft.com/en-us/dotnet/api/microsoft.azure.management.compute.models.virtualmachine.evictionpolicy

@alselivonets
Copy link
Contributor Author

Hi, @rcskosir. Could you please review above Pull Request?

@github-actions github-actions bot added this to the v3.93.0 milestone Feb 21, 2024
rizkybiz pushed a commit to rizkybiz/terraform-provider-azurerm that referenced this issue Feb 29, 2024
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
2 participants