Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure PostgreSQL Server storage sizes are invalid #324

Closed
hexadite-tomer opened this issue Sep 12, 2017 · 4 comments · Fixed by #329
Closed

Azure PostgreSQL Server storage sizes are invalid #324

hexadite-tomer opened this issue Sep 12, 2017 · 4 comments · Fixed by #329
Assignees

Comments

@hexadite-tomer
Copy link

The postgresql_server resource receives 'storage_mb' as an argument to set the capacity of the database. In the documentation and the code, the only 2 legitimate arguments are 51200 and 102400.

From /azurerm/resource_arm_postgresql_server.go:

"storage_mb": { Type: schema.TypeInt, Required: true, ForceNew: true, ValidateFunc: validateIntInSlice([]int{ 51200, 102400, }),

The issue is that azure receives as valid database sizes 51200 up to 947200 in increments of 128000, so for example 179200 is a legitimate value, and 102400 is not. Applying a template with 102400 as an argument will fail with an error from azure, and applying a template with 179200 as an argument will fail with an error from terraform.

The function should be updated to reflect all the legitimate values.

@tombuildsstuff
Copy link
Contributor

Hey @hexadite-tomer

Thanks for opening this issue :)

I can confirm this is an issue - when we were first building support for the PostgreSQL Resources, it was only possible to select 50GB or 100GB of storage, however it appears between finishing testing and shipping this that it's now possible to select another storage options.. as such we'll be sure to update the validation to reflect this.

Thanks!

@hexadite-tomer
Copy link
Author

Hey @tombuildsstuff

Thanks for the fast response. Looking forward to seeing the fix. Appreciate all your work!

@tombuildsstuff
Copy link
Contributor

Hey @hexadite-tomer

Just to let you know that I've opened #329 which includes a fix for this :)

Thanks!

@ghost
Copy link

ghost commented Apr 1, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants