Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Azure private-link resource creation via terraform? #4701

Closed
shankarsundaram opened this issue Oct 24, 2019 · 4 comments · Fixed by #4426 or #4493
Closed

Azure private-link resource creation via terraform? #4701

shankarsundaram opened this issue Oct 24, 2019 · 4 comments · Fixed by #4426 or #4493
Assignees
@WodansSon
Labels
new-data-source new-resource service/private-link
Milestone
v1.37.0

Comments

@shankarsundaram
Copy link

shankarsundaram commented Oct 24, 2019 •
edited by tombuildsstuff
Loading

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

when the azure private-link feature will be available in terraform?
More details about private-link is here,
https://docs.microsoft.com/en-us/azure/private-link/private-link-overview
@shankarsundaram shankarsundaram changed the title Azure private-link when this feature will be available in terraform? Azure private-link resource creation via terraform? Oct 24, 2019
@mybayern1974
Copy link
Collaborator

For private link service: #4426
For private endpoint: #4493

@WodansSon WodansSon self-assigned this Oct 30, 2019
This was referenced Oct 30, 2019
Merged
Merged
@tombuildsstuff tombuildsstuff mentioned this issue Nov 13, 2019
Closed
@WodansSon WodansSon added this to the v1.37.0 milestone Nov 22, 2019
WodansSon added a commit that referenced this issue Nov 22, 2019
@WodansSon
Private Link Service fixes #4701
a154848 
* Add new resources and data sources

* Manual fixup

* TOC tweaks

* Examples fix

* [WIP] Current Progress

* [WIP] Updates to code

* [WIP] gofmt

* [WIP] Final changes

* [WIP] Updated Tests and Docs

* [WIP] Updated test cases

* [WIP] fix test and lint

* [WIP] Update attribute

* [WIP] Progress

* [WIP] Progress

* Updates per PR

* Gofmt

* Updates for the new terraform-plugin-sdk

* Removed leading newline

* Updates per PR feedback

* A couple other things

* Gofmt validate

* Update Subnet documentation

* Fix schema and removed unused code refactor

* Fixed conflict

* Added some more validation

* Resource is good now

* Update name all private link endpoint attributes

* New datasource and refactor done

* Fix test and lint issues

* Updates per PR comments

* Add subbcategory to docs

* Updated name of policy enforcement

* Fix docs and example

* in progress

* Updates per Tom PR comment and test

* Update website/docs/r/subnet.html.markdown

Co-Authored-By: kt <kt@katbyte.me>

* Update website/docs/d/private_link_service.html.markdown

Co-Authored-By: kt <kt@katbyte.me>

* gofmt provider

* Add private link service datasource

* Updates per PR comments

* Updates per PR comments

* Added state wait code

* Fix test collision issue

* Update data source validation
@ghost
Copy link

ghost commented Nov 26, 2019

This has been released in version 1.37.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.37.0"
}
# ... other configuration ...

katbyte pushed a commit that referenced this issue Dec 3, 2019
@WodansSon @katbyte
New Resource: azurerm_private_link_endpoint New Data Source:… (#4493)
99ed814 
(fixes #4701 )
@mbashtovaya
Copy link

mbashtovaya commented Dec 11, 2019 •
edited
Loading

There is inconsistency with this implementation. Specifically, the same subnet can be used for both private link endpoint and private link service. When configuring via az cli both parameters are allowed to be set to --disable-private-endpoint-network-policies true and --disable-private-link-service-network-policies true for the same subnet.
The terraform validation as of now is failing stating: Error: "enforce_private_link_service_network_policies": conflicts with enforce_private_link_endpoint_network_policies.

@gambtho gambtho mentioned this issue Dec 17, 2019
Merged
@ghost
Copy link

ghost commented Dec 22, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Dec 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@WodansSon WodansSon

Labels
new-data-source new-resource service/private-link
Projects
None yet
Milestone
v1.37.0
5 participants
@tombuildsstuff @mbashtovaya @mybayern1974 @WodansSon @shankarsundaram