New Data Source/Resource: azurerm_dedicated_host_group
#5307
Conversation
There was a problem hiding this comment.
hey @magodo
Thanks for this PR - apologies for the delayed review here!
Taking a look through this is off to a good start, I've left some comments inline but if we can fix up the comments (and the tests pass) then this should otherwise be good 👍
Thanks!
azurerm/internal/services/compute/data_source_dedicated_host_group.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/compute/data_source_dedicated_host_group.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/compute/data_source_dedicated_host_group.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/compute/resource_arm_dedicated_host_group.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/compute/resource_arm_dedicated_host_group.go
Outdated
Show resolved
Hide resolved
Including: - Remove `host_ids` from data source - document/format
There was a problem hiding this comment.
hey @magodo
Thanks for pushing those changes - taking a look through this now LGTM; I hope you don't mind but I've pushed a commit to fix the linting so that we can get this merged 👍
Thanks!
tombuildsstuff
changed the title
azurerm_dedicated_host_group
|
Tests pass:
|
|
@tombuildsstuff Thank you 🎉 |
|
This has been released in version 1.41.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 1.41.0"
}
# ... other configuration ... |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
ghost
locked and limited conversation to collaborators
Add new resource
dedicated_host_group, which belongs to Compute Provider.Please refer to this link for more info.