-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Application Insights provider ignores application_type - always sets to "ASP.Net" #822
Comments
@tombuildsstuff I have been working on this - PR will be incoming soon! I just need to work out the best way to structure the tests to make sure all works as expected |
Fixes: hashicorp#822 This follows the work in the API to allow types like web, other, java, store, phone and ios ``` ```
Fixes: hashicorp#822 This follows the work in the API to allow types like web, other, java, store, phone and ios ``` ▶ acctests azurerm TestAccAzureRMApplicationInsights_ === RUN TestAccAzureRMApplicationInsights_importBasicWeb --- PASS: TestAccAzureRMApplicationInsights_importBasicWeb (99.07s) === RUN TestAccAzureRMApplicationInsights_importBasicOther --- PASS: TestAccAzureRMApplicationInsights_importBasicOther (96.48s) === RUN TestAccAzureRMApplicationInsights_basicWeb --- PASS: TestAccAzureRMApplicationInsights_basicWeb (84.27s) === RUN TestAccAzureRMApplicationInsights_basicJava --- PASS: TestAccAzureRMApplicationInsights_basicJava (79.28s) === RUN TestAccAzureRMApplicationInsights_basicOther --- PASS: TestAccAzureRMApplicationInsights_basicOther (73.29s) === RUN TestAccAzureRMApplicationInsights_basicPhone --- PASS: TestAccAzureRMApplicationInsights_basicPhone (73.88s) === RUN TestAccAzureRMApplicationInsights_basicStore --- PASS: TestAccAzureRMApplicationInsights_basicStore (68.69s) === RUN TestAccAzureRMApplicationInsights_basiciOS --- PASS: TestAccAzureRMApplicationInsights_basiciOS (76.30s) PASS ok github.com/terraform-providers/terraform-provider-azurerm/azurerm 651.307s ```
…1563) Fixes: #822 This follows the work in the API to allow types like web, other, java, store, phone and ios ``` ▶ acctests azurerm TestAccAzureRMApplicationInsights_ === RUN TestAccAzureRMApplicationInsights_importBasicWeb --- PASS: TestAccAzureRMApplicationInsights_importBasicWeb (99.07s) === RUN TestAccAzureRMApplicationInsights_importBasicOther --- PASS: TestAccAzureRMApplicationInsights_importBasicOther (96.48s) === RUN TestAccAzureRMApplicationInsights_basicWeb --- PASS: TestAccAzureRMApplicationInsights_basicWeb (84.27s) === RUN TestAccAzureRMApplicationInsights_basicJava --- PASS: TestAccAzureRMApplicationInsights_basicJava (79.28s) === RUN TestAccAzureRMApplicationInsights_basicOther --- PASS: TestAccAzureRMApplicationInsights_basicOther (73.29s) === RUN TestAccAzureRMApplicationInsights_basicPhone --- PASS: TestAccAzureRMApplicationInsights_basicPhone (73.88s) === RUN TestAccAzureRMApplicationInsights_basicStore --- PASS: TestAccAzureRMApplicationInsights_basicStore (68.69s) === RUN TestAccAzureRMApplicationInsights_basiciOS --- PASS: TestAccAzureRMApplicationInsights_basiciOS (76.30s) PASS ok github.com/terraform-providers/terraform-provider-azurerm/azurerm 651.307s ```
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
When creating a new Application Insights instance for a non-web resource (like Functions) you can set the application_type to "Other" according to documentation. However, when you do this the resulting Application Insights instance is still set to a type of "ASP.Net".
Terraform Version
Affected Resource(s)
Terraform Configuration Files
Expected Behavior
An Application Insights instance was created with a "Type" of "General".
Actual Behavior
An Application Insights instance was created with a "Type" of "ASP.Net".
Steps to Reproduce
Run above HCL snippet and the result can be immediately observed.
The text was updated successfully, but these errors were encountered: