Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Application Insights provider ignores application_type - always sets to "ASP.Net" #822

Closed
sjwaight opened this issue Feb 11, 2018 · 2 comments · Fixed by #1563
Closed

Application Insights provider ignores application_type - always sets to "ASP.Net" #822

sjwaight opened this issue Feb 11, 2018 · 2 comments · Fixed by #1563

Comments

@sjwaight
Copy link

When creating a new Application Insights instance for a non-web resource (like Functions) you can set the application_type to "Other" according to documentation. However, when you do this the resulting Application Insights instance is still set to a type of "ASP.Net".

Terraform Version

  • Terraform v0.11.2
  • provider.azurerm v1.1.0

Affected Resource(s)

  • azurerm_application_insights

Terraform Configuration Files

resource "azurerm_application_insights" "demo_funcs_ai" {
  name                = "ai-fa-demofunctions"
  location            = "West US 2"
  resource_group_name = "demo-rg-appinsights"
  application_type    = "Other"
}

Expected Behavior

An Application Insights instance was created with a "Type" of "General".

Actual Behavior

An Application Insights instance was created with a "Type" of "ASP.Net".

Steps to Reproduce

Run above HCL snippet and the result can be immediately observed.

@achandmsft achandmsft added this to the 1.4.0 milestone Mar 8, 2018
@tombuildsstuff tombuildsstuff modified the milestones: 1.4.0, Soon Apr 17, 2018
@katbyte katbyte removed the triage label May 31, 2018
@tombuildsstuff tombuildsstuff modified the milestones: Soon, 1.8.0 Jun 19, 2018
@katbyte katbyte modified the milestones: 1.8.0, 1.9.0 Jun 28, 2018
@tombuildsstuff tombuildsstuff modified the milestones: 1.9.0, Soon Jul 2, 2018
@stack72
Copy link
Contributor

stack72 commented Jul 13, 2018

@tombuildsstuff I have been working on this - PR will be incoming soon! I just need to work out the best way to structure the tests to make sure all works as expected

stack72 added a commit to stack72/terraform-provider-azurerm that referenced this issue Jul 13, 2018
Fixes: hashicorp#822

This follows the work in the API to allow types like web, other, java,
store, phone and ios

```

```
stack72 added a commit to stack72/terraform-provider-azurerm that referenced this issue Jul 13, 2018
Fixes: hashicorp#822

This follows the work in the API to allow types like web, other, java,
store, phone and ios

```
▶ acctests azurerm TestAccAzureRMApplicationInsights_
=== RUN   TestAccAzureRMApplicationInsights_importBasicWeb
--- PASS: TestAccAzureRMApplicationInsights_importBasicWeb (99.07s)
=== RUN   TestAccAzureRMApplicationInsights_importBasicOther
--- PASS: TestAccAzureRMApplicationInsights_importBasicOther (96.48s)
=== RUN   TestAccAzureRMApplicationInsights_basicWeb
--- PASS: TestAccAzureRMApplicationInsights_basicWeb (84.27s)
=== RUN   TestAccAzureRMApplicationInsights_basicJava
--- PASS: TestAccAzureRMApplicationInsights_basicJava (79.28s)
=== RUN   TestAccAzureRMApplicationInsights_basicOther
--- PASS: TestAccAzureRMApplicationInsights_basicOther (73.29s)
=== RUN   TestAccAzureRMApplicationInsights_basicPhone
--- PASS: TestAccAzureRMApplicationInsights_basicPhone (73.88s)
=== RUN   TestAccAzureRMApplicationInsights_basicStore
--- PASS: TestAccAzureRMApplicationInsights_basicStore (68.69s)
=== RUN   TestAccAzureRMApplicationInsights_basiciOS
--- PASS: TestAccAzureRMApplicationInsights_basiciOS (76.30s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	651.307s
```
tombuildsstuff pushed a commit that referenced this issue Jul 13, 2018
…1563)

Fixes: #822

This follows the work in the API to allow types like web, other, java,
store, phone and ios

```
▶ acctests azurerm TestAccAzureRMApplicationInsights_
=== RUN   TestAccAzureRMApplicationInsights_importBasicWeb
--- PASS: TestAccAzureRMApplicationInsights_importBasicWeb (99.07s)
=== RUN   TestAccAzureRMApplicationInsights_importBasicOther
--- PASS: TestAccAzureRMApplicationInsights_importBasicOther (96.48s)
=== RUN   TestAccAzureRMApplicationInsights_basicWeb
--- PASS: TestAccAzureRMApplicationInsights_basicWeb (84.27s)
=== RUN   TestAccAzureRMApplicationInsights_basicJava
--- PASS: TestAccAzureRMApplicationInsights_basicJava (79.28s)
=== RUN   TestAccAzureRMApplicationInsights_basicOther
--- PASS: TestAccAzureRMApplicationInsights_basicOther (73.29s)
=== RUN   TestAccAzureRMApplicationInsights_basicPhone
--- PASS: TestAccAzureRMApplicationInsights_basicPhone (73.88s)
=== RUN   TestAccAzureRMApplicationInsights_basicStore
--- PASS: TestAccAzureRMApplicationInsights_basicStore (68.69s)
=== RUN   TestAccAzureRMApplicationInsights_basiciOS
--- PASS: TestAccAzureRMApplicationInsights_basiciOS (76.30s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	651.307s
```
@tombuildsstuff tombuildsstuff modified the milestones: Soon, Being Sorted Oct 25, 2018
@ghost
Copy link

ghost commented Mar 6, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
6 participants